Bug 145124 - EDITING Moving down a numbered paragraph with change tracking and rejecting all gets duplicated
Summary: EDITING Moving down a numbered paragraph with change tracking and rejecting a...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: Track-Changes-Lists
  Show dependency treegraph
 
Reported: 2021-10-14 10:12 UTC by Gabor Kelemen (allotropia)
Modified: 2021-10-30 04:38 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the original document in Writer (49.23 KB, image/png)
2021-10-14 10:12 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the document in Writer after moving the paragraph (82.37 KB, image/png)
2021-10-14 10:12 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the problem in Writer (52.98 KB, image/png)
2021-10-14 10:13 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2021-10-14 10:12:36 UTC
Created attachment 175730 [details]
Screenshot of the original document in Writer

This is a followup to bug 39721
Moving down a paragraph to be the last in the document and rejecting all changes results in the duplication of that paragraph.

Steps to reproduce:
    1. Open attachment 166793 [details] from bug 39721 (you can reject all existing tracked changes in this, this problem is independent of those)
    2. Go to the second “the quick brown flying fox” paragraph
    3. Using the Bullets and Numbering toolbar move it downwards so it is deleted from its original position and inserted as last paragraph of the document
    4. On the Manage changes dialog or toolbar press Reject all

Actual results:
Two “the quick brown flying fox” paragraphs are kept below the empty one.
Another problem would be to move down the first “the quick brown flying fox” paragraph and rejecting it: then the numbering would stick to the empty paragraph below the first “Franz jagt“ paragraph. This may or may not be a separate issue, not filing it yet.

Expected results:
Only one “the quick brown flying fox” paragraph.

LibreOffice details:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: fb3e13cae8ab0915facaf07fe5fca177a4041a9b
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded

Also happens in 7.0, 6.3.
In 6.2 and before the “Franz jagt“ paragraph disappeared completely, but there was only one  the quick brown flying fox” paragraph after reject all, so it was differently bad.
Comment 1 Gabor Kelemen (allotropia) 2021-10-14 10:12:59 UTC
Created attachment 175731 [details]
Screenshot of the document in Writer after moving the paragraph
Comment 2 Gabor Kelemen (allotropia) 2021-10-14 10:13:15 UTC
Created attachment 175732 [details]
Screenshot of the problem in Writer
Comment 3 Gabor Kelemen (allotropia) 2021-10-14 10:33:58 UTC
This seems to have started with:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=f83e22f535c1c9482c5d3f566d5d0283355dd98f

author	Michael Stahl <Michael.Stahl@cib.de>	2019-04-16 19:00:50 +0200
committer	Michael Stahl <Michael.Stahl@cib.de>	2019-04-17 11:28:36 +0200
commit f83e22f535c1c9482c5d3f566d5d0283355dd98f (patch)

tdf#109376 sw: fix redline SwUndoDelete with end pos on SwTableNode crash

Adding CC to: Michael Stahl

Also the other problem with the third empty paragraph getting numbered after move down+reject all seems to be present before this, so rather a separate issue.
Comment 4 Telesto 2021-10-29 07:34:06 UTC
Repro
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 93115d2c54d645bcf2f80fde325e3ede39dee4d5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL