Bug 145178 - ODF import; Custom formats for Footnotes/Endnotes inside a section are not read from saved files, all numbering types convert to Arabic
Summary: ODF import; Custom formats for Footnotes/Endnotes inside a section are not re...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.6.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Louis Possoz
URL:
Whiteboard: odf target:7.4.0 target:7.3.5 target:...
Keywords: bibisectRequest, dataLoss, filter:odt, regression
Depends on:
Blocks: Footnote-Endnote Section
  Show dependency treegraph
 
Reported: 2021-10-17 06:30 UTC by mc.wikipediano
Modified: 2022-06-13 06:25 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Footnote/Endnote settings after step 3 (43.01 KB, image/jpeg)
2021-11-02 07:10 UTC, Dieter
Details
Screenshot of actual result (42.80 KB, image/jpeg)
2021-11-02 07:11 UTC, Dieter
Details
actual result (49.59 KB, image/jpeg)
2022-04-14 15:01 UTC, Dieter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mc.wikipediano 2021-10-17 06:30:46 UTC
Description:
Custom formats for Footnotes/Endnotes inside a section are saved in the file.
But when I reopen the file their values are always "Spin button own format" = "1" and "After" = "".

Steps to Reproduce:
1.New file.
2.Insert section with custom formats for Footnotes/Endnotes (e.g. Footnotes: "Before" = "(", "Spin button own format" = "1st", "After" = ")"; Endnotes: "Before" = "[", "Spin button own format" = "α, β, ... (gr)", "After" = "]").
3.Save file and close.
4.Reopen file.

Actual Results:
"Spin button own format" = "1,2,3..." and "After" = "" for Footnotes and for Endnotes.

Expected Results:
Use saved "Spin button own format" and "After" values for Footnotes and Endnotes.
In content.xml:
<text:notes-configuration text:note-class="footnote" text:start-value="1" style:num-prefix="(" style:num-suffix=")" style:num-format="1st"/><text:notes-configuration text:note-class="endnote" text:start-value="1" style:num-prefix="[" style:num-suffix="]" style:num-format="α, β, ... (gr)"/>


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.2.2.2 (x64) / LibreOffice Community
Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded

The same problem with version 7.1.6.2, but not with version 7.0.6.
Comment 1 Dieter 2021-11-02 07:09:38 UTC
I confirm it with

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 273a25c796fca9afa0dfadac57dc3f336831221c
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Steps to reproduce:
1. Open new document
2. Insert => Section
3. In Footnotes/Endnote tab choose settings from attachment
4. Insert => Save => Reload
5. In Navigator select section => Edit => Options

Expected result
Footnotes/Endnote settings remain

Actual result
Footnote/Endnote settings have changed
Comment 2 Dieter 2021-11-02 07:10:32 UTC
Created attachment 176070 [details]
Footnote/Endnote settings after step 3
Comment 3 Dieter 2021-11-02 07:11:06 UTC
Created attachment 176071 [details]
Screenshot of actual result
Comment 4 mc.wikipediano 2021-11-27 13:49:34 UTC
Confirmed in this version

Version: 7.2.3.2 (x64) / LibreOffice Community
Build ID: d166454616c1632304285822f9c83ce2e660fd92
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded
Comment 5 mc.wikipediano 2022-01-01 17:26:55 UTC
Confirmed in this version:

Version: 7.1.8.1 (x64) / LibreOffice Community
Build ID: e1f30c802c3269a1d052614453f260e49458c82c
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded
Comment 6 mc.wikipediano 2022-01-01 17:31:22 UTC
Confirmed in this version:

Version: 7.2.4.1 (x64) / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded
Comment 7 mc.wikipediano 2022-01-01 17:38:45 UTC
Confirmed in this version:

Version: 7.3.0.1 (x64) / LibreOffice Community
Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded
Comment 8 Louis Possoz 2022-04-14 08:33:41 UTC
In release 7.3.3.2, I found that all settings made with
   Tools -> Footnotes and Endnotes
are correctly saved and restored
But, that the section settings for the endnnote after string made with
   Format -> Sections -> Options -> Footnotes/Endnotes : Endnotes, Collect at end        of section, Restart numbering, Custom format, After = "]"
is correctly saved but is not restored.
Comment 9 Dieter 2022-04-14 15:01:53 UTC
Created attachment 179563 [details]
actual result

Bug is still present in

Version: 7.3.2.2 (x64) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 10 Dieter 2022-04-14 15:03:08 UTC
(In reply to Louis Possoz from comment #8)
>    Format -> Sections -> Options -> Footnotes/Endnotes : Endnotes, Collect
> at end        of section, Restart numbering, Custom format, After = "]"
> is correctly saved but is not restored.

Yes, that's what the bug is about.
Comment 11 mc.wikipediano 2022-04-15 06:27:44 UTC
Most recent mention of RID_SVXSTRARY_NUMBERINGTYPE in changelog.

> 2017-06-01 Caolán McNamara <caolanm@redhat.com> 088ef5dd64dfa653d6a0f6e5f73f1b6078910bca]
>        wrong resource manager for RID_SVXSTRARY_NUMBERINGTYPE
>        Change-Id: I4c348ee56ae3e90513c8ebd19e0f506bbf0d70f0
Comment 12 Commit Notification 2022-05-27 19:12:27 UTC
Louis Possoz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bbec710bd25fc5da27636cde73fe4ab23c76904f

tdf#145178 Formats in section Foot/Endnotes not read from saved files

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2022-05-28 14:47:25 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9896f330cdb3df67b74b16a2c2177a8505fd2485

tdf#145178 xmloff: ODF import: fix another bad attribute

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2022-05-28 14:48:37 UTC
Louis Possoz committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/aa8aab0a753d6ee79cb371b2a4f141070715449a

tdf#145178 Formats in section Foot/Endnotes not read from saved files

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 mc.wikipediano 2022-05-30 05:42:58 UTC
"Before", "After": ok
Custom numbering: not restored

Version: 7.3.5.0.0+ (x64) / LibreOffice Community
Build ID: c3a1f4cc50fa4a17589ca1b4643a554964af59a3
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded
Comment 16 mc.wikipediano 2022-05-30 05:43:32 UTC
"Before", "After": ok
Custom numbering: not restored

Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 212cb61fb6adc05395b9f9afe0dacbd6594ae06b
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: threaded
Comment 17 Commit Notification 2022-05-30 07:53:06 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/2a996c90ed1fc1b89ffd276e84ae4567595ff619

tdf#145178 xmloff: ODF import: fix another bad attribute

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Michael Stahl (allotropia) 2022-05-30 10:28:18 UTC
there is a separate bug 148024 which is not a regression, that certain numbering types convert to Arabic on ODF import.

*this* bug is that *all* numbering types convert to Arabic on ODF import, which only started to happen with 7.1, and appears to be fixed now.

please use e.g "I, II, III" / "i, ii, iii" / "A, B, C" / "a, b, c" for testing *this* bug and report results for other formats in the other bug.

thanks Louis for fixing this!
Comment 19 Commit Notification 2022-05-30 18:38:45 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ab1cc47d5f0bdc238c86bec5725055efb8aa5d8f

tdf#145178: sw: Add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2022-06-01 16:59:39 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-4":

https://git.libreoffice.org/core/commit/0292bf35109ec5eeb8d2fd098aae76c7db9fb1f4

tdf#145178 xmloff: ODF import: fix another bad attribute

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Commit Notification 2022-06-01 17:05:00 UTC
Louis Possoz committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-4":

https://git.libreoffice.org/core/commit/b58c969f11a9ce5824ace49d21ead73afb776874

tdf#145178 Formats in section Foot/Endnotes not read from saved files

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Dieter 2022-06-13 06:25:35 UTC
Tested with

Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

and settings from attachment 176070 [details]

Result: Settings remain, but 1st, 2nd, ... become 1, 2, ... and greek letters become i, ii, ..., but this is another problem than the one mentioned in bug 18. I will test in LO 7.4 and perhaps open a new report

Works perfect with a,b,c and 1,2,3 so I can verify, that this bug has been fixed. Thank you for fixing it!