Bug 145193 - Single quotation mark spacing changes with character of when highlighting a part (Harfbuzz?)
Summary: Single quotation mark spacing changes with character of when highlighting a p...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2021-10-18 06:32 UTC by Telesto
Modified: 2022-11-17 13:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (8.28 KB, application/vnd.oasis.opendocument.text)
2021-10-18 06:32 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-10-18 06:32:38 UTC
Description:
Single quotation mark spacing changes with character of when highlighting a part

Steps to Reproduce:
1. open the attached file
2. Press delete..
3. Dance with undo/redo.. notice the shifting
4. End with undo
5. Select portion of the Single quotation marks & apply highlighting. -> Notice spacing changing within the highlighting area

Actual Results:
Changing spacing

Expected Results:
I would assume this shouldn't matter for layout. 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 93115d2c54d645bcf2f80fde325e3ede39dee4d5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-10-18 06:32:54 UTC
Created attachment 175804 [details]
Example file
Comment 2 Telesto 2021-10-18 06:38:19 UTC
Also in
Version: 5.3.0.3
Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; Layout Engine: new; 
Locale: nl-NL (nl_NL); Calc: group

-> the new engine.. fine with the old

also not in
Version: 5.2.5.0.0+
Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8
CPU Threads: 4; OS Version: Windows 6.2; UI Render: GL; 
TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time: 2016-12-24_14:43:55
Locale: nl-NL (nl_NL); Calc: CL


The new engine should explicitly forced on while bibisecting with the commandline switch..
Comment 3 V Stuart Foote 2021-10-18 19:32:58 UTC
Applying a highlight splits the text run, applying a new text format including the highlight. If you select the entire run of single quote glyphs and apply highlight there is no shift as the text span is intact.

Frankly, I don't think this has anything to do with the HarfBuzz refactor at 5.3.0
Comment 4 Telesto 2021-10-18 19:57:27 UTC
(In reply to V Stuart Foote from comment #3)
> Frankly, I don't think this has anything to do with the HarfBuzz refactor at
> 5.3.0

Well I tested 5.3.0.3 with old and new layout engine.. it's fine with OLD but present with the NEW layout engine.. 

So the new engine might uncovered pre-existing bug (or made it more prominent)

No clue if the 'quote' glyph being some way different processed compared to other symbols.

The highlighting text parts causing shifts is more common problem. I blamed it on 'RSID' at bug 140161 (see also the see also there). Except the quotation marks being affected since 5.3.0 (and pretty easy to reproduce)

Deleting the 'l' causing spacing the change is bit surprising to me. Normally it starts with 'font color/highlighting'

But the whole text rendering is beyond my understanding (glyphs/ text portions, RSID)
Comment 5 Ezinne 2022-04-29 12:44:04 UTC
Reproducible using:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 5453f75a1e682992f3a725781bb563b8cc76cf1b
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 6 Telesto 2022-11-17 13:24:09 UTC
Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a81e957f5026373f3935390c786c21416fc74fcc
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded