Bug 145232 - The Danish LibreOffice Help does not show index (offline as well as online)
Summary: The Danish LibreOffice Help does not show index (offline as well as online)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.2.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-20 06:59 UTC by Jesper Korsholm Brogaard
Modified: 2021-10-23 18:03 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of Danish offline help (124.03 KB, image/jpeg)
2021-10-20 07:05 UTC, Jesper Korsholm Brogaard
Details
Screenshot of Danish online help (110.40 KB, image/jpeg)
2021-10-20 07:06 UTC, Jesper Korsholm Brogaard
Details
Screenshot of the English online help (224.44 KB, image/jpeg)
2021-10-20 07:10 UTC, Jesper Korsholm Brogaard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesper Korsholm Brogaard 2021-10-20 06:59:20 UTC
Description:
When hitting F1 in the Danish LibreOffice, no index is shown. The search function is not working either

The same is happening in the Danish online help


Steps to Reproduce:
Offline help
1. Start LibreOffice with Danish language
2. Press F1

Online help
1. go to help.libreoffice.org
2. choose Danish in the Language dropdown menu


Actual Results:
Offline and online help:
No index is shown and it is not possible to search in the chosen module

Expected Results:
An index and the possibility to search in the chosen module, like in e.g. English:
https://help.libreoffice.org/latest/en-US/text/shared/05/new_help.html

or in German:
https://help.libreoffice.org/latest/de/text/shared/05/new_help.html



Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
My current version of LibreOffice is 7.2.2.2 x64 (on Windows 10), but I have also had the issue for previous versions
Comment 1 Jesper Korsholm Brogaard 2021-10-20 07:05:35 UTC
Created attachment 175842 [details]
Screenshot of Danish offline help
Comment 2 Jesper Korsholm Brogaard 2021-10-20 07:06:19 UTC
Created attachment 175843 [details]
Screenshot of Danish online help
Comment 3 Jesper Korsholm Brogaard 2021-10-20 07:10:16 UTC
Created attachment 175844 [details]
Screenshot of the English online help
Comment 4 Buovjaga 2021-10-20 07:38:48 UTC
The generated bookmarks file is somehow broken, still in 7.3: https://help.libreoffice.org/7.3/da/bookmarks.js
Comment 5 Jesper Korsholm Brogaard 2021-10-20 12:46:45 UTC
I checked the contents of the file and found two errors:

Line number 2 and 3:
afsnit --  automatisk nummerering"},
{url:"da/text/swriter/guide/auto_numbering.html?DbPAR=WRITER#bm_id3147407", app:"WRITER", text:"

should be : {url:"da/text/swriter/guide/auto_numbering.html?DbPAR=WRITER#bm_id3147407", app:"WRITER", text:"afsnit --  automatisk nummerering"},

Line number 3069 and 3070:
attributten bred harpunpil"},
{url:"da/text/smath/01/03090600.html?DbPAR=MATH#bm_id3154011", app:"MATH", text:"

Should be: {url:"da/text/smath/01/03090600.html?DbPAR=MATH#bm_id3154011", app:"MATH", text:"attributten bred harpunpil"},

When I correct the errors in the offline bookmarks.js, the index appears as expected when I hit F1.
Comment 6 Jesper Korsholm Brogaard 2021-10-20 16:39:26 UTC
I suspect a newline character in the two strings to be the cause to the bug. 

I have removed the characters in Weblate for LibreOffice Help 7.2 and await posibillity to test whether it resolves the issue.
Comment 7 Buovjaga 2021-10-21 08:45:09 UTC
(In reply to Jesper Korsholm Brogaard from comment #6)
> I suspect a newline character in the two strings to be the cause to the bug. 
> 
> I have removed the characters in Weblate for LibreOffice Help 7.2 and await
> posibillity to test whether it resolves the issue.

Can you do it in Help master as well, please? Then I could check it locally.
Comment 8 Jesper Korsholm Brogaard 2021-10-21 09:31:58 UTC
I have now made the changes in Help Master.
Comment 9 Buovjaga 2021-10-22 09:20:45 UTC
I decided to create a patch for fixing this issue at the level of the .js file generation: https://gerrit.libreoffice.org/c/help/+/124056

This way there will be no breakage even if newlines slip into translations in the future.
Comment 10 Commit Notification 2021-10-23 17:59:47 UTC
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/fb9c746f6aaae147aa16b1f2b682e01d07003d03

tdf#145232 get_bookmark.xsl: Use normalize-space()