Bug 145274 - FILEOPEN: Text properties are lost
Summary: FILEOPEN: Text properties are lost
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-10-22 09:57 UTC by Xisco Faulí
Modified: 2021-10-29 12:40 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.3 master (13.96 KB, image/png)
2021-10-22 09:57 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-10-22 09:57:24 UTC
Created attachment 175874 [details]
Comparison MSO 2010 and LibreOffice 7.3 master

Steps to reproduce:
1. Open attachment 45086 [details] from bug 35826

-> "link text" is blank and it's not underscore. See comparison image

Reproduced in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: ea65215855462e5e48f7a3a78724c38b5fc0e4d1
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2021-10-22 09:58:29 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=b62153753a9f21afb2a49110ef0459e427b0b01a

author	Noel Grandin <noel@peralex.com>	2021-09-28 14:47:58 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2021-09-28 18:24:52 +0200
commit b62153753a9f21afb2a49110ef0459e427b0b01a (patch)
tree 223e90503ecb82657a9990ddca7103296b20648c
parent 082394a8ff125a7a7a009f60a0002d1d4c2ca7fb (diff)
tdf#135683 speedup SwAttrHandler

Bisected with: bibisect-linux64-7.3

Adding Cc: to Noel Grandin
Comment 2 Commit Notification 2021-10-22 13:38:44 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f3628260e55baf871bd29922075f1498a80e438f

tdf#145274 FILEOPEN: Text properties are lost

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 BogdanB 2021-10-26 18:42:58 UTC
Eveything is fine now.

Verified with
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: ca74611acfef50280a2c1f785448d9a09cca5a0d
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 4 Commit Notification 2021-10-29 12:40:25 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/80afffed57564e40854c1bb8a539fdc3c22b9684

tdf#145274: vcl_pdfexport: Add unittest

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.