Bug 145528 - FILEOPEN PPTX: text is vertically off, too low/too high ("cloverleaf" SmartArt)
Summary: FILEOPEN PPTX: text is vertically off, too low/too high ("cloverleaf" SmartArt)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks: OOXML-SmartArt
  Show dependency treegraph
 
Reported: 2021-11-03 15:30 UTC by Gerald Pfeifer
Modified: 2022-08-28 20:51 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample PPTX slide (103.92 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2021-11-03 15:30 UTC, Gerald Pfeifer
Details
Visual comparison Office 365 vs LibreOffice 7.3 (68.43 KB, image/png)
2021-11-03 15:31 UTC, Gerald Pfeifer
Details
Screenshot in early 4.3 (118.84 KB, image/png)
2021-11-19 21:59 UTC, Aron Budea
Details
Screenshot with 2022-07-21 daily build (159.99 KB, image/png)
2022-07-21 10:16 UTC, Gerald Pfeifer
Details
Screenshot with 2022-07-25 daily build (150.02 KB, image/png)
2022-07-25 08:16 UTC, Gerald Pfeifer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2021-11-03 15:30:41 UTC
Created attachment 176093 [details]
Sample PPTX slide

This originally stems from SmartArt, but shows even saved from current
Office 365 which usually should represent things reasonably?

Opening the sample document in Impress, note how the text in the four
leafs, or quadrants, is too low and runs into the center piece, or too
high and runs into the center piece.


Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: f4b353c1f52fc78a102413cac94c7fb24292bec6
CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US

Already present in Version: 6.4.8.0.0+
Build ID: 99b065ec31d032fc08ab14f66430dac4fef904a5
CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: gtk3; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-6-4, Time: 2020-10-08_08:57:08
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Comment 1 Gerald Pfeifer 2021-11-03 15:31:24 UTC
Created attachment 176094 [details]
Visual comparison Office 365 vs LibreOffice 7.3
Comment 2 Xisco Faulí 2021-11-04 09:54:44 UTC
Reproduced in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: ca74611acfef50280a2c1f785448d9a09cca5a0d
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

and in

Version: 5.2.0.0.alpha1+
Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e
CPU Threads: 4; OS Version: Linux 5.10; UI Render: default; 
Locale: en-US (en_US.UTF-8)
Comment 3 Aron Budea 2021-11-19 21:57:54 UTC
There are two, perhaps somewhat relevant changes in 4.3 that affected this in LO. Before the commits below, it can be seen that there was some attempt for the texts to avoid the central element, even if it didn't work out well.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=e3e12b1d1e36e1a0d4fc4c6423b584d677693897
author		Muthu Subramanian <sumuthu@collabora.com>	2014-03-26 16:05:44 +0530
committer	Muthu Subramanian <sumuthu@collabora.com>	2014-03-27 13:27:28 +0530

"n#862510: Fix text rotation."

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c17eb67460293fbe72ffa8e80cd10743df493afa
author		Muthu Subramanian <sumuthu@collabora.com>	2014-03-26 16:13:08 +0530
committer	Muthu Subramanian <sumuthu@collabora.com>	2014-03-27 13:27:28 +0530

"n#862510: anchorCtr controls the anchoring as well."
Comment 4 Aron Budea 2021-11-19 21:59:08 UTC
Created attachment 176369 [details]
Screenshot in early 4.3
Comment 5 Regina Henschel 2022-07-20 00:40:12 UTC
It seems this is another one, where the <txXfrm> element is not evaluated. I will have a look.
Comment 6 Gerald Pfeifer 2022-07-21 10:16:02 UTC
Created attachment 181354 [details]
Screenshot with 2022-07-21 daily build

(In reply to Regina Henschel from comment #5)
> It seems this is another one, where the <txXfrm> element is not evaluated. 
> I will have a look.

Thank you, Regina.

Looking at today's daily build

  Version: 7.5.0.0.alpha0+ / LibreOffice Community
  Build ID: eea7038c182cc1f6cd792359053ea2561a200026
  CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

which addresses some related SmartArt issues due to your work the original
issue still appears present *and* the text blocks now show much narrower in
comparison to Office 365 or LibreOffice when I filed this.
Comment 7 Commit Notification 2022-07-21 10:42:14 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c6965c5bcc95430c2a2d01051791d23f2c2f5a5b

tdf#145528 add round1Rect to SmartArt text area corrections

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Regina Henschel 2022-07-21 10:56:24 UTC
(In reply to Gerald Pfeifer from comment #6)
> 
> Looking at today's daily build
> 
>   Version: 7.5.0.0.alpha0+ / LibreOffice Community
>   Build ID: eea7038c182cc1f6cd792359053ea2561a200026
>   CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3
>   Locale: en-US (en_US.UTF-8); UI: en-US
> 
> which addresses some related SmartArt issues due to your work the original
> issue still appears present *and* the text blocks now show much narrower in
> comparison to Office 365 or LibreOffice when I filed this.

This SmartArt uses shapes of type 'round1Rect'. Those were not included in my previous patch. I have added it just. So you need to wait for testing until that is included in the daily, likely tomorrow.
Comment 9 Gerald Pfeifer 2022-07-25 08:16:07 UTC
Created attachment 181399 [details]
Screenshot with 2022-07-25 daily build

With today's daily build this shows pretty much like the PowerPoint
screenshot from attachment #176094 [details].

Thank you, Regina!

(There is a minor difference in the lower right quadrant, where the
text box touches the center box, when it does not in PowerPoint. That
may be due to font or some padding somewhere?)


Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 41f02927b6d8470c298c8a2f407c98420a5ebe24
CPU threads: 8; OS: Linux 5.18; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Comment 10 Gerald Pfeifer 2022-08-28 20:51:07 UTC
Marking as VERIFIED, which I missed doing with comment #9.