Bug 145547 - [GTK3] can't right-click tabbed UI styles preview
Summary: [GTK3] can't right-click tabbed UI styles preview
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.4 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: GTK3 Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2021-11-05 02:24 UTC by Stéphane Guillou (stragu)
Modified: 2024-05-21 02:11 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2021-11-05 02:24:54 UTC
Description:
Richt-clicking of style previews in the tabbed UI was implemented for Bug 137121.
However, when using GTK3, right-clicking the first row of styles does not open a context menu, and right-clicking the following rows of headings result in what would happen if you right-clicked somewhere in the document.

Steps to Reproduce:
1. Open Writer
2. Change "View > User Interface..." to "Tabbed"
3. Right-click on a style in the Home tab's style preview area

Actual Results:
Right-clicking the first row of styles does not open a context menu, and right-clicking the following rows of headings result in what would happen if you right-clicked somewhere in the document.

Expected Results:
Right-clicking a style preview should open a context menu.


Reproducible: Always


User Profile Reset: No



Additional Info:
Reproduced in:

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 5b2848413883565c48d312c96daf8fbca25405d8
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-10-11_23:38:53
Calc: threaded

and:

Version: 7.2.2.2 / LibreOffice Community
Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Using SAL_USE_VCLPLUGIN=gen will allow right-clicking as expected.
I am not sure if it ever worked with GTK3, or if it is a regression.
Jim Raykowski seems to think it is a regression: https://bugs.documentfoundation.org/show_bug.cgi?id=137121#c14
Comment 1 Stéphane Guillou (stragu) 2021-11-05 02:28:35 UTC
Adding meta bug, and related bug in "See also".
Comment 2 Ezinne 2021-11-14 21:18:12 UTC
Reproducible in:

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 86d11097cd4a2ae4a6b4e6b35e28a6075376d67a
CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Stéphane Guillou (stragu) 2024-05-21 02:10:32 UTC
Used to work when it was implemented by Jim in f16ab02c98b8d3483f6b6a7f8f10a4e41b545464.

Bibisected with linux-64-7.2 to first bad build [7802521f69c71eee6a11517ecb0d6c8d8e57a015] which is:

commit fd9b52502de6044a2249ff81407ac579a35ad3a1
author	Szymon Kłos 	Tue Feb 02 16:12:55 2021 +0100
committer	Szymon Kłos 	Thu Feb 11 18:50:48 2021 +0100
tdf#139429 Convert Style previews widget to IconView
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110408

Szymon, can you please have a look?