Bug 145673 - UI: comment box doesn't expand while typing (scrollbar instead)
Summary: UI: comment box doesn't expand while typing (scrollbar instead)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: All All
: medium minor
Assignee: Not Assigned
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
Reported: 2021-11-14 08:18 UTC by Telesto
Modified: 2023-11-16 03:12 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Screencast (234.57 KB, video/mp4)
2021-11-14 08:29 UTC, Telesto
Sample document demonstrates behavior (8.86 KB, application/vnd.oasis.opendocument.text)
2021-11-15 07:01 UTC, Rainer Bielefeld Retired

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-11-14 08:18:01 UTC
UI: comment box doesn't expand while typing

Steps to Reproduce:
1. Open attachment 176216 [details]
2. Place cursor inside the comment box hello world 
3. Press CTRL+A
4. Type: "1"
5. press Enter
6. Type "2"
7. Press Enter -> Scrollbar appears.. comment box isn't expanding

Not sure what's so special about this file.. I can't reproduce it from scratch

Actual Results:
Comment box not expanding

Expected Results:
Should be the case

Reproducible: Always

User Profile Reset: No

Additional Info:
Version: (x64) / LibreOffice Community
Build ID: 73334560b2dd2d60ac58d2cc2b1a5295490b03e1
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-11-14 08:20:10 UTC
Sorry it actually is reproducible from scratch, if you create the same setup as in the document with 2 comment boxes
Comment 2 Telesto 2021-11-14 08:28:09 UTC
Also in
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735
Comment 3 Telesto 2021-11-14 08:29:39 UTC
Created attachment 176241 [details]
Comment 4 Telesto 2021-11-14 08:37:52 UTC
Have a number of fixes recently related to weld annotation window. The bug here is unrelated to welding. However you're knowledge of the annotate stuff is likely still fresh; so this might be easy solvable. If you're interested of course

Not even totally sure if this being a bug or by design for performance reasons. Live updating comment size boxes could be pretty expensive in large documents with plenty of comments?
Comment 5 Rainer Bielefeld Retired 2021-11-15 07:01:20 UTC
Created attachment 176255 [details]
Sample document demonstrates behavior

My observation with newly created WRITER document amd Installation of Version: (x64); Build ID: 87b77fad49947c1441b67c559c339af8f3517e22; CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI: de-DE; Calc: threaded  |  my default User Profile:

When I type text Comment Box will expand if there is room enough.
As soon as it is going to touch Comment Box below the box will not go on to expand, but vertical scroll bar appears.

I think that is a useful and probably the intended behavior.

For your own tests simply type some nonsense strings into comment boxes. Always when room for expansion is spent Comment Box will no longer expand, but vertical scroll bar appears.
Comment 6 Telesto 2021-11-15 08:34:23 UTC
(In reply to Rainer Bielefeld Retired from comment #5)
> When I type text Comment Box will expand if there is room enough.
> As soon as it is going to touch Comment Box below the box will not go on to
> expand, but vertical scroll bar appears.
> I think that is a useful and probably the intended behavior.

If you exit the comment box with scrollbar, so placing the cursor outside the comment box, the comment box will expand as long as enough room available on 'margin' of the page 

I'm slightly "allergic" for scrollbar, because it's hiding the text you typed previously. I would prefer see it expand immediately, if this would happen anyhow (after exit of comment box it does adapt). This is more WYSIWYG and prevents masking text & the flawing after leaving the comment box.

* automatic expanding probably somewhat expansive (and there are already pre-existing perf issues; Noel has done some investigations what needs to be done, however needs funding before getting fixed)
* It would mean that bottom document comment boxes would expand at the top side (don't think this would be an issue)
* At the point the margin being filled with comment boxes all of those would get scroll bars. Advantage: you don't have to type in a 2 row comment box, but it's equal distributed for the start (with adaptive size). 
* I would even go the opposite saying when entering a comment box with a hugh text, shrink all other comment boxes even more, so you can see the full text until exit. Would make reading a comment more comfortable, I estimate. Instead of having a 30 lines of text and only lines visible (yes those document with tremendous amount of comments exist).
Comment 7 Heiko Tietze 2021-11-15 08:55:08 UTC
Guess it's just a tricky implementation to expand while typing if there is sufficient space. It would improve UX but is not crucial.
Comment 8 QA Administrators 2023-11-16 03:12:52 UTC
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team