Bug 145711 - Error 1324: The Folder Path Contains an Invalid Character (Adobe Japan1/H)
Summary: Error 1324: The Folder Path Contains an Invalid Character (Adobe Japan1/H)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Installation (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.3.0 target:7.2.5
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-16 08:44 UTC by Telesto
Modified: 2021-12-06 13:28 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Log (376.92 KB, application/x-zip-compressed)
2021-11-16 10:30 UTC, Telesto
Details
Error message from the LOdev 7.2.4 installer (13.82 KB, image/jpeg)
2021-11-16 22:48 UTC, Stefan_Lange_KA@T-Online.de
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-11-16 08:44:04 UTC
Description:
Error 1324: The Folder Path Contains an Invalid Character

Steps to Reproduce:
1. Run installer.. 

Actual Results:
Error while installing: Error 1324: The Folder Path Contains an Invalid Character (Adobe Japan1/H)

Expected Results:
No error


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Telesto 2021-11-16 08:50:52 UTC
Still fine with build of 14-11-2021. Issue with 16-11-2021
Comment 2 Mike Kaganski 2021-11-16 09:13:57 UTC
Oh, it's incredible to see a bug reported by an experienced bug reporter, against an *installer*, its pre-release texting version, concerning *invalid characters*, without indication of the OS, locale, or the exact URL of the downloaded installer.
Comment 3 Mike Kaganski 2021-11-16 09:15:43 UTC
(In reply to Mike Kaganski from comment #2)

Of course, install path would be nice to have, too; and also detailed install script - as suggested in FAQ [1] (assuming it's Windows, as may be indicated by that "Error 1324").

[1] https://wiki.documentfoundation.org/Faq/General/General_Installation_Issues_(Windows)#Create_an_installation_log
Comment 4 Telesto 2021-11-16 10:30:35 UTC
Created attachment 176280 [details]
Log

Some system info.. 
Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 7b8f630db30ee0066a9f4b6e540368d2fcad7fa8
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Source installer: https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/
Comment 5 Mike Kaganski 2021-11-16 13:32:02 UTC
(In reply to Telesto from comment #4)

Thanks!

So the actual error message was "Fout 1324.Het pad Adobe-Japan1/H bevat een ongeldig teken.", right?

Googling MSI error 1324, http://support.microsoft.com/kb/292582 is a link in MS knowledge base (for an old product), suggesting that it may be because there's some invalid data present in the registry. It suggests to search the registry for the specific string reported in the error message - in this case, it's 'Adobe-Japan1/H', and replace it with a valid path. Specifically here, the invalid character is the forward slash '/', which likely needs to be replaces with backslash '\'.

I have no idea why could that happen; and up to now, there were no reports for that problem AFAIKT. So for now, let's consider it a random Windows failure, or possibly some problem with a random previous testing pre-alpha package, which would not be a bug until it is clear that it's in the RC/production packages.
Comment 6 phv 2021-11-16 16:18:38 UTC
I experience the same bug on Windows and exclusively with the last daily version. So the issue is not limited to the reporter's registry.
Comment 7 phv 2021-11-16 16:31:48 UTC
Note that the uninstallation of previous version does not fix the issue: LibreOffice dev installation still fails with the same error message referencing "the path to the folder Adobe-Japan1/H contains an invalid character".
Comment 8 Ming Hua 2021-11-16 16:45:25 UTC
(In reply to phv from comment #6)
> I experience the same bug on Windows and exclusively with the last daily
> version. So the issue is not limited to the reporter's registry.

Hmm.

I'm not a developer, so the following is a wild guess, and please take it with abundant amount of salt.

The string "Adobe Japan1/H" looks like a PDF-specific (or maybe just Adobe specific) encoding name to me, which added with the time this appears, makes the commit 6ea7ca45782a7e1b46e18e994534ec0a7c71951b "tdf#141709 Register poppler_data for install", 2021-11-15 16:27:54+0100 a suspect.

Adding Michael to CC.  Would you please take a look and see if it's related?  Sorry for wasting your time if it's not.
Comment 9 Telesto 2021-11-16 18:12:33 UTC
FWIW: even the administrative installation is failing (silently, so simply quitting).
Comment 10 Mike Kaganski 2021-11-16 20:46:51 UTC
(In reply to Ming Hua from comment #8)

Great catch! I'll take care of it.
Comment 11 Michael Warner 2021-11-16 21:25:52 UTC
Installing poppler_data deploys cMap/Adobe-Japan1/H (notice it uses a dash instead of a space), but this is in the middle of a long list of files in cMap/Adobe-Japan1. So, I don't know why this particular one would be causing a problem.
Comment 12 Mike Kaganski 2021-11-16 21:57:20 UTC
(In reply to Michael Warner from comment #11)
> Installing poppler_data deploys cMap/Adobe-Japan1/H (notice it uses a dash
> instead of a space),

as clarified in comment 5

> but this is in the middle of a long list of files in
> cMap/Adobe-Japan1. So, I don't know why this particular one would be causing
> a problem.

The problem is that the filename is 1-character long, and make_absolute_filename_to_relative_filename in [1] uses wrong regex that only matches no less than two-character filenames.

[1] https://opengrok.libreoffice.org/xref/core/solenv/bin/modules/installer/pathanalyzer.pm?r=2b383d19#44
Comment 13 Stefan_Lange_KA@T-Online.de 2021-11-16 22:48:34 UTC
Created attachment 176300 [details]
Error message from the LOdev 7.2.4 installer

The error also occurs in the installer of LOdev 7.2.4.0.0, in the path /daily/libreoffice-7-2/Win-x86_64@tb77-TDF/2021-11-16_08.11.48/.
See attached screenshot!
Comment 14 Commit Notification 2021-11-17 05:16:05 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f007f32958a7c875db6cb2e79c09ab0965477a2a

tdf#145711: filename may be 1-character, and must not contain path separator

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Commit Notification 2021-11-17 12:44:50 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/13a9d141b5933f81f4074dd4dc2ab98509df6518

tdf#145711: filename may be 1-character, and must not contain path separator

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 16 BogdanB 2021-11-18 11:25:09 UTC
Now I ould install LO.

Verified with
Version: 7.3.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 4be0ae19065b1b50870bc0b2a28189ad39c96a8a
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded
Comment 17 Stefan_Lange_KA@T-Online.de 2021-11-18 11:45:01 UTC
LOdev7.2.4 could be installed too with LibreOfficeDev_7.2.4.0.0_Win_x64.msi from path /daily/libreoffice-7-2/Win-x86_64@tb77-TDF/2021-11-18_00.23.13/:

Version: 7.2.4.0.0+ (x64) / LibreOffice Community
Build ID: 5cfe6907be9d7fec09c10db59a1fb29c278c23a5
CPU threads: 4; OS: Windows 10.0 Build 22000; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 18 Christian Lohmaier 2021-12-06 13:28:48 UTC
7.2.4 was a hotfix release, updating target in status-whiteboard