Bug 145842 - UI Canceling Delete from WebDAV server makes files disappear from Remote files dialog
Summary: UI Canceling Delete from WebDAV server makes files disappear from Remote file...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.3.0 target:7.2.5
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-11-22 23:20 UTC by Gabor Kelemen (allotropia)
Modified: 2021-12-06 13:28 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
The confirmation dialog before deleting an example file (74.79 KB, image/png)
2021-11-22 23:20 UTC, Gabor Kelemen (allotropia)
Details
Remote Files dialog after canceling the deletion, with the Example23.txt gone (69.89 KB, image/png)
2021-11-22 23:21 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2021-11-22 23:20:05 UTC
Created attachment 176434 [details]
The confirmation dialog before deleting an example file

When you right click on a remote file in the Remote Files dialog while browsing a WebDAV server, you can select a Delete command.
Selecting to delete a file pops up a confirmation dialog where you can approve or cancel the deletion. Choosing to cancel the whole deletion or just the current files deletion makes the file disappear from the local dialog, as if deleted.
However the file is not deleted, it stays on the server untouched and reopening the Remote files dialog shows it again.

1. Set up a remote WebDAV service, I used a NextCloud.
2. In the Remote Files dialog right click on any file / directory and select Delete
3. In the confirmation dialog select Cancel or Do not delete

The file disappears from the Remote Files dialog. Close and reopen it, and the file is still there.

Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: fcad2503ede92b515076f9bb3162855dcc2c575d
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Bibisected with linux-6.4 to:

https://git.libreoffice.org/core/+/09e3d45cdc5c739e5246388a83ccfc6d76bf66e9

author	Caolán McNamara <caolanm@redhat.com>	Mon Oct 21 14:20:12 2019 +0100
committer	Caolán McNamara <caolanm@redhat.com>	Tue Oct 29 13:58:47 2019 +0100
tree 5ae533f38a626016951b02e7d2406c368b298723
parent 93a641d291adf86491cc68ac64f4f614c937183a [diff]

weld fpicker cluster

Adding CC to: Caolán McNamara
Comment 1 Gabor Kelemen (allotropia) 2021-11-22 23:21:06 UTC
Created attachment 176435 [details]
Remote Files dialog after canceling the deletion, with the Example23.txt gone
Comment 2 Caolán McNamara 2021-11-24 20:21:01 UTC
I can reproduce with ssh/sftp too
Comment 3 Commit Notification 2021-11-24 21:26:23 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b6b7fb3d0a46a2d41fcd8f2319077fe280ff12f1

tdf#145842 canceling remote file delete makes file disappear from treeview

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Caolán McNamara 2021-11-24 21:26:43 UTC
fixed in trunk, backport to 7-2 in gerrit
Comment 5 Commit Notification 2021-11-25 09:35:48 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8c66455df8f6a26c314290f252bedbc19db6b327

Related: tdf#145842 fix a crash after deleting an entry

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-11-25 11:08:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/9d13202243b26d507b61eb4a787d1df2ce037e21

tdf#145842 canceling remote file delete makes file disappear from treeview

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Christian Lohmaier 2021-12-06 13:28:48 UTC
7.2.4 was a hotfix release, updating target in status-whiteboard