Bug 146056 - Setting page layout to 'Landscape' in Print an changing printer doesn't work properly
Summary: Setting page layout to 'Landscape' in Print an changing printer doesn't work ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: low normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Print-Dialog
  Show dependency treegraph
 
Reported: 2021-12-05 08:20 UTC by Telesto
Modified: 2023-05-30 22:31 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (12.40 KB, application/vnd.oasis.opendocument.text)
2021-12-05 08:20 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-12-05 08:20:10 UTC
Description:
Setting page layout to 'Landscape' in Print an changing printer doesn't work properly

Steps to Reproduce:
1. Open the attached file
2. Press Print or CTRL+P
3. Select Print to file
4. Change Orientation from automatic to Landscape (notice the preview changes to landscape)
5. Change printer to Fax (notice 'Landscape' being showing in the dialog at the right; preview showing "portrait"
6. Change back to "Print to file" -> Automatic re-introduced


Actual Results:
Landscape in dialog; portrait in preview

Expected Results:
Landscape?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ddc57169ac8d1de00403dbb09fef5221beaa0f3d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-12-05 08:20:25 UTC
Created attachment 176707 [details]
Example file
Comment 2 Telesto 2021-12-05 08:32:18 UTC
@Heiko
Sorry, I feel the need to underpin bug 146047 comment 3 with few additional examples :-)
Comment 3 Heiko Tietze 2021-12-06 09:24:14 UTC
Although I do not have the fax option I can confirm that manual changes to the orientation is not persistent if other parameter are changed, such as "Print to file" vs. connected printer. I would treat this as a minor annoyance since the change has a transparent feedback and the checkbox reverts to Automatic.
Comment 4 Stéphane Guillou (stragu) 2023-01-21 17:55:46 UTC
7.1 would always reset to "Automatic" when changing printers, and update the preview accordingly.

7.2 and 7.3 don't change the preview whatsoever, but would still revert to Automatic when changing printers.

Since 7.4, changing printers does not revert to "Automatic" in the dropdown, but the preview does revert to portrait mode. Changing again to the original printer does eventually revert the orientation dropdown to Automatic.

So I see it as a regression in 7.4.

Version: 7.4.4.2 / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 5 raal 2023-01-22 11:44:15 UTC
Works for me in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 17c68fad2aef917adfdd3d4d651da786e620699c
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

@Stephane, could you retest with dev version? Thank you.
Comment 6 Stéphane Guillou (stragu) 2023-01-22 17:06:38 UTC
Still reproduced with a build from today:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ff496c663904d97567f1876b2d9b758131f71be8
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I did:
1) Open Writer
2) Ctrl + P
3) Change orientation to landscape: preview switches to landscape
4) Change printer to Print to File: preview changes to portrait but orientation dropdown still shows "Landscape"
5) Change again to the original printer: orientation dropdown changes to automatic
Comment 7 Stéphane Guillou (stragu) 2023-05-30 22:31:49 UTC
(In reply to Stéphane Guillou (stragu) from comment #4)
> Since 7.4, changing printers does not revert to "Automatic" in the dropdown,
> but the preview does revert to portrait mode. Changing again to the original
> printer does eventually revert the orientation dropdown to Automatic.

I bibisected this change with linux-64-7.4 repo to commit ed278a0c54b8e06dd3ee6444d4ef8f823837107b which points to core commit:

commit ddaebfb270c4b52ddebaf678a9352312c75247fa
author	Luboš Luňák <l.lunak@collabora.com>	Mon Jan 31 20:27:54 2022 +0100
committer	Luboš Luňák <l.lunak@collabora.com>	Tue Feb 01 11:16:43 2022 +0100
fix the orientation combobox in the print dialog
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129239

Luboš mentioned there were more unresolved issues in the full commit message, probably dating back to Daniel's 8cbdc6a068ad88fc43a98bd0f88.