Bug 146073 - Kerning off (pretty big gap) on different zoom levels; sidebar on/off does change the zoom levels on which the issue occurs
Summary: Kerning off (pretty big gap) on different zoom levels; sidebar on/off does ch...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Kerning
  Show dependency treegraph
 
Reported: 2021-12-06 12:48 UTC by Telesto
Modified: 2022-01-17 15:32 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (8.96 KB, application/vnd.oasis.opendocument.text)
2021-12-06 12:48 UTC, Telesto
Details
Bibisect log (2.90 KB, text/plain)
2021-12-06 15:04 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-12-06 12:48:30 UTC
Description:
Kerning off (pretty big gap) on different zoom levels; sidebar on/off does change the zoom levels on which the issue occurs

Steps to Reproduce:
1.Open the attached file
2. Enable sidebar And make sure it's expanded
3. Zoom at 100% or 120% and notice the big gap between xs
4. Disable the sidebar
5. Zoom at 80% or 90% and notice the same issue

Actual Results:
Spacing off

Expected Results:
Proper kerning


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ddc57169ac8d1de00403dbb09fef5221beaa0f3d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-12-06 12:48:45 UTC
Created attachment 176731 [details]
Example file
Comment 2 Telesto 2021-12-06 12:54:14 UTC
Found in
7.2

still fine with
Version: 7.1.0.0.beta1+ (x64)
Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 3 Telesto 2021-12-06 15:04:01 UTC
Created attachment 176734 [details]
Bibisect log

Bisected to
author	Luboš Luňák <l.lunak@centrum.cz>	2021-02-25 10:05:36 +0000
committer	Luboš Luňák <l.lunak@collabora.com>	2021-03-01 15:56:46 +0100
commit 13f53741dabc33c5ac12ae26538a2803c6ba1073 (patch)
tree 9646a91f28e3f287f08dc0b18358a51f7805957b
parent 9cd95b10936450b5d1d60319192c25c4aea05fa3 (diff)
make sure Skia DWrite matches the given HFONT exactly (tdf#137122)
The problem appears to be that we use our private copy of the Dejavu
Sans fonts, installed using AddFontResourceExW( FR_PRIVATE ),
but that's not for whatever reason available for DirectWrite,
which made CreateFontFromLOGFONT() find the system-installed Dejavu
Sans, and if there was a difference between the two, then incorrect
glyph ids were used. Use CreateFontFaceFromHdc(), which seems
to match exactly. For private fonts this later fails the check
with GetSystemFontCollection(), which would be nice to handle
somehow, but I don't know how to get a font collection containing
those fonts other than modifying SalFont to use DirectWrite
API to install the fonts.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=13f53741dabc33c5ac12ae26538a2803c6ba1073
Comment 4 Telesto 2021-12-06 15:05:04 UTC
Bibisect note. Bibisected at 100%. Look at comment note text + main document. And if either of those where wrong, I marked it as bad.
Comment 5 Telesto 2021-12-06 15:27:39 UTC
@Aron
Me still puzzled by kerning going haywire once in a while. It's structural problem with different commits unmasking the issue without revealing the true cause
Comment 6 Rainer Bielefeld Retired 2021-12-07 05:57:32 UTC
REPRODUCIBLE with  Installation of Version 7.2.3.2 (x64) / LibreOffice 
Build  d166454616c1632304285822f9c83ce2e660fd92; CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI: de-DE; Calc: threaded;  My normal User Profile
Comment 7 Telesto 2021-12-07 08:24:37 UTC
Adding CC: to Luboš Luňák
Comment 8 Telesto 2022-01-17 10:46:34 UTC
Looks fine with
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 628fedabdd27ad08e9a42f47106864751e493c2c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL