Bug 146261 - Bookmark... dialog should hold its resize from defaults for current session
Summary: Bookmark... dialog should hold its resize from defaults for current session
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks: Dialog Dialog-Remember-Settings
  Show dependency treegraph
 
Reported: 2021-12-16 11:56 UTC by tinflower2000
Modified: 2024-01-31 14:51 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tinflower2000 2021-12-16 11:56:24 UTC
Description:
User clicks Bookmark.

Bookmark opens in its minimized form.

User stretches out Bookmark into preferred dimensions to best see list of bookmarks and their description. 

User clicks on a bookmark and dismisses Bookmark Window. 

User reopens Bookmark Window which reopens in a default minimized form. 

For a user navigating a large document via bookmarks, this annoys and frustrates productivity. 

Bookmark Window should "remember" last known session and default to the user-defined size.



Steps to Reproduce:
1.Click Bookmark icon to open Bookmark pop-up.
2.Drag that pop-up into workable shape.
3.Dismiss Bookmark pop-up.
4.Click Bookmark icon.
5.Bookmark pop-up window opens in minimized form.  

Actual Results:
Bookmark window is minimized.

Expected Results:
Useful result would be that the Bookmark pop-up retains user's modifications to it. For casual users of the Bookmark feature, this poses no inconvenience. For a user trying to get around a 500 page document, scrolling through a minimized Bookmark window or constantly pulling the Bookmark window open and down, quickly becomes a work flow issue. 


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Did you try resetting your UserProfile? 	

...try resetting you profile as described in the instructions for resolving User Profile corruption... 

TYPO in above text. Sentence should read: "try resetting YOUR profile as described"
Comment 1 V Stuart Foote 2021-12-16 14:04:02 UTC
+1

While the Bookmark... dialog can be conveniently resized (for editing or inserting a bookmark). Also the SB Navigator deck for Bookmarks can be toggled collapsed or expanded. But working with a long list of Bookmarks the ability to set and hold a larger dialog (at least for the current document) would be helpful.

More entries <==> less scrolling to find navigate to the desired bookmark. Setting and holding the dialog size and position for current document would facilitate.
Comment 2 Heiko Tietze 2021-12-17 08:16:53 UTC
We decided against resizable property dialogs; only where user input is required we allow to change the size. That's of course a fuzzy definition and we could either keep the bookmark dialog resizable (and remember the size as requested here) or make it static, with the idea to use the Navigator.
Comment 3 V Stuart Foote 2021-12-17 12:59:36 UTC
(In reply to Heiko Tietze from comment #2)
> We decided against resizable property dialogs; only where user input is
> required we allow to change the size. That's of course a fuzzy definition
> and we could either keep the bookmark dialog resizable (and remember the
> size as requested here) or make it static, with the idea to use the
> Navigator.

Except, the dialog is already resizable! Issue is that it does not remember its state for current session and must be resized on each opening for current session.

Yes the Navigator will show a scroll bar when its count of Bookmarks exceeds visible height, and the Navigator can also be undocked--or its alternate <F5> frame can be used.

Just seems like the resizable Bookmark... dialog would benefit from holding its attributes and allow a workflow with it, rather than forcing folks onto the Navigator. Where keeping the list of bookmarks expanded on the Navigator (rather than collapsed) makes other usage of the Navigator uncomfortable for documents with a lot of bookmarks.
Comment 4 Heiko Tietze 2021-12-17 13:41:55 UTC
I was pondering over the opposite of this request.

The dialog get its size from the treeview. We have no means to set a dialog size except a minimum (the preferred size). We had the discussion somewhere with Caolan...
Comment 5 Thomas Lendo 2022-01-04 19:26:47 UTC
I support the request to remember the dialog size during a session.
Comment 6 Heiko Tietze 2022-01-05 07:02:28 UTC
Restoring the dialog size is tricky, see also bug 123123 and bug 134640.
Comment 7 Cor Nouws 2022-01-05 10:19:00 UTC
I support this request. It always disturbs me that when I change (the size of) a dialog, I have to do it again the next time I open it.
Comment 8 Commit Notification 2022-01-28 17:06:10 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1dea71cbaa04a68aa496a146bb71a690aed0f88d

Related: tdf#146261 the intent it to keep the dialog within the screen

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-01-31 11:24:06 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ad1da9345b75dbe3ed9c503916c83c38d8a2e22f

Resolves tdf#146261 - Remember size of bookmark dialog

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Xisco Faulí 2022-05-02 14:51:32 UTC
A polite ping to  Heiko Tietze:
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
Otherwise, Could you please explain what's missing?
Thanks
Comment 11 Heiko Tietze 2022-05-16 09:50:53 UTC
Variable header width reverted to previous fix column width in bug 149074.
Comment 12 Heiko Tietze 2024-01-31 14:51:55 UTC
(In reply to Heiko Tietze from comment #11)
> Variable header width reverted to previous fix column width in bug 149074.

No idea about my past me ;-(