Bug 146314 - UI: Right click a style in the style preview of tabbed bar doesn't select the underlying style first
Summary: UI: Right click a style in the style preview of tabbed bar doesn't select the...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Notebookbar-Tabbed
  Show dependency tree / graph
 
Reported: 2021-12-19 10:26 UTC by Telesto
Modified: 2024-06-01 01:29 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-12-19 10:26:31 UTC 
Description:
UI: Right click a style in the style preview of tabbed bar doesn't select the underlying style first

Steps to Reproduce:
1. Open Writer
2. Tabbed User Interface
3. Home tab
4. Right Click Heading 1 -> Edit Style

Actual Results:
Dialog for default paragraph style opens

Expected Results:
Dialog for Heading 1 opens (see sidebar)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: deea3b7471c3dab0220eca6146c225a2d47681a2
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-12-19 10:27:59 UTC 
No right click menu in
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 23762a704133051184850fc711e44bc9a112f59a
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 2 Telesto 2021-12-19 10:30:42 UTC 
@Jim
Still small improvement needed here.
Comment 3 Stéphane Guillou (stragu) 2021-12-19 13:32:35 UTC 
Reproduced with:

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 06ac18e6302d666c363740644a7976e8c22d1113
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and:

Version: 7.3.0.0.beta1 / LibreOffice Community
Build ID: 436f14c25ec1847646b953cf13d0db4f7ca3be57
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and

Version: 7.2.4.1 / LibreOffice Community
Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 4 Stéphane Guillou (stragu) 2024-05-21 02:11:38 UTC 
Used to work when it was implemented by Jim in f16ab02c98b8d3483f6b6a7f8f10a4e41b545464.

Bibisected with linux-64-7.2 to first bad build [7802521f69c71eee6a11517ecb0d6c8d8e57a015] which is:

commit fd9b52502de6044a2249ff81407ac579a35ad3a1
author	Szymon Kłos 	Tue Feb 02 16:12:55 2021 +0100
committer	Szymon Kłos 	Thu Feb 11 18:50:48 2021 +0100
tdf#139429 Convert Style previews widget to IconView
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110408

Szymon, can you please have a look?