Bug 146375 - Cannot rename user-defined categories in template manager
Summary: Cannot rename user-defined categories in template manager
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.0.2 target:7.2.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Template-Manager
  Show dependency treegraph
 
Reported: 2021-12-22 13:49 UTC by sdc.blanco
Modified: 2023-11-01 05:28 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2021-12-22 13:49:35 UTC
1. Open template manager (Ctrl+Shift+N).
2. Add new category  (Manage - New Category - (popup box) Enter new category name - Ok)
3. Rename the new category  (Manage - Rename category - (popup box) Enter new category name).

Actual/expected result:  Category is renamed.

4.  Close and reopen Template Manager

Actual result:  Category name is reverted.

Expected result:  Renamed category remains renamed.

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e63fe68fb1d0915b64fdf63f7fa6eed866fa3a0d
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-US (en_DK); UI: en-US
Calc: CL
Comment 1 zcrhonek 2021-12-31 12:04:43 UTC
Confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: c13db6e792cc347ffff4585f23866f195651f21f
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

but not in Version: 6.1.0.0.alpha1+
Comment 2 zcrhonek 2021-12-31 12:22:33 UTC
This seems to have begun at the below commit.
Adding Cc: to Noel Grandin; Could you possibly take a look at this one?
Thanks
 3624a703361b108d22448bd60a97733f05e37820 is the first bad commit
commit 3624a703361b108d22448bd60a97733f05e37820
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Sat Jun 26 18:17:30 2021 +0200

    source 5eee5524754ab2ff62d45c1c70b025834d3a1d15

https://gerrit.libreoffice.org/c/core/+/117571
  tdf#135316 remove OTempFileService pessimisation
Comment 3 Commit Notification 2022-01-11 06:19:46 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dd42f133f604ee2f7e0ffbca6a8d94fb8f95dfe5

tdf#146375 Cannot rename user-defined categories in template manager

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-01-12 18:12:51 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/d1068539a1eb305ebcbb301f2f8f6fda0ab2d6ee

tdf#146375 Cannot rename user-defined categories in template manager

It will be available in 7.3.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 sdc.blanco 2022-01-13 11:32:51 UTC
Thanks Noel - I verify that category renaming works now as expected -- but still a problem if the category is not in the default path (bug 139710).

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: bb29b12a9e367d181a5d9d962d466df41e093e0c
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL
Comment 6 Xisco Faulí 2022-01-13 18:53:28 UTC
Verified in

Version: 7.3.1.0.0+ / LibreOffice Community
Build ID: 0b6ae07240e79738d88fe61676f814044cf71c7c
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

@Noel, thanks for fixing this issue!!
Comment 7 Commit Notification 2022-01-14 11:22:33 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/afa109d947c811cdce15413fdb536dc4bd90526b

tdf#146375 Cannot rename user-defined categories in template manager

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-01-14 17:55:14 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cb4e90c05fb26f37124b5d4bcf15bd1736c05850

tdf#146375: sw: add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.