Bug 146436 - Short pause when going to next line with record track changes hidden (not shown)
Summary: Short pause when going to next line with record track changes hidden (not shown)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: haveBacktrace, implementationError, perf
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2021-12-27 15:47 UTC by Telesto
Modified: 2024-08-05 06:53 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (24.18 KB, application/vnd.oasis.opendocument.text)
2021-12-27 15:47 UTC, Telesto
Details
Perf flamegraph (325.91 KB, image/svg+xml)
2024-08-05 06:53 UTC, Buovjaga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-12-27 15:47:01 UTC
Description:
Short freeze when going to next line with record track changes hidden

Steps to Reproduce:
1. Open the attached file (slightly modified version of bug 113067)
2. Press and hold a key at the yellow line.. or start typing until at beginning of the line

Actual Results:
There will be 'a short freeze' in feedback when line of text is filled

Expected Results:
No freeze


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 9c95415de877af1430ab5b7123e11dedd0ea622c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

also in
Version: 6.2.9.0.0+ (x86)
Build ID: 5f01fe15eb2661f1f9ce12d1d99dc2a705b462ee
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

smooth in
Version: 6.1.0.0.beta1+
Build ID: da49f4aeb8d5e9a7d2cba8855d911e7cc1d2f1e2
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL
Comment 1 Telesto 2021-12-27 15:47:20 UTC
Created attachment 177157 [details]
Example file
Comment 2 Dieter 2022-01-11 07:12:58 UTC
I confirm it with

Version: 7.2.5.2 (x64) / LibreOffice Community
Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Additional informations
Can't reproduce with an empty or very small document, but could reproduce with a 68 pages document.
If changes are no recorded, freeze is in middle of the line.
Comment 3 QA Administrators 2024-05-28 03:13:47 UTC Comment hidden (obsolete)
Comment 4 Buovjaga 2024-08-04 20:04:16 UTC
Bibisecting might have been easier on a slower machine, but Windows in a VM provided just enough slowdown. The result in win32-6.2 repo is 94c1af65367dcbc7272455cf6d4940252a289b62
sw_redlinehide: make layout based Show/Hide mode the default
remove ExperimentalMode checks

I dug in the log with:
git log -S"eRedlMode = isExp" sw/source/core/edit/autofmt.cxx

It showed the check for experimental mode was added in e7283ebe7a2ba9b608a04d1efbe5504f182369a7
sw_redlinehide_4a: stop toggling ShowDelete in SwAutoFormat

That commit is the binary hash 532aaf707db00b980203e434862dfc600b4388c6 in win32-6.3 repo.

I'll call this an implementation error.
Comment 5 Buovjaga 2024-08-05 06:53:05 UTC
Created attachment 195704 [details]
Perf flamegraph

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5850b22e04a7a055e5b4c6b23a1d32d74270506d
CPU threads: 8; OS: Linux 6.10; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: CL threaded