Bug 146485 - [PATCH] Update for French hyphenation rules
Summary: [PATCH] Update for French hyphenation rules
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-12-30 13:37 UTC by Olivier R.
Modified: 2022-01-03 17:44 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:

Attachments
Patch to update the French hyphenation rules (34.91 KB, patch)
2021-12-30 13:38 UTC, Olivier R. 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier R. 2021-12-30 13:37:40 UTC 
Description:
The new rules file for French hyphenation have been made by Marc Lodewijck, who already created the previous version.
I have tested the new rules file and everything seems to work fine.

Thanks.


Steps to Reproduce:
Not a bug. An enhancement.

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Olivier R. 2021-12-30 13:38:49 UTC 
Created attachment 177209 [details]
Patch to update the French hyphenation rules
Comment 2 sophie 2021-12-30 13:50:13 UTC 
Thanks Olivier for your patch and your work :)
Comment 3 Julien Nabet 2021-12-30 17:42:22 UTC 
I don't know if license of the patch (it seems GNU LGPL just reading the patch) is fully compatible with the requirements indicated in https://wiki.documentfoundation.org/Development/GetInvolved#License_statement:
MPLv2/LGPLv3+ dual license

(I'm not a lawyer expert but just would like potential pbs :-))

Michael: any idea?
Comment 4 Olivier R. 2021-12-30 18:28:09 UTC 
If you dig into the dictionaries repository, you’ll find other resources that are licensed only with GPL or LGPL.

DE
- dictionary: GPL
- hyphenation: LGPL
- thesaurus: LGPL

ES
- thesaurus: LGPL

IT
- dictionary: GPL
- hyphenation: LGPL
- thesaurus: GPL

HU
- thesaurus: GPL

RU
- thesaurus: LGPL

That’s probably why the repository for external resources is separate from the code repository.
Comment 5 Michael Meeks 2022-01-03 16:54:07 UTC 
Thanks for checking Julien - as Olivier said - dictionaries are something of a special-case license wise: much as it would be a good idea to re-base on the LaTeX MIT base here and have a clearer picture.

So no objections - as long as you're happy linguistically =)

Thanks Olivier !
Comment 6 Julien Nabet 2022-01-03 17:29:13 UTC 
(In reply to Michael Meeks from comment #5)
> Thanks for checking Julien - as Olivier said - dictionaries are something of
> a special-case license wise: much as it would be a good idea to re-base on
> the LaTeX MIT base here and have a clearer picture.
> 
> So no objections - as long as you're happy linguistically =)
> 
> Thanks Olivier !

No pb!
Andras: thought you might be interested in this one as dictionaries expert.

(I would have submitted the patch if I had remembered the mechanism of gerrit submitting for a submodule)
Comment 7 Collabora Productivity Ltd 2022-01-03 17:44:41 UTC 
https://gerrit.libreoffice.org/c/dictionaries/+/127910
Thanks.