Bug 146551 - Menu checkmarks and bullets are misaligned horizontally compared to icons in the same menus on Windows
Summary: Menu checkmarks and bullets are misaligned horizontally compared to icons in ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-03 16:02 UTC by Mike Kaganski
Modified: 2022-03-09 14:17 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
A screenshot with problematic alignment (22.53 KB, image/png)
2022-01-03 16:02 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-01-03 16:02:37 UTC
Created attachment 177289 [details]
A screenshot with problematic alignment

The screenshot taken on Version: 7.3.0.1 (x64) / LibreOffice Community
Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

shows a menu with both checkmarks, and custom icons; and the red lines show how these two kinds of visual elements are misaligned horizontally: both the checkmark's background rectangle, and the mark itself, are centered in the menu's icon area (the background occupies the whole area), while the icons are shifted to the text.

The checkmarks/bullets and icons should be aligned in the menu.
Comment 1 Commit Notification 2022-01-04 07:45:32 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1be170d0629cf761f0ee4173007a3c021966546e

tdf#146551: improve native checkmark and bullet drawing on Windows

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2022-03-09 09:51:11 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4e76c3ab5f029a4a4bb1042ad225edc1116e4b44

Related: tdf#146551 Make image and native checkmark same size in menu

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.