Bug 146602 - i18n: add language Pennsylvania Dutch {pdc-US}
Summary: i18n: add language Pennsylvania Dutch {pdc-US}
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Eike Rathke
URL: https://www.padutchdictionary.com
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-06 02:10 UTC by info
Modified: 2022-01-27 17:21 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments
locale data file (26.44 KB, application/xml)
2022-01-06 02:10 UTC, info
Details
locale data file (revised) (26.44 KB, text/xml)
2022-01-08 04:18 UTC, info
Details
Simplified by reference inheritance locale data pdc_US.xml (6.36 KB, text/xml)
2022-01-26 15:52 UTC, Eike Rathke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description info 2022-01-06 02:10:00 UTC
Created attachment 177340 [details]
locale data file

Hello friends,

I would like to request that a new locale/language be added with the following particulars:

Language (Country): Pennsylvania German (United States)
ISO 639-3 language code: pdc
ISO 3166 country code: US
MS language identifier: none

Attached is the locale data file.  It is based on the example given at:
https://cgit.freedesktop.org/libreoffice/core/plain/i18npool/source/localedata/data/en_US.xml

and inherits the following elements:
<LC_CTYPE>
<LC_FORMAT>
<LC_FORMAT_1>
<LC_COLLATION>
<LC_SEARCH>
<LC_INDEX>
<LC_TRANSLITERATION>
<LC_NumberingLevel>
<LC_OutLineNumberingLevel>

Thank you!
Peter
Comment 1 info 2022-01-08 04:18:59 UTC
Created attachment 177386 [details]
locale data file (revised)

Replacing the previously attached locale data file.
Comment 2 info 2022-01-08 04:19:18 UTC
Hello,

I have been asked to update the language to Pennsylvania Dutch.  So as to avoid confusion, here are the particulars:

Language (Country): Pennsylvania Dutch (United States)
ISO 639-3 language code: pdc
ISO 3166 country code: US
MS language identifier: none

Attached is a revised locale data file.  It is based on the example given at:
https://cgit.freedesktop.org/libreoffice/core/plain/i18npool/source/localedata/data/en_US.xml

and inherits the following elements:
<LC_CTYPE>
<LC_FORMAT>
<LC_FORMAT_1>
<LC_COLLATION>
<LC_SEARCH>
<LC_INDEX>
<LC_TRANSLITERATION>
<LC_NumberingLevel>
<LC_OutLineNumberingLevel>

Thank you!
Peter
Comment 3 Eike Rathke 2022-01-26 14:41:07 UTC
Regarding your locale data contribution:

Apparently we don't have your license statement on file, could you
please send us a blanket statement that you contribute all your past and
future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev
mailing list libreoffice@lists.freedesktop.org so we can link to it from
https://wiki.documentfoundation.org/Development/Developers

Something like this does nicely:

All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.

Best use Subject: <your full name> license statement

Sorry for the inconvenience and thank you for cooperating :-)
Comment 4 Eike Rathke 2022-01-26 15:52:01 UTC
Created attachment 177809 [details]
Simplified by reference inheritance locale data pdc_US.xml

As the data copied en_US.xml almost entirely except adapted calendar items' names and a few other, this can be simplified using the ref=... inheritance mechanism for most. Attached. In the original submission the Jewish calendar date formats (the LC_FORMAT_1 section) were kept but the calendar was removed, having one without the other makes no sense, so I didn't inherit the LC_FORMAT_1 section either.
Comment 5 Commit Notification 2022-01-26 16:04:19 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/083c93d406a9653922e9510509333f7ee64049fa

tdf#146602 Add Pennsylvania Dutch {pdc-US} 0x06AF to language list

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Eike Rathke 2022-01-26 20:52:49 UTC
Pending https://gerrit.libreoffice.org/c/core/+/128998 addition of locale data waiting for license statement.
Comment 7 info 2022-01-27 05:09:55 UTC
Hi Eike,

I have emailed the license statement to the dev mailing list.

Thanks!

Peter K. Zacharias

(In reply to Eike Rathke from comment #3)
> Regarding your locale data contribution:
> 
> Apparently we don't have your license statement on file, could you
> please send us a blanket statement that you contribute all your past and
> future patches under the MPLv2 and LGPLv3+ licenses? Best on the dev
> mailing list libreoffice@lists.freedesktop.org so we can link to it from
> https://wiki.documentfoundation.org/Development/Developers
> 
> Something like this does nicely:
> 
> All of my past & future contributions to LibreOffice may be
> licensed under the MPLv2/LGPLv3+ dual license.
> 
> Best use Subject: <your full name> license statement
> 
> Sorry for the inconvenience and thank you for cooperating :-)
Comment 8 Commit Notification 2022-01-27 17:20:48 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3480a1812d28c5d7e60bbec43f22af823234866a

Resolves: tdf#146602 Add Pennsylvania Dutch {pdc-US} locale data

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.