Bug 146997 - change the position when changing the coordinates of the object.
Summary: change the position when changing the coordinates of the object.
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.2.5.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-01-26 10:24 UTC by ricci
Modified: 2022-02-04 10:28 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
coordinate bug (320.39 KB, application/x-zip-compressed)
2022-01-26 10:24 UTC, ricci
Details
test file (8.47 KB, application/vnd.oasis.opendocument.graphics)
2022-01-29 14:19 UTC, raal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ricci 2022-01-26 10:24:26 UTC
Created attachment 177796 [details]
coordinate bug

1. Not possible to change the position precisely when changing the coordinates of the object.

Page size: A3
Drawing scale: 1:1280
Unit of measurement: metre

On both axis x, y it is not possible to change the object position more than 214.70 m. When I type 300 it decreases to 214.70 m.

2. When the beginning of the coordinate system is changed, after reopening the document the beginning is reset to default position.
Comment 1 raal 2022-01-29 14:14:48 UTC
Tested change value in sidebar. The problem started in linux-64-6.5. When I add 30000 cm to "position X" it changes to -11 473,92 cm.
 2f177f331957067b81d8faa3c96aefe8f9d3ef3c is the first bad commit
commit 2f177f331957067b81d8faa3c96aefe8f9d3ef3c
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Mon Dec 30 11:39:16 2019 +0100

    source c85fcc6e1994eb8e079aaca85066ab4d67149c15

https://git.libreoffice.org/core/+/c85fcc6e1994eb8e079aaca85066ab4d67149c15
	weld PosSizePropertyPanel

in bibisect repo linux-64-7.1 it changed. When I add 30000 cm it changes to 21 474,56 cm.   71d1fc8159200d491e057885b05e4def966d496f is the first bad commit
commit 71d1fc8159200d491e057885b05e4def966d496f
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Aug 14 19:37:00 2020 +0200

    source 97e49876086bbdcb58ae0c22d9145c453f239468

https://git.libreoffice.org/core/+/97e49876086bbdcb58ae0c22d9145c453f239468
	tdf#135526 ranges overflowing to become negative

Adding CC to: Caolán McNamara

@ricci: create please new bug for nr. 2. Please add an information how to change beginning of the coordinate system.
Comment 2 raal 2022-01-29 14:19:23 UTC
Created attachment 177903 [details]
test file
Comment 3 Commit Notification 2022-02-03 09:10:13 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a33b4df9201d5d04b923b8f67d50eec0f11fd2b

Related: tdf#146997 no value-changed emitted for FormattedSpinButton

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 ricci 2022-02-03 20:04:13 UTC
(In reply to raal from comment #1)
> Tested change value in sidebar. The problem started in linux-64-6.5. When I
> add 30000 cm to "position X" it changes to -11 473,92 cm.
> 
> 2f177f331957067b81d8faa3c96aefe8f9d3ef3c is the first bad commit
> commit 2f177f331957067b81d8faa3c96aefe8f9d3ef3c
> Author: Jenkins Build User <tdf@pollux.tdf>
> Date:   Mon Dec 30 11:39:16 2019 +0100
> 
>     source c85fcc6e1994eb8e079aaca85066ab4d67149c15
> 
> https://git.libreoffice.org/core/+/c85fcc6e1994eb8e079aaca85066ab4d67149c15
> 	weld PosSizePropertyPanel
> 
> in bibisect repo linux-64-7.1 it changed. When I add 30000 cm it changes to
> 21 474,56 cm.  
> 71d1fc8159200d491e057885b05e4def966d496f is the first bad commit
> commit 71d1fc8159200d491e057885b05e4def966d496f
> Author: Jenkins Build User <tdf@pollux.tdf>
> Date:   Fri Aug 14 19:37:00 2020 +0200
> 
>     source 97e49876086bbdcb58ae0c22d9145c453f239468
> 
> https://git.libreoffice.org/core/+/97e49876086bbdcb58ae0c22d9145c453f239468
> 	tdf#135526 ranges overflowing to become negative
> 
> Adding CC to: Caolán McNamara
> 
> @ricci: create please new bug for nr. 2. Please add an information how to
> change beginning of the coordinate system.

Thanks, 

I'll open the new ticket for bug nr. 2.

br,
Comment 5 Commit Notification 2022-02-04 10:21:45 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ea771e85b2302829394df545bb82c02bff2750c2

Resolves: tdf#146997 use sal_Int64 instead of sal_Int32 for spinbutton values

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2022-02-04 10:22:24 UTC
done in trunk, will revisit in a while if we should backport after its had time to settle