Bug 147032 - hazardous animation objects selected
Summary: hazardous animation objects selected
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.4.0 target:7.2.6 target:7.3.1
Keywords: bibisected, bisected, regression
: 147706 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-01-28 09:11 UTC by Pierre C
Modified: 2023-11-19 21:28 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Test file (10.59 KB, application/vnd.oasis.opendocument.presentation)
2022-01-28 09:11 UTC, Pierre C
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre C 2022-01-28 09:11:29 UTC
Created attachment 177863 [details]
Test file

When you add an animation, sometimes, multiples objects are selected.

This often happens,and is very annoying.

I don't know if the behaviour I submit is the only bug, but surely it is a part of it.

just open test file. Go to animation and select "4" object and add it to animations. It appears selected at the end of the animation's list
All this is fine

- Select second object in the animation list
- unselect it by clicking anywhere in the slide
- select object 3 for example (any of the object except object 2
- Click "add"
So to objects are selected the first you selected and unselected, and the one you add. this should not be the behaviour (IMHO)

LO 7.2 windows 10

it works fine with AOO, so it's a regression from ???
Comment 1 raal 2022-01-28 19:27:21 UTC
Confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 2f4f4cbeb8e50081d607b86b0475b93971c40ab8
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: tr-TR (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

but not in Version: 6.1.0.0.alpha0+
Build ID: e1b247a843c5eb850fe0079819239d9883412d38
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3; 
Locale: cs-CZ (cs_CZ.UTF-8); Calc: group
Comment 2 raal 2022-01-28 19:38:09 UTC
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara; Could you possibly take a look at this one?
Thanks
 9ff12c78a14275c103335bce76a0ddee5680ef49 is the first bad commit
commit 9ff12c78a14275c103335bce76a0ddee5680ef49
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Mon Apr 6 21:44:38 2020 +0200

    source 21e8ce9ab9a522d25e95773af59b7ccccaee4e54

https://git.libreoffice.org/core/+/21e8ce9ab9a522d25e95773af59b7ccccaee4e54
  weld custom animation panel
Comment 3 Caolán McNamara 2022-01-31 17:31:33 UTC
seems to be an unwanted interaction between wanting to set the cursor position of the last effect autoselecting it and then the new one is added to the selection
Comment 4 Commit Notification 2022-02-01 08:37:38 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4c11673e78813dedb2089dd7e1a76a12da26cc8b

tdf#147032 unselect anything set_cursor selected as its side-effect

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2022-02-01 08:50:44 UTC
seems good in trunk, backport to 7-3 and 7-2 in gerrit
Comment 6 Commit Notification 2022-02-01 10:14:46 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/b8b4dd7e909a46fe1777a64124d5fa0187a1ad70

tdf#147032 unselect anything set_cursor selected as its side-effect

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-02-07 16:06:08 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/a761a31d019732ee94386fb643b6486d029695c5

tdf#147032 unselect anything set_cursor selected as its side-effect

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Stéphane Guillou (stragu) 2023-11-19 21:28:02 UTC
*** Bug 147706 has been marked as a duplicate of this bug. ***