Bug 147086 - Password in .xlsx creates readonly sheet
Summary: Password in .xlsx creates readonly sheet
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.0.2 rc
Hardware: All All
: medium normal
Assignee: Tünde Tóth
URL:
Whiteboard: target:7.4.0 target:7.3.1
Keywords: bibisected, bisected, filter:xlsx, regression
: 147381 147789 (view as bug list)
Depends on:
Blocks: Password-Protected
  Show dependency treegraph
 
Reported: 2022-01-31 11:35 UTC by allmeeting
Modified: 2022-03-08 03:05 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description allmeeting 2022-01-31 11:35:19 UTC
(sorry for my english)

When I save a new xlsx sheet with password, it automatically creates a sheet with password but when I open it, it opens in read only, and when I try to unlock it  asks me for a password that I have not entered and don't exist.
Comment 1 Roman Kuznetsov 2022-01-31 14:34:37 UTC
confirm in 


Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e27a41a362bf25e12487b36f625985b35fb891e3
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL

and in 

Version: 7.3.0.2 (x64) / LibreOffice Community
Build ID: f1c9017ac60ecca268da7b1cf147b10e244b9b21
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL

but not in

Version: 7.2.0.4 (x64) / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL

so it's a regression
Comment 2 Roman Kuznetsov 2022-01-31 15:12:59 UTC
I bisected it in win64-7.3 bisect repo and I got the sha
 1b53c1dfc76f08ca7df40a0673aa50eca700d072

https://gerrit.libreoffice.org/c/core/+/123543

https://git.libreoffice.org/core/commit/1b53c1dfc76f08ca7df40a0673aa50eca700d072

Added to CC: Tünde Tóth (but I can't find his e-mail here, NISZ team please help me)

Tünde could you please look at it? Thank you
Comment 3 Timur 2022-02-13 17:06:17 UTC
*** Bug 147381 has been marked as a duplicate of this bug. ***
Comment 4 Commit Notification 2022-02-17 09:25:46 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8f7d355e7f153a940b85179f5bc54a506eeab05a

tdf#147086 OOXML export: don't save the empty editing password

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-02-17 15:30:47 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/f7e03352c18e13161effcfe08c7591d3be11b3e0

tdf#147086 OOXML export: don't save the empty editing password

It will be available in 7.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Roman Kuznetsov 2022-02-18 22:37:50 UTC
verified in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c856f9bec12d98ed49f01578ded79f16ae7be051
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

Thanks for fixing!
Comment 7 Commit Notification 2022-02-23 12:31:14 UTC
Tünde Tóth committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-1":

https://git.libreoffice.org/core/commit/3467b8b63f100e5474673727f137778fed7ccad5

tdf#147086 OOXML export: don't save the empty editing password

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Timur 2022-03-08 03:05:31 UTC
*** Bug 147789 has been marked as a duplicate of this bug. ***