Bug 147179 - Tracked row changes in Manage changes window: show table selection instead of selection the first text change
Summary: Tracked row changes in Manage changes window: show table selection instead of...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.4
Keywords:
Depends on:
Blocks: Track-Changes-Table
  Show dependency treegraph
 
Reported: 2022-02-04 11:03 UTC by NISZ LibreOffice Team
Modified: 2022-04-30 17:25 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer with a table (10.14 KB, application/vnd.oasis.opendocument.text)
2022-02-04 11:05 UTC, NISZ LibreOffice Team
Details
First screenshot (3.65 KB, image/jpeg)
2022-02-04 11:05 UTC, NISZ LibreOffice Team
Details
Second screenshot (3.62 KB, image/jpeg)
2022-02-04 11:06 UTC, NISZ LibreOffice Team
Details
test document with tracked row changes (13.36 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2022-02-11 08:49 UTC, László Németh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2022-02-04 11:03:50 UTC
Description:
Jumping over the table changes in Manage Changes dialog window doesn’t select the table change, but only its first text change.

Steps to Reproduce:
    1. Open attached file
    2. Open Manage Changes
    3. Click on one of the table changes.

Actual Results:
It only shows the change in first cell

Expected Results:
It should select the whole changed row (i.e. use table selection).


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5c138ac6a8334825ef171ac6291b66b277eb4288
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL
Comment 1 NISZ LibreOffice Team 2022-02-04 11:05:16 UTC
Created attachment 178040 [details]
Example file from Writer with a table
Comment 2 NISZ LibreOffice Team 2022-02-04 11:05:49 UTC
Created attachment 178041 [details]
First screenshot
Comment 3 NISZ LibreOffice Team 2022-02-04 11:06:12 UTC
Created attachment 178042 [details]
Second screenshot
Comment 4 Ezinne 2022-02-10 22:08:18 UTC
The description does not include any step that requires the making of changes to the file.

Please can you check/amend the description/steps?
Comment 5 László Németh 2022-02-11 08:48:26 UTC
Comment on attachment 178040 [details]
Example file from Writer with a table

Bad test document
Comment 6 László Németh 2022-02-11 08:49:51 UTC
Created attachment 178211 [details]
test document with tracked row changes
Comment 7 László Németh 2022-02-11 08:52:05 UTC
(In reply to Ezinne from comment #4)
> Please can you check/amend the description/steps?

I've replaced the bad test document. Thanks for your feedback!
Comment 8 László Németh 2022-04-08 07:58:41 UTC
The proposed fix:

https://gerrit.libreoffice.org/c/core/+/132685
Comment 9 Commit Notification 2022-04-08 10:00:55 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a21ef822f9769ded6ff834dbfa347cf0e5f913fd

tdf#147179 sw: select tracked row change in Manage Changes

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 NISZ LibreOffice Team 2022-04-27 08:21:37 UTC
Verified in:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 67d8c245daf7c6ee33e908255f2bbd0ea8d08206
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded
Comment 11 Commit Notification 2022-04-30 17:25:29 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/0844dd442e9805788ed940055c74d070e184121a

tdf#147179 sw: select tracked row change in Manage Changes

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.