Bug 147337 - Template Management dialog has no access to extensions when started from the start center
Summary: Template Management dialog has no access to extensions when started from the ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.5.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Start-Center-Accessibility
  Show dependency treegraph
 
Reported: 2022-02-10 08:46 UTC by Alex Thurgood
Modified: 2022-06-15 14:45 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screenshot of Collabora Productivity Manage Templates dialog (76.67 KB, image/png)
2022-06-15 13:36 UTC, Alex Thurgood
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Thurgood 2022-02-10 08:46:07 UTC
Description:
1) Open the StartCenter
2) Click on the dropdown menu arrow on Templates
3) Click on Manage Templates
4) Click on the Extensions button - nothing happens

Steps to Reproduce:
See above

Actual Results:
The "Extensions" button in the Template Management dialog is inactive.

Expected Results:
The button should open a link in the default configured OS browser of choice and load a URL for the Extensions page.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 21.06.15.1
Build ID: 60a66e4bf6afbf5d4221dab436bb1aca744a7ddf
CPU threads: 8; OS: Mac OS X 12.2; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded
Comment 1 Alex Thurgood 2022-02-10 08:54:17 UTC
FWIW, for comparison, the corresponding button in the StartCenter (the big Extensions button at the bottom on the left hand side) does open a link in the browser to the LO extensions website.
Comment 2 Adolfo Jayme Barrientos 2022-06-13 06:17:56 UTC
Please: Collabora bugs should be reported to a Collabora bug tracker. The Foundation’s resources should not be abused to report issues in commercial derivates.
Comment 3 Heiko Tietze 2022-06-15 08:01:53 UTC
(In reply to Alex Thurgood from comment #0)
> 3) Click on Manage Templates

The dialog has changed recently a lot for bug 138906, bug 139647, and bug 141329.

The "Manage Templates" menu has an entry to access extensions directly, which is disabled when started from the start center. Did that related to icons for bug 137922 since dispatchCommand() is not working in this context (it needs more experienced developer to fix). So maybe the templates command is just hidden (and the same is true for master builds, so NOB is wrong here).

The good news is that Manage Templates has this item when started from Writer. My take: not worth the effort and WF/NAB.
Comment 4 Heiko Tietze 2022-06-15 08:03:37 UTC
Sorry for overwriting the status. But NEW? Anyway, forgot to mention that everyone can REOPEN a ticket for second opinions. You are welcome to do so, Alex.
Comment 5 Alex Thurgood 2022-06-15 13:36:16 UTC
@Heiko: this is a bug specific to Collabora Productivity on macOS.

Indeed, I don't see any such dropdown entry in the StartCenter of 

Version: 7.2.5.2 / LibreOffice Community (supplied via Collabora/AppStore)
Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5
CPU threads: 8; OS: Mac OS X 12.4; UI render: default; VCL: osx
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded

or

current production release of LibreOffice (TDF)

Enclosed screenshot of Collabora Productivity

The question is then what to do with Collabora Productivity specific bug reports.
Comment 6 Alex Thurgood 2022-06-15 13:36:56 UTC
Created attachment 180787 [details]
Screenshot of Collabora Productivity Manage Templates dialog
Comment 7 Heiko Tietze 2022-06-15 14:10:22 UTC
(In reply to Alex Thurgood from comment #5)
> The question is then what to do with Collabora Productivity specific bug
> reports.

Since changes will be applied downstream it has no Collabora specific issues. But do we really need to change this? Sounds like a lot of effort for not much benefit. Stephan, you commented my patch back then. What do you think regarding the effort?
Comment 8 Stephan Bergmann 2022-06-15 14:22:45 UTC
(In reply to Heiko Tietze from comment #7)
> Stephan, you commented my patch back then. What do you
> think regarding the effort?

Heiko, are you referring to some Gerrit comment of mine?  If yes, please provide a link to it here.
Comment 9 Heiko Tietze 2022-06-15 14:26:58 UTC
(In reply to Stephan Bergmann from comment #8)
> please provide a link to it here.

https://gerrit.libreoffice.org/c/core/+/105292
Comment 10 Stephan Bergmann 2022-06-15 14:36:24 UTC
(In reply to Heiko Tietze from comment #9)
> (In reply to Stephan Bergmann from comment #8)
> > please provide a link to it here.
> 
> https://gerrit.libreoffice.org/c/core/+/105292

Ah, the unresolved comment thread at <https://gerrit.libreoffice.org/c/core/+/105292/2//COMMIT_MSG#9> "Template Management dialog has no access to extensions when started from the start center", including my:  "I think the issue is that for some reason dispatching that .uno:AdditionsDialog does not work in the Start Center.  So I would assume we fix that, instead of adding a dubious band aid of disabling buttons that happen to not work due to an unfixed error elsewhere."

Yes, I still think that the poor band aid <https://git.libreoffice.org/core/+/63b0565ad137e5d81932f1fabba732ba40f6cb70%5E%21> "Resolves tdf#137922 - Tight extension in start center" should be reverted and bug 137922 be fixed properly (whatever effort that would take, code-wise).