Bug 147453 - EDITING: Disable "Delete Selected Table/Rows" on already deleted rows
Summary: EDITING: Disable "Delete Selected Table/Rows" on already deleted rows
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.4
Keywords:
Depends on:
Blocks: Track-Changes-Table
  Show dependency treegraph
 
Reported: 2022-02-16 08:37 UTC by NISZ LibreOffice Team
Modified: 2022-04-27 06:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer with a table (10.29 KB, application/vnd.oasis.opendocument.text)
2022-02-16 08:41 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2022-02-16 08:37:09 UTC Comment hidden (obsolete)
Comment 1 NISZ LibreOffice Team 2022-02-16 08:41:29 UTC
Created attachment 178300 [details]
Example file from Writer with a table
Comment 2 László Németh 2022-02-16 11:45:21 UTC
Steps to Reproduce:

1. Open attached file

2. Click on "Delete Selected Rows" icon to delete the first table row with change tracking (Record Changes in enabled in the file).

Actual Results:

"Delete Selected Rows" icon and menu item is still enabled.

Expected Results:

"Delete Selected Rows" icon and menu item is disabled.
Comment 3 Commit Notification 2022-04-22 17:25:23 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0204c00f241313e1d292b4c3ea117d42af7dec69

tdf#147453 sw: disable Delete Table functions on tracked deletions

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-04-26 07:29:29 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/ed7243ec27d8cdc883ccc5f7eaa732155c4a2096

tdf#147453 sw: disable Delete Table functions on tracked deletions

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 NISZ LibreOffice Team 2022-04-27 06:34:44 UTC
Verified in:

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 67d8c245daf7c6ee33e908255f2bbd0ea8d08206
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-GB
Calc: CL