Bug 147603 - Missing star icons in Extension dialog
Summary: Missing star icons in Extension dialog
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.3.2 target:7.2.7 target:7.4.0
Keywords:
Depends on:
Blocks: Icon-Theme-Breeze Icon-Theme-Colibre Icon-Theme-Sifr
  Show dependency treegraph
 
Reported: 2022-02-22 22:11 UTC by Gabor Kelemen (allotropia)
Modified: 2022-02-23 06:53 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screenshot of the missing icons with Colibre theme (149.85 KB, image/png)
2022-02-22 22:11 UTC, Gabor Kelemen (allotropia)
Details
Screenshot of the missing icons with Colibre theme on Windows (89.41 KB, image/png)
2022-02-22 22:12 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2022-02-22 22:11:03 UTC
Created attachment 178463 [details]
Screenshot of the missing icons with Colibre theme

When the Extensions dialog is opened, some icon themes are missing the star icons.
With GTK3 vclplug this is visualized as red "no icon" placeholders, with other vclplugs it's just an empty grey area.

Affected icon themes: Breeze, Breeze (SVG + dark), Breeze (SVG), Breeze (dark), Colibre, Colibre (SVG), Sifr, Sifr (SVG + dark), Sifr (SVG), Sifr (dark).

Elementary, Karasa Jaga and Sukapura + their SVG variations are displaying correct star icons. 

To reproduce it:
1, Open Options -> View
2, Next to the icon theme dropdown press the "Add more icon themes" button
3, In the "Extensions: Icons" dialog the Voting: line is empty or has the red placeholder icons.
4, Select another icon theme from the Theme dropdown, press Apply and reopen the  "Extensions: Icons" dialog.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 1c0aa970650ffc7c749e0b5ea655ebb2d137c8ae
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2022-02-22 22:12:30 UTC
Created attachment 178464 [details]
Screenshot of the missing icons with Colibre theme on Windows
Comment 2 Rizal Muttaqin 2022-02-22 22:35:58 UTC
Confirmed

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: c993d9e7538ffad8b31b26774d7062ee85572e48
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: en-US
Calc: threaded

Heiko, could you please tell me which icon file is this?
Comment 3 Commit Notification 2022-02-23 00:58:16 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/9e3b64e9bf3b031d19df805cfe44f672f55c0eea

Sifr: tdf#147603 Star icons in Extension dialog

It will be available in 7.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2022-02-23 00:59:28 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/2da83bb0a10d78b4759ec27e6875cfc8244241dd

Sifr: tdf#147603 Star icons in Extension dialog

It will be available in 7.2.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-02-23 01:31:44 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/79cc43585f93c000edaf56f3754e5be577ce75ca

Sifr: tdf#147603 Star icons in Extension dialog

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-02-23 01:40:54 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3c01c93ac364f7d3965c163916da03effcf99670

Colibre: tdf#147603 Star icons in Extension dialog

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-02-23 01:59:06 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/b43ac6df27e9f255324be37abf45884c7e5693a6

Colibre: tdf#147603 Star icons in Extension dialog

It will be available in 7.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-02-23 02:03:15 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/96b6a90b6a778f01937b68dd17cdb622744acec3

Colibre: tdf#147603, tdf#147150

It will be available in 7.2.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-02-23 02:04:30 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1b32cac107141ce8f3c04cb797d6e82dc0f54cf3

Breeze: tdf#147603 Star icons in Extension dialog

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2022-02-23 02:06:38 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/11841378b7c2e5f6b0c5e2493e6a94b1f48d5dd5

Breeze: tdf#147603 Star icons in Extension dialog

It will be available in 7.3.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-02-23 02:06:46 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/15c710946db859f08a02568d7a190a8c9c5beabc

Breeze: tdf#147603 Star icons in Extension dialog

It will be available in 7.2.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Heiko Tietze 2022-02-23 06:53:28 UTC
JFI: Voting is not yet implemented, the numbers are arbitrary. But thanks for adding the star icons!