Bug 147746 - Navigator: Makes comments that are marked resolved sensitive to resolved comments show state
Summary: Navigator: Makes comments that are marked resolved sensitive to resolved comm...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Navigator Writer-Comments
  Show dependency tree / graph
 
Reported: 2022-03-03 17:00 UTC by Xisco Faulí
Modified: 2023-11-12 18:54 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-03-03 17:00:05 UTC 
This issue is based on https://bugs.documentfoundation.org/show_bug.cgi?id=147565#c1

1. Open attachment 178430 [details] from bug 147565
2. Uncheck View -> Resolved comments
3. Sidebar -> Navigator -> Notice 2 entry's (expected only the visible comments)
Comment 1 Jim Raykowski 2022-03-12 00:11:34 UTC 
Originally I thought greying out comment members in the Navigator should be based on comment edit window visibility. I've changed thoughts to only greying out comment members that have their anchor field not visible in the document, for example, when in a hidden section or folded outline content. A patch to realize this behavior is here: https://gerrit.libreoffice.org/c/core/+/130471

Standing by for input before marking this one as invalid or wontfix.
Comment 2 Jim Raykowski 2023-11-12 17:20:06 UTC 
Removing myself from assignee and setting to RESOLVED INVALID? since comment visibility state in the Navigator has been addressed by the patch given in the link in the above comment.
Comment 3 Jim Raykowski 2023-11-12 18:54:20 UTC 
After reading the Status help, RESOLVED INVALID isn't correct. RESOLVED WORKSFORME seems a better fit to me.