Bug 148018 - Undo of deleting a row in large sheet takes 15 seconds (deleting 7 seconds). With track changes it takes 3,5 second for both actions
Summary: Undo of deleting a row in large sheet takes 15 seconds (deleting 7 seconds). ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: perf
Depends on:
Blocks: Cell-Management Calc-Track-Changes
  Show dependency tree / graph
 
Reported: 2022-03-15 19:39 UTC by Telesto
Modified: 2023-07-15 04:21 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (zip compressed) (9.97 MB, application/x-zip-compressed)
2022-03-15 19:40 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2022-03-15 19:39:23 UTC 
Description:
Undo of deleting a row in large sheet takes 15 seconds (deleting 7 seconds). With track changes it takes 3,5 second for both actions

Steps to Reproduce:
1. Open the attached file
2. Delete the first sheet
3. Press undo (take measure of the time)
4. Enable track changes
5. Delete a row
6. Edit -> Manage -> reject change -> 3 seconds
8. Disable track changes
9. Delete the first sheet (11 seconds
10. Undo (20 seconds)


Actual Results:
15 seconds

Expected Results:
If possible something like track changes behaviour


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ccc4c123f5e78e0204d11abeab2d1a74278ca3e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL Jumbo
Comment 1 Telesto 2022-03-15 19:40:36 UTC 
Created attachment 178903 [details]
Example file (zip compressed)
Comment 2 Telesto 2022-03-15 20:09:03 UTC 
Another case is deleting all Columns (A to L) and pressing UNDO

The performance is bad with track changes & reject changes.. I waited 180 seconds
Comment 3 Timur 2022-03-17 13:50:32 UTC 
That Xlsx is LO saved, so why? 
When you take a file and modify, you should write the bug it comes from.
This one is from bug 131894 which had a fix that you didn't test.
Comment 4 Buovjaga 2022-12-20 11:59:59 UTC 
(In reply to Telesto from comment #0)
> Description:
> Undo of deleting a row in large sheet takes 15 seconds (deleting 7 seconds).
> With track changes it takes 3,5 second for both actions
> 
> Steps to Reproduce:
> 1. Open the attached file
> 2. Delete the first sheet

There is only one sheet. Is the attachment the correct one?
Comment 5 QA Administrators 2023-06-19 03:13:19 UTC Comment hidden (obsolete)
Comment 6 ady 2023-06-19 09:54:16 UTC 
(In reply to Buovjaga from comment #4)
> There is only one sheet. Is the attachment the correct one?

Comment 2 in this bug 148018 has attachment 178903 [details], which includes an xlsx file containing 2 worksheets.

I have not checked the origin of this file (as hinted by comment 3).

Anyway, some of the actions described in comment 0 seem slow to me too, although I am not sure I am able to notice the speed/time differences presented in each step. I'll leave that for others to evaluate / reproduce more consistently.

Whether the behavior is expected or not, IDK. Whether there is some problem with the specific file in attachment 178903 [details], I have not checked.

I'm re-setting this report from NEEDINFO to NEW, considering that the question that originally triggered the NEEDINFO status (in comment 4) is inadequate / irrelevant for attachment 178903 [details].