This is a continuation of bug 146851 When attachment 177662 [details] is opened, there should be a page break before the " Schedule 2 Particulars of the Company [and the Subsidiaries]" part around page 24. 1, Open attachment 177662 [details] 2, Note the layout of the "Schedule 2 Particulars of the Company" text: in Word there is a column break before it, working as a page break, in Writer it is on the previous page of "Schedule 1 Particulars of the Investors and the Founders" Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: cfd82e7a2cc2b45b738eb0efa0827196d2de61a4 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: hu-HU Calc: threaded Started to look like this in 4.4, in range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=27b1ddff407df7bbabf51096147cf58372ad861c..af748c7fff9e57a5b95bdc569456cc0da93a1f90 of which this commit stands out as suspicious: https://cgit.freedesktop.org/libreoffice/core/commit/?id=382bab9412b87f82da82276332496eb28b28d4f3 author Miklos Vajna <vmiklos@collabora.co.uk> 2014-10-20 14:43:42 +0200 committer Miklos Vajna <vmiklos@collabora.co.uk> 2014-10-20 15:23:50 +0200 commit 382bab9412b87f82da82276332496eb28b28d4f3 (patch) DOCX import: fix <w:pageBreakBefore> wrt. inherited styles Before the commit range there was a whole empty page in place of the column break, so it was not good either.
Created attachment 178944 [details] The example file in Word and Writer master
I confirm it with Version: 7.3.2.2 (x64) / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: zh-CN (de_DE); UI: en-GB Calc: CL
Dear Gabor Kelemen (allotropia), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Created attachment 202385 [details] Subscription Agreement_minimized.docx: minimal reproducer <w:p w14:paraId="571C18F7" > <w:pPr> <w:pStyle w:val="Schedule-1Title"/> # style contains a pageBreakBefore <w:pageBreakBefore w:val="0"/> # turns off the style's page break </w:pPr> <w:r w:rsidRPr="007C0C28"> <w:br w:type="column"/> # column break </w:r> <w:r w:rsidRPr="007C0C28"> \ <w:br/> # line break </w:r> So the column break gets added onto a line break (which is a numbered entry) via the CONTEXT_CHARACTER. Everything looks fine from a writerfilter aspect - UNO applies the column break to the paragraph property. Then the end of the paragraph rolls around, and the paragraph direct formatting CONTEXT_PARAGRAPH "BreakType" applies its value BreakType::BreakType_NONE. Solved by judiciously Inserting into the paragraph properties instead of the character properties. (Since there is no splitting of paragraphs in this code, it affects the entire paragraph and not only the "runs" that follow this w:br run.)
Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bc511e9b7f33ff2b5e2b5e16debc550af73c3ada tdf#148057 writerfilter: overwrite BreakType::None It will be available in 26.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.