Bug 148235 - No longer possible to switch XForm to design mode from "Form Design" toolbar
Summary: No longer possible to switch XForm to design mode from "Form Design" toolbar
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:7.4.0 target:7.3.3
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-28 12:18 UTC by Michael Weghorn
Modified: 2022-03-29 04:16 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
sample form (12.59 KB, application/vnd.oasis.opendocument.text)
2022-03-28 12:18 UTC, Michael Weghorn
Details
Screenshot showing the toolbar item + dialog when trying to edit text (109.54 KB, image/png)
2022-03-28 12:19 UTC, Michael Weghorn
Details
Screenshot with additional annotation for Form Controls toolbar (157.27 KB, image/png)
2022-03-28 12:35 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2022-03-28 12:18:10 UTC
Created attachment 179165 [details]
sample form

In current LibreOffice versions, it's no longer possible to switch to design mode for an XForm document using the standard "Form Design" toolbar. Switching to design mode is e.g. necessary in order to edit the text in the document.

Steps to reproduce:

1) open attached sample document "sample_form.odt"
2) make sure the "Form Design" toolbar is enabled ("View" -> "Toolbar" -> "Form Design")
3) try to enable design mode using the "Design Mode" item in the Form Design toolbar at the bottom
4) try to edit the text at the top, e.g. by typing something after the first sentence.

Result: A dialog shows up: "Write protected content cannot be changed. No modifications will be accepted."

Expected result: Editing should be possible after switching to design mode.

Note: This still worked when using the "Design Mode on/Off" button in at least LibreOffice 6.1


Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 2816f498505bab01bc0f17ef0962ece663c607c9
CPU threads: 12; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 1 Michael Weghorn 2022-03-28 12:19:49 UTC
Created attachment 179166 [details]
Screenshot showing the toolbar item + dialog when trying to edit text

Self-confirming according to https://wiki.documentfoundation.org/QA/Guidelines_for_public_and_private_sector_deployments , since this was originally reported for a LibreOffice-6.4-based deployment by another user within our organization.
Comment 2 Michael Weghorn 2022-03-28 12:35:55 UTC
Created attachment 179167 [details]
Screenshot with additional annotation for Form Controls toolbar
Comment 3 Michael Weghorn 2022-03-28 12:39:17 UTC
Attachment 179166 [details] shows that the "Design Mode" entry currently used is the same as the one in the "Form Controls" toolbar, which is different from what it used to be before

commit 45b6f096e7ae86d0692ecdfd5b7069622d8a6efa
Author: andreas kainz <kainz.a@gmail.com>
Date:   Sun Oct 28 17:02:34 2018 +0100

    sw toolbars sync context toolbars between different apps
    
    Change-Id: Ib70cbcb392391c732f9d15a26722cf0dbdb8a56f
    Reviewed-on: https://gerrit.libreoffice.org/62477
    Tested-by: Jenkins
    Reviewed-by: andreas_kainz <kainz.a@gmail.com>


My suggestion would be to restore the previous toolbar item for the "Form Design" toolbar, since toggling design mode for the form *controls* is already possible in the "Form Controls" toolbar.
Suggested change: https://gerrit.libreoffice.org/c/core/+/132207

@Andreas: What do you think?
Comment 4 Michael Weghorn 2022-03-28 12:45:40 UTC
(In reply to Michael Weghorn from comment #3)
> Attachment 179166 [details] shows that the "Design Mode" entry currently
> used is the same as the one in the "Form Controls" toolbar, [...]

Sorry, that should be "Attachment 179167 [details] shows..." (which is attachment 179166 [details] with additional annotations)
Comment 5 Commit Notification 2022-03-28 14:39:29 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4f9bf4201bb706cd19142f0805cfc4c859186cd4

tdf#148235 Restore toolbar item to switch XForm to design mode

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Weghorn 2022-03-28 14:51:02 UTC
(In reply to Michael Weghorn from comment #3)
> @Andreas: What do you think?

Thanks a lot for your Gerrit review!
Comment 7 Commit Notification 2022-03-29 04:16:53 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/e42219cb3664b3727a6b399153d7891108c01f0c

tdf#148235 Restore toolbar item to switch XForm to design mode

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.