Bug 148240 - Make Outline-Folding non-experimental
Summary: Make Outline-Folding non-experimental
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.1.3 release
Hardware: All All
: medium enhancement
Assignee: Julien Nabet
URL:
Whiteboard: target:7.5.0 target:7.4.0
Keywords:
Depends on: 142447
Blocks: Writer-Outline-Folding
  Show dependency treegraph
 
Reported: 2022-03-28 18:15 UTC by Gerry
Modified: 2023-01-05 14:12 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gerry 2022-03-28 18:15:55 UTC
Description:
Code/outline folding is such a fantastic feature. This enhancement request asks to enable the currently experimental feature "Outline Folding" by default and make it non-experimental.

I open this new bug report (enhancement) as suggested by Dieter in bug 142447 comment 25.

Actual Results:
 

Expected Results:
 


Reproducible: Always


User Profile Reset: No



Additional Info:
Comment 1 Julien Nabet 2022-03-28 19:14:01 UTC
Here's the patch waiting for review (master branch):
https://gerrit.libreoffice.org/c/core/+/132243
Comment 2 Heiko Tietze 2022-03-29 08:14:58 UTC
+1
Comment 3 Dieter 2022-03-29 08:24:39 UTC
Before it becomes non-experimental bug 142447 should be fixed.
Comment 4 Heiko Tietze 2022-03-29 08:44:58 UTC
(In reply to Dieter from comment #3)
> Before it becomes non-experimental bug 142447 should be fixed.

Jim submitted a patch and this "make it non-exp" is the last comment. Probably ready to resolve fixed.
Comment 5 Julien Nabet 2022-03-29 08:47:53 UTC
(In reply to Dieter from comment #3)
> Before it becomes non-experimental bug 142447 should be fixed.

Since it's fixed on tdf#142447, it's ok to push the patch on master branch.

For 7.2 branch it's far too late of course since the branch is almost EOL.

So the question remains only for 7.3 branch knowing that 7.3.2 will be released in just some days (see https://wiki.documentfoundation.org/ReleasePlan/7.3), do we want it for 7.3.3 (if fix of tdf#142447 is cherry-picked on 7.3 of course) ?
IMHO, it doesn't worth it and would allow to fix some potential remaining bugs without needing to cherry-pick.
Comment 6 Xisco Faulí 2022-03-29 09:35:23 UTC
I think it's the right time to do it. Later on, we can always revert it if needed
Comment 7 Commit Notification 2022-03-29 15:40:18 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2525bab2fcca179263a4b3496bb929df61d0e2bf

tdf#148240: Make Outline-Folding non-experimental

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Dieter 2022-04-01 06:33:12 UTC
VERIFIED with

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 040b3198fde3385e19e7380fdcabae84a0abac9d
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Julien, thanks for fixing it!

Request for update help page: bug 148302
Comment 9 Julien Nabet 2022-04-01 06:44:07 UTC
(In reply to Dieter from comment #8)
> ...
> Julien, thanks for fixing it!
> ...

The person to thank is above all Jim! :-)
Comment 10 Commit Notification 2022-08-06 01:50:20 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a9d225df2f8772e21435523ca20df1ece37390e4

tdf#148240 follow up: Make Outline-Folding non-experimental

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2022-08-08 11:51:41 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/f76184196f16f22a8c70d7400a3282f4ab6e4257

tdf#148240 follow up: Make Outline-Folding non-experimental

It will be available in 7.4.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-08-08 18:50:11 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-4-0":

https://git.libreoffice.org/core/commit/71ab5a7f5a76142f3ed542b09c2aa349ec16fe18

tdf#148240 follow up: Make Outline-Folding non-experimental

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2022-10-02 22:53:27 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e3a81e039d0c5d4ee8e5a00e8b3eff04b62eb72a

tdf#148240 Drop IsExperimental from Outline folding UNOs

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.