Bug 148417 - Change "X" icon in Print Preview to "X Close Preview" (like in Writer)
Summary: Change "X" icon in Print Preview to "X Close Preview" (like in Writer)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Wodsfort
URL:
Whiteboard: target:26.8.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Print-Preview
  Show dependency treegraph
 
Reported: 2022-04-06 10:25 UTC by sdc.blanco
Modified: 2026-04-24 18:33 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot of Calc and Writer print preview screens (255.17 KB, image/png)
2022-04-06 10:25 UTC, sdc.blanco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-04-06 10:25:02 UTC
Created attachment 179342 [details]
screenshot of Calc and Writer print preview screens

Attachment shows difference between "Close Print Preview" in Calc and Writer.

Proposal is to modify Calc so that it appears the same as Writer.

From bug 148381 comment 4 (Heiko)

----
No objection. 

Writer uses in sw/uiconfig/swriter/toolbar/previewobjectbar.xml

<toolbar:toolbaritem xlink:href=".uno:ClosePreview" toolbar:style="image text"/>

And Calc in sc/uiconfig/scalc/toolbar/previewbar.xml

<toolbar:toolbaritem xlink:href=".uno:ClosePreview"/>

so adding the style might do the trick.

-----

Maybe EasyHack?
Comment 1 V Stuart Foote 2022-04-06 12:43:28 UTC
+1 for consistent handling in the Print Preview TB
Comment 2 sdc.blanco 2022-04-13 22:11:08 UTC
Polite ping to check if this ticket should be registered as an EasyHack.
Comment 3 Heiko Tietze 2022-04-14 14:31:44 UTC
(In reply to sdc.blanco from comment #2)
> Polite ping to check if this ticket should be registered as an EasyHack.

Sure, it qualifies as easyhack. Code pointer in c0.
Comment 4 Commit Notification 2026-04-15 07:49:13 UTC
Wodsfort committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/065445b3e01f8b5e69ecd0e0e9acfbc79706adee

tdf#148417 Add "close preview" text to "x" icon

It will be available in 26.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2026-04-22 18:38:49 UTC Comment hidden (off-topic)
Comment 6 BogdanB 2026-04-24 18:33:53 UTC
Thanks, Wodsfort, everything is fine.

Tested with
Version: 26.8.0.0.alpha0+ (X86_64)
Build ID: 58870f1cf08f698ac05a2c48592ea824645ac2aa
CPU threads: 16; OS: Linux 6.17; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded