Bug 148417 - Change "X" icon in Print Preview to "X Close Preview" (like in Writer)
Summary: Change "X" icon in Print Preview to "X Close Preview" (like in Writer)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Print-Preview
  Show dependency tree / graph
 
Reported: 2022-04-06 10:25 UTC by sdc.blanco
Modified: 2023-07-04 11:53 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
screenshot of Calc and Writer print preview screens (255.17 KB, image/png)
2022-04-06 10:25 UTC, sdc.blanco 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-04-06 10:25:02 UTC 
Created attachment 179342 [details]
screenshot of Calc and Writer print preview screens

Attachment shows difference between "Close Print Preview" in Calc and Writer.

Proposal is to modify Calc so that it appears the same as Writer.

From bug 148381 comment 4 (Heiko)

----
No objection. 

Writer uses in sw/uiconfig/swriter/toolbar/previewobjectbar.xml

<toolbar:toolbaritem xlink:href=".uno:ClosePreview" toolbar:style="image text"/>

And Calc in sc/uiconfig/scalc/toolbar/previewbar.xml

<toolbar:toolbaritem xlink:href=".uno:ClosePreview"/>

so adding the style might do the trick.

-----

Maybe EasyHack?
Comment 1 V Stuart Foote 2022-04-06 12:43:28 UTC 
+1 for consistent handling in the Print Preview TB
Comment 2 sdc.blanco 2022-04-13 22:11:08 UTC Comment hidden (obsolete)
Comment 3 Heiko Tietze 2022-04-14 14:31:44 UTC 
(In reply to sdc.blanco from comment #2)
> Polite ping to check if this ticket should be registered as an EasyHack.

Sure, it qualifies as easyhack. Code pointer in c0.