Bug 148551 - Inserting Statistics Fields defaults to A B C format
Summary: Inserting Statistics Fields defaults to A B C format
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Vasily Melenchuk (CIB)
URL:
Whiteboard: target:7.4.0 target:7.3.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-04-13 07:16 UTC by sdc.blanco
Modified: 2022-04-19 13:19 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-04-13 07:16:32 UTC
Insert Field (Ctrl-F2), Document tab, Type: Statistics, Select: Pages, Insert

Actual Result: Field is inserted with Format A B C
Expected Result: Field is inserted with Format 1 2 3

(same problem with other "Select" choices)

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d34d1db55978bdcff082af1e0f75b18fa6fc94f4
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL
Comment 1 sdc.blanco 2022-04-13 08:22:58 UTC
In 7.2.6.2, when opening Insert - Field -Document tab, Type: Statistics, the default Format is "As Page Style".  

No format seems to be set in the 7.4.0.0 version that I used.

To be clear--I understand how to set/change the format.  The OP is to report a regression that an appropriate default format is not being chosen in this case.
Comment 2 raal 2022-04-13 16:32:38 UTC
Confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: ab8d141967111ca81f4607db3618bb09214e42db
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo
Comment 3 raal 2022-04-13 16:43:21 UTC
This seems to have begun at the below commit.
Adding Cc: to Vasily Melenchuk; Could you possibly take a look at this one?
Thanks
 970e69b34247ceeffc14bf50600239d46a4d8eee is the first bad commit
commit 970e69b34247ceeffc14bf50600239d46a4d8eee
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Mon Jul 26 20:08:19 2021 +0200

    source 965636121cb1fb09739fcbca2c85f0a07bf6bf96

https://git.libreoffice.org/core/+/965636121cb1fb09739fcbca2c85f0a07bf6bf96
  tdf#143483: sw field edit: improved selection of format
Comment 4 Vasily Melenchuk (CIB) 2022-04-14 10:14:07 UTC
Reproduced. Yes, mine fix is guilty.
Comment 5 Commit Notification 2022-04-15 16:02:46 UTC
Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b2b821715a3745718a941fa99dda92137c0f0c86

tdf#148551: sw ui: set default format value for Insert Field dlg

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-04-15 21:22:59 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cb21bbc1210dc270a125613d571521701e379ff9

tdf#148551: sw: Add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2022-04-16 22:13:23 UTC
Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/911d7c3336f07a4ea49bb539bf1bd35f11eea2a0

tdf#148551: sw ui: set default format value for Insert Field dlg

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 sdc.blanco 2022-04-18 21:10:15 UTC
Verified with 

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: f8e11c6480ff0005715b989a6d4e2e10a3816cf6
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL

Thanks Vasily.  Works as expected again.
Comment 9 Commit Notification 2022-04-19 10:29:10 UTC
Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "libreoffice-7-3-3":

https://git.libreoffice.org/core/commit/f67484bdb6d99589789dfe0c2ac49f6160e9d95d

tdf#148551: sw ui: set default format value for Insert Field dlg

It will be available in 7.3.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.