Bug 148558 - FILEOPEN: RTF: graphic is missing
Summary: FILEOPEN: RTF: graphic is missing
Status: RESOLVED DUPLICATE of bug 127806
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.0 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: RTF-Images
  Show dependency treegraph
 
Reported: 2022-04-13 11:12 UTC by Xisco Faulí
Modified: 2022-09-02 07:30 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison LibreOffice 7.4 master and Word 2016 (236.46 KB, image/png)
2022-04-13 11:12 UTC, Xisco Faulí
Details
The example file in current master (328.36 KB, image/png)
2022-09-02 07:29 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2022-04-13 11:12:46 UTC
Created attachment 179515 [details]
Comparison LibreOffice 7.4 master and Word 2016

Steps to reproduce:
1. Open attachment 47273 [details] from bug 37716

-> The graphic at the bottom is missing. See comparison.

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: ab8d141967111ca81f4607db3618bb09214e42db
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2022-04-13 11:13:45 UTC
Also reproduced in

Version: 5.0.0.1
Build ID: 9a0b23dd0ab9652e0965484934309f2d49a7758e
Locale: en-US (es_ES.UTF-8)

but not in

Version: 4.4.7.2
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: es_ES.UTF-8
Comment 2 raal 2022-04-13 16:22:36 UTC
Confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: ab8d141967111ca81f4607db3618bb09214e42db
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo
Comment 3 raal 2022-04-13 16:28:43 UTC
This seems to have begun at the below commit.
Adding Cc: to Vasily Melenchuk; Could you possibly take a look at this one?
Thanks
 1e8917a7d44d256dc96e68b70c7ac310b1940863 is the first bad commit
commit 1e8917a7d44d256dc96e68b70c7ac310b1940863
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Wed May 27 19:07:43 2015 +0800

    source-hash-2c411e4487f24968d6a62958fec85e4e3e1fda93
    
    commit 2c411e4487f24968d6a62958fec85e4e3e1fda93
    Author:     Vasily Melenchuk <vasily.melenchuk@cib.de>
    AuthorDate: Mon Feb 2 09:43:51 2015 +0000
    Commit:     Miklos Vajna <vmiklos@collabora.co.uk>
    CommitDate: Fri Feb 13 18:23:15 2015 +0100
    
        tdf#49893 partial fix for blank rentangle problem in RTF
    
        * pib structure in rtf shape is processed always, if exists, not only
          for shape #75 (picture frame): it is possible for other shapes, at
          least for #1 (rectangle)
    
        * picture inside shape gets width and height from shape: this picture
          looks like pib object and should fit shape frame
    
        Conflicts:
            sw/qa/extras/rtfimport/rtfimport.cxx
    
        Reviewed on:
            https://gerrit.libreoffice.org/14396
    
        Change-Id: I5cf2e692940c4ddd8ab8b291ef65c0cc44c45f5d
Comment 4 Vasily Melenchuk (CIB) 2022-09-02 07:21:44 UTC
This one looks better since tdf#127806 fix. So I assume that that fix also resolves this regression.

There is still an empty frame on the left side: it did appear in between versions 5.0.4.2 and 5.1.6.2. Looks like another not related regression.
Comment 5 Gabor Kelemen (allotropia) 2022-09-02 07:29:28 UTC
Created attachment 182169 [details]
The example file in current master

This seems to have been fixed in

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: cba119c2a44bcef4684073412798aec193fbd1b5
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Presumably because of 

https://git.libreoffice.org/core/commit/57d9cc81b058757421cd082e5dbe32a919716807

tdf#127806: RTF import: use shape dimensions for pib picture
Comment 6 Gabor Kelemen (allotropia) 2022-09-02 07:30:34 UTC

*** This bug has been marked as a duplicate of bug 127806 ***