Description: Undo & redo of comments not working properly (doesn't restore) Steps to Reproduce: 1. Open Calc 2. Insert a comment on say E5 (and type something in it) 3. Insert a comment on say E6 (and type something in it) 4. Double Click cell E5 and type something in it 5. Select some different cell 6. Press CTRL+Z 2x 7. Press CTRL+Y 2x If you press and hold CTRL+Z and press and hold CTRL+Y it will work.. Actual Results: E5 lacks a comment Expected Results: E5 should also have a comment Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: efe854bf9b6daff3d0ecf6e3d04bd9a50bfaa3f3 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Jumbo
Also in Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL Still Ok with Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28
Reproducible in: Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 678446780446ae568ee8b1b814158c54ea5e393f CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Created attachment 191630 [details] List of commits bibisect-42max There are only 'skip'ped commits left to test. The first bad commit could be any of: 9db42ae030d6174dfae495f22552c1cf1f828041 fe1b32ea8db582b4961c404249eb0531682727c1 4c6b3908d3bbc4356b4e4b9b8861e27a8647ce9e 88920de480c5dda2c4ee3327dcaf6af304bb930f 0be518c0049ee9d0429b98bcd1420d36ba3a2416 ae66dd3cff1b23e457e5a2e648affcc838659040 75a254b90c224ff22b58ed3f18f32ef92a35da35 e186652b9c2c84d63ddc79a548e86f46cfcd2b7d 58c56c569c9127a90845f20b0745192cde6729dd 72e35d8a84f71508c81b1b802732938cc07e70fa 5ecf383dc6179520e5bb9f56c4d8d7918256b901 7db5e4e5e3475d862ed63dd50a77dbd8e416581f 6001e5ca3fb511b735bfabf32aa684bafcdf1785 dc9117672e7c7f1575fa6da0534836e38cf0f497 5c7881fd3f05889626b7e97e4cf336064be2aa5b 9ecc98afa0e205abbaf3cb23e248104425148203 27193737d09b6fb744d32b5f0fab8937185884d5 d04dfe79b36b153c2e98d8aeefefac2023ef3e4b 535cfbbf265e0852c4dee6d3d9c3c14e7ba70c97 f28e4f8a2103253f9bf45f5c42541eeb74a3f1f2 90bcec9d3a190f91e382279ccea94cb31acef64f be965f2a0146f9c844abf9cd3bb3a7c237fd31e2 0c5a8a0513868c3c8fa9b460f36fe20c4bb65247 1c1603b1d0cb62536571f9069f5f36e716071a88 38901f371ddfe89caa3b523918a5c3d67980d9f7 b4a4192b34cbb2e1b5c1330a8bdb9a52da957f66 abff72e5ad9728c69b5080a6a662ce011017088d e55c77e05ce910f9595f05b71deaeda7b1593168 768aab48c784e495f0129173565357176c80a0bc 9c68e1cb316bd3088f79327281f557c061f408d2 aacc3e0cb2662913cf26398f5ef66c35546df402 eda32299a88d88f5da1dde73806aea5e56343a48 1ec60e32273994ede1d67489bd1572290180666f c7878b44c0f02dcc0a30f57768075586d004cdbc 7db8f87c943435a2de51ff8aaed4c1dc129618a8 fb0eff3d45150b8b4b1343fb38cf9e2e7ee6a8fb f62fcc412c41a3ff76a3a0d5761a6a16aa347e47 f85705f317f3ee9984267a1818441c4bd1901586 7d738bfa73f74c75535788412d825425741d3d1c b2fb7a2596f0bcc1e7f08c040884b64e047cb28c 216c7851002a7664eb92dcb2769fc90c6f2607a9 d3a76fd2963d8678ce24afc3512c6109362938b8 721b1f8ea2ac3e9ae485d12f6b1d9ff06ca8073b dcb10d3077c4733205de62be2844e6237ae477ad 207db047a1f4b42bd5c670e2b2de8cefcae3fc3a 7207314abbeb1efea6219f725780fef3d225442d 6f4498031688f94a051439350ad12a9ec64ed976 f9401321512ebcd681741bed9427526689e1255b 7e13535da94cb4535479e2272bdd3a91e40f46c6 fff2d987e998e2ab9c662d2c9951267f7c0da615 b0340606d8d412fd86be4272eb5ec770dc2c010f fae218e4d25179f171282671a918eb2338fb91b1 2a54c67059b0cd3a75e5b12794c9d070e9ccf5dc b8e563ec6b3674824cd95e8e6ff0440feada8093 5ceae3568f43049bbc60126b5bedba0192bc02e4 e089957294fad271b7226364ea49ffdecc1f0857 8d050ce51ca8318af27243ced6bb1261d52e0264 ffd3d492edb2be5678cfaeb4fc2716f3117289d7 0dc0bce9d0d8db5455c97770a89e05e1802ea39b 1579b2415c1b22cc32de3a287c5fc727531c7e0a 5ca9572bb7471175c27951eea33c4e507b629e44 9ee1385facdff8ce0a0c6300a7fb4f02473532dd 8de579a4530ac8623b635378bf0d8921036da178 d0958cb4c3cdd01274919f536e89ce38b5297ec7 8cfd22930988cc80a4539ef4b8cc89a537b223c5 c96d56169483663dfc1483f0693c495571beb61f 67c60ff166138a4c3e98763cadcae8b150dc641e ed67af3d2e002263d099e8c4881a3dfb1298b672 b371f013ec130588ba20cf54aeeb250728439139 ea8e5cc451d33fe9de2d1829c4f5ba7c47f050b0 b8b159e2887bfc8f784f2662b425e7ccc9f372df d5c57c59576efd7fe12c8146a491ebe979ea30dc aa0bc0bb5ec3a57bbacadf37eb978863e582a4d6 We cannot bisect more! List of commits attached - git log 88920de480c5dda2c4ee3327dcaf6af304bb930f..aa0bc0bb5ec3a57bbacadf37eb978863e582a4d6 commit 1ec60e32273994ede1d67489bd1572290180666f Author: Matthew Francis <mjay.francis@gmail.com> Date: Sat Sep 5 22:15:15 2015 +0800 source-hash-5b483ed15d70bdc34b9520632ee569db0e6c4f9d commit 5b483ed15d70bdc34b9520632ee569db0e6c4f9d Author: Kohei Yoshida <kohei.yoshida@collabora.com> AuthorDate: Wed Oct 23 18:12:09 2013 -0400 Commit: Kohei Yoshida <kohei.yoshida@collabora.com> CommitDate: Wed Oct 23 19:01:19 2013 -0400 Cell note deletion should happen even when no cells exist in the column. This fixes one of the API test breakages. Change-Id: I8168d490ec5d519e151a74fb8c4343337262f15b
Range on cgit: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=d9fce11172d20856fe1d82fd5f48808b8265ecfd..9fd0abe9abfe37cb1591e1db794e0c921d95b172
I still confirm on: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded - - - Following comment 0, with Step 6 and 7: 6. Ctrl+Z 2x 7. Ctrl+Y 2x ... no comment appears on E5. But if you do a: 6. Ctrl+Z 3x 7. Ctrl+Y 3x both comments appear fine. Very very weird.