Bug 148591 - Rename "page text area top" and "page text area bottom" to "Above (or Below) page text area
Summary: Rename "page text area top" and "page text area bottom" to "Above (or Below) ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: sdc.blanco
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on:
Blocks: Shapes 148485
  Show dependency treegraph
 
Reported: 2022-04-14 11:47 UTC by sdc.blanco
Modified: 2022-04-25 07:02 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Demonstration of page text area and page text area top (15.14 KB, application/vnd.oasis.opendocument.text)
2022-04-14 11:48 UTC, sdc.blanco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-04-14 11:47:17 UTC
”page text area top” (bug 137650 ) and ”page text area bottom” (bug 103611) were added as options in the Position and Size dialog for Textbox and Shape. They can be seen in the Position and Size tab in the Position section, in the ”to” control for ”Vertical.  (click on the  dropdown box for the ”to” control).

Proposal is to rename these options.

Page text area top     →  Above page text area
Page text area bottom  →  Below page text area

Explanation of terms

1. ”Page text area” =  Page border (set by margins in Page tab of Page Style)  minus (any) Padding  (set in Borders tab of Page Style).

(attachment shows a page with a purple line around the Page border, and use View>Text Boundaries to see a gray outline of ”Page text area”)

2. ”Page text area top” =  area from top of the ”page text area” to top ”Entire page”

    (attachment shows two textboxes positioned in ”page text area top”)

    ”Page text area bottom” =  area from bottom of the ”page text area” to bottom of ”Entire page”

Main reasons for proposed change.  

1.  ”Page text area top” can be misinterpreted to mean that the object is placed in relation to the top edge of the Page text area.  (or the bottom edge for ”Page text area bottom”)

2. In fact, these controls refer to the regions OUTSIDE of the Page text area.
Proposed change is to make that idea explicit with:

"Above page text area" and "Below page text area".

As a result, the Position control sets the Vertical position to  ”Above page text area” and ”Below page text area.”

I know that there is not so much room in the dropdown box for ”to” control (bug 148512)– but the following proposal for the option names would be more precise, accurate, and informative.

Region above page text area
Region below page text area
Comment 1 sdc.blanco 2022-04-14 11:48:53 UTC
Created attachment 179551 [details]
Demonstration of page text area and page text area top

Attachment shows the concepts discussed in OP and provides some textboxes that can be used for positioning.
Comment 2 Heiko Tietze 2022-04-14 14:29:42 UTC
If we use Margin as suggested on bug 148593 it would apply here as well. Would "Top/Bottom page margin" work given we use "Left/right page margin"?
Comment 3 sdc.blanco 2022-04-14 14:45:33 UTC
(In reply to Heiko Tietze from comment #2)
> If we use Margin as suggested on bug 148593 
As explained in bug 148593 comment 3, that suggestion is wrong. 

But, as implied in comment 3, definitely a good idea to try to get fairly consistent, common terminology for all four of these options.
Comment 4 Heiko Tietze 2022-04-22 09:10:16 UTC
The topic was on the agenda of the design meeting. Bug 148593 comment 9 summarizes the discussion.
Comment 5 Commit Notification 2022-04-23 10:48:18 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6aec08a3dd4207edd65f076412ff58ca49c210c3

tdf#148591 rename two Vertical positioning regions

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Heiko Tietze 2022-04-25 07:02:35 UTC
(In reply to Commit Notification from comment #5)
> https://git.libreoffice.org/core/commit/
> 6aec08a3dd4207edd65f076412ff58ca49c210c3

You found a really good solution with "Above/Below page text area". Only a small change but clearly improving to the previous "Page text area top/bottom".