Bug 148632 - Point Bookmarks are not removed when the Table of Contents are removed. Can't get rid of them
Summary: Point Bookmarks are not removed when the Table of Contents are removed. Can't...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.6.2 release
Hardware: x86-64 (AMD64) All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: TableofContents-Indexes Bookmarks
  Show dependency treegraph
 
Reported: 2022-04-17 03:51 UTC by Eldar
Modified: 2022-05-12 14:55 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eldar 2022-04-17 03:51:20 UTC
Description:
When I insert Table of Contents then LO creates so called "Point Bookmarks" for all Headings. They looks as vertical gray bar symbol before Heading text. When I remove Table of Contents these bookmarks remains in the document and cannot be deleted.

Steps to Reproduce:
1. Type some text like "Title 1" and pick Heading 1 style for it;
2. Insert Table of Contents at new line. Point bookmark should be added before "Title 1" text;
3. Remove Table of Contents. Point Bookmark will remains.

Actual Results:
After removing ToC, Point Bookmark remains.

Expected Results:
Point Bookmarks should be removed when ToC are removed.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.2.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-GB (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.2-0ubuntu2
Calc: CL
Comment 1 Dieter 2022-05-04 07:20:52 UTC
I confirm it with

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 83d0f2eebae41d431d9a5bfd1a918523977752d0
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Additional information
Only visible, if "Field Shadings" is active. I'm not sure, if "point bookmarks" is the correct word for it.
Comment 2 Dieter 2022-05-04 07:27:57 UTC
Also present in

Version: 7.0.6.2 (x64)
Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL


Can't see field shadings when creating a TOC in

Version: 6.3.6.2 (x64)
Build-ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU-Threads: 4; BS: Windows 10.0; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: CL

So it seems that creating "Point Bookmarks" is the buggy behaviour (can't see a reason, why this should be useful).
Comment 3 raal 2022-05-10 19:09:26 UTC
This seems to have begun at the below commit.
Adding Cc: to Heiko Tietze; Could you possibly take a look at this one?
Thanks
 1e01a0e3cda0e026333bb266737547f00866babc is the first bad commit
commit 1e01a0e3cda0e026333bb266737547f00866babc
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Oct 1 10:39:42 2021 +0200

    source sha:5836cd37b6d292b1b4e72d5a5a6dc9029c5cf730

https://git.libreoffice.org/core/+/5836cd37b6d292b1b4e72d5a5a6dc9029c5cf730
   Resolves tdf#144677 - Show bookmarks like fields
Comment 4 Heiko Tietze 2022-05-11 10:01:36 UTC
(In reply to raal from comment #3)
> This seems to have begun at the below commit.

My patch just made the bookmarks appear like fields as requested in bug 144677. So if you disable field shading the "point bookmarks" will be hidden (formerly it was assigned to formatting marks). => NAB
Comment 5 Dieter 2022-05-11 10:16:08 UTC
(In reply to Heiko Tietze from comment #4)
> My patch just made the bookmarks appear like fields as requested in bug
> 144677. So if you disable field shading the "point bookmarks" will be hidden
> (formerly it was assigned to formatting marks). => NAB

Heiko, I disagree. This would disable field shading for the whole document (including all cross references,...) - in moste cases not very helpful. My expectation is: There shouldn't be a field shading, if there is no field.
Comment 6 Eldar 2022-05-11 10:18:22 UTC
(In reply to Heiko Tietze from comment #4)
> (In reply to raal from comment #3)
> > This seems to have begun at the below commit.
> 
> My patch just made the bookmarks appear like fields as requested in bug
> 144677. So if you disable field shading the "point bookmarks" will be hidden
> (formerly it was assigned to formatting marks). => NAB

They are not hidden, they are still present in document and affects text formatting and HTML exporting by adding ahrefs into Headings. Every field in Writer is editable and can be removed from document. How to remove these "Point Bookmars"? They are not removable. Once added you can't get rid of them.
Comment 7 Heiko Tietze 2022-05-11 11:30:20 UTC
Obviously there is a metacharacter. Maybe not a bookmark since it doesn't show in blue in older versions. Will have a closer look.
Comment 8 Heiko Tietze 2022-05-12 12:37:42 UTC
Miklos, my patch changed the color of bookmarks and assigned the appearance to the bookmark view options, before it was connected to metachars and blue. And even when reverting my patch I get the (now blue) indicator. Regression seems to be introduced by some other patch. Any idea?

@Eldar: Tools > Options > Writer > Formatting Aids: "Bookmarks" disables it.
Comment 9 Miklos Vajna 2022-05-12 14:55:32 UTC
Yes, probably the bookmarks were leaking even before your change, but it was less visible.