Bug 148736 - Popup dialog boxes for Arrow Style tab should use consistent terminology with the main Arrow style tab
Summary: Popup dialog boxes for Arrow Style tab should use consistent terminology with...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: sdc.blanco
URL:
Whiteboard: target:7.4.0
Keywords:
Depends on: 148737
Blocks: Arrow_Style
  Show dependency treegraph
 
Reported: 2022-04-22 20:32 UTC by sdc.blanco
Modified: 2022-06-03 10:15 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-04-22 20:32:11 UTC
General issue: popup boxes associated with Arrow Style tab in Line dialog should refer to "arrow styles" -- for the sake of UI consistency.

Select a textbox or shape, then right-click, choose Line > Arrow Styles tab.

A. Click "Modify"

Actual result:
Popup box with: ”Please enter a name for the new arrowhead”  

Change:  "arrowhead"   –>  ”arrow style” 

B. Click the Delete button with an existing arrow style. (don’t worry, you will get a confirmation popup)

Actual result:  Popup box with:  Do you really want to delete the arrowhead?

Change:  "arrowhead"   –>  ”arrow style”
Comment 1 sdc.blanco 2022-04-22 22:06:00 UTC
https://gerrit.libreoffice.org/c/core/+/133287
Comment 2 Heiko Tietze 2022-05-05 13:53:22 UTC
Would treat this as a duplicate of bug 148737.

The topic was on the agenda of the design meeting. "Style" is indeed used abundantly in the dialog. Preferably we should clean-up here but as a quick solution the term arrow style for arrowhead is acceptable. However, it would be required to change everywhere, meaning at the toolbar widget and the sidebar. So we may better keep it in the pop-up dialog and change at the parent.
Comment 3 sdc.blanco 2022-05-10 14:15:20 UTC
Summary of this bug is related to main issue of bug 148737, where each bug focuses on a separate aspect of the entire UI in relation to arrows.  

Resolution of this bug 148736 depends on the results of the discussion in bug 148737, so changing dependency here.
Comment 4 sdc.blanco 2022-05-18 15:00:38 UTC
(In reply to Heiko Tietze from comment #2)
>So we may better keep it in the pop-up dialog and change at the parent.
I understand that ”Arrow Styles” has gotten a ”deprecated” status, but that the recent patch to the Arrow Styles dialog (bug 126658) was accepted as a tolerable quick solution to that bug (as noted in 5 May design meeting minutes).

Meanwhile, as noted in bug 148737, comment 11, I am willing to change the "parent" (Arrow Styles tab in Line dialog) (and probably the "Arrow Styles" heading in the Line tab).

But the discussion in bug 148737 raised reasons (e.g., help translation, consistency within the entire Line dialog) that it might be better to change the Arrow Styles tab at the same time as the other tabs in the Line dialog.

     => If there is no intent to rework the Line dialog (or the Arrow Styles tab) before 7.4 UI freeze, but there is an intent to keep (for now) the recent patch from bug 126658 then I would propose to submit the patch in comment 1, because:

 1. It addresses the ”popup” dialogs associated with the Arrow Styles tab in the Line dialog, where
 2. some users (including myself) are hypersensitive to the UI terms within a related workflow. In this case, when using the ”Arrow styles” tab to add, delete, or rename a new style (according to the widgets in the Arrow styles tab), it is a source of ”unease” (to greater or less extent, depending on the user) when the popup dialogs to these widgets use a different term ”arrowheads” to refer to what the parent dialog refers to as ”styles”.

The proposal here tries to reconcile the diverse and diverging interests, so that it is possible to move forward. Otherwise, no strong opinion about how to proceed.
Comment 5 sdc.blanco 2022-05-27 12:01:55 UTC
(In reply to sdc.blanco from comment #4)
Repinging comment 4 @Heiko -- so I can "wrap-up" these recent "arrow style" tickets.
Comment 6 Heiko Tietze 2022-05-30 13:57:11 UTC
(In reply to sdc.blanco from comment #4)
>      => If there is no intent to rework the Line dialog (or the Arrow Styles
> tab) before 7.4 UI freeze, but there is an intent to keep (for now) the
> recent patch from bug 126658 then I would propose to submit the patch in
> comment 1, because:

At least no one volunteered to do the work. So yes, push your patch for now.
Comment 7 Commit Notification 2022-05-31 23:16:56 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5423dfb8549743bd5045b6e3b1ebad7980e62965

tdf#148736 improve labels for Arrow style popup dialogs

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 sdc.blanco 2022-05-31 23:21:37 UTC
(In reply to Heiko Tietze from comment #6)
> At least no one volunteered to do the work. So yes, push your patch for now.
Ok. Will close this ticket as FIXED, because it provides consistent terminology between the Arrow Styles tab and its popup dialog boxes. 

Meanwhile comment 4 gives a detailed account of the situation, if and when a more systematic overhaul of the "Line" dialog is made, and the word "Styles" is expunged.
Comment 9 BogdanB 2022-06-03 10:15:22 UTC
It's ok in
Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: f3b5cb5a17a451c9e7d9b47b5e8854c5e126801f
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded