1. Select a shape. 2. Look at the Arrow Style icon on the Drawing Objects Properties bar. 3. Click on dropdown box. Actual: Shows "Arrowheads" Expected: "Arrow Styles" (to be consistent with Arrow Styles tab). Also, the tooltip from this icon could be improved. For example: "Select start and end arrow styles for lines."
https://gerrit.libreoffice.org/c/core/+/133286
I worry that we’re overloading the term “style” (that’s why I filed tdf#145517 after all). I’d rather use the term “arrowhead” in more places in the UI and help — it seems to me like a more precise choice.
Relevant help page: https://help.libreoffice.org/7.4/en-US/text/shared/guide/linestyles.html?&DbPAR=SHARED Note "Line Styles" as well as "Arrow Styles". Main point of OP is to get consistency in UI.
(In reply to sdc.blanco from comment #3) > Main point of OP is to get consistency in UI. I support that approach.
Kind of duplicates bug 148736. The topic was on the agenda of the design meeting. "Style" is indeed used abundantly in the dialog. Preferably we should clean-up here but as a quick solution the term arrow style for arrowhead is acceptable. However, it would be required to change everywhere, meaning at the toolbar widget and the sidebar. So we may better keep it in the pop-up dialog and change at the parent. This particular case would be WF consequently. Setting to NEW anyway, in case you decide to change the label.
(In reply to Heiko Tietze from comment #5) To avoid misunderstanding.... > Preferably we should clean-up here > but as a quick solution the term arrow style for arrowhead is acceptable. Referent of "here"? why is the "quick solution" ≠ "clean-up" ? > would be required to change everywhere, meaning at the toolbar widget and the > sidebar. Agree. This patch (in comment 2) is for the toolbar widget and no problems in sidebar, though this patch will change the tooltip for sidebar, which should be all right. > keep it in the pop-up dialog and change at the parent. What is the parent here? (Bug 148736 comment 1 has link to proposed patch for pop-up dialogs) > This particular case would be WF consequently. Setting to NEW anyway, in > case you decide to change the label. Cannot grasp the point -- presumably depending on "parent" - otherwise why WF for "Arrowheads" in the toolbar dropdown box? when the idea is consistency.
(In reply to sdc.blanco from comment #6) > Referent of "here"? why is the "quick solution" ≠ "clean-up" ? Here means the UI (dialog, widgets on toolbar/sidebar). A style is typically a collection of attributes and the form of the arrow should use the more precise term Arrowhead. On the other hand we also aim for consistency and as you reported starting a dialog from a certain label should pick it up in the title/captions as well. > > keep it in the pop-up dialog and change at the parent. > What is the parent here? The parent is clearly the Line properties dialog where you start the dialog via Add. Changing the name in the "Add" dialog is one solution, changing it at the first place another. > > This particular case would be WF consequently. Setting to NEW anyway, in > > case you decide to change the label. > Cannot grasp the point -- presumably depending on "parent" - otherwise why > WF for "Arrowheads" in the toolbar dropdown box? when the idea is > consistency. WF if we change Arrow Style to Arrow * (line, head, foo...). If we do so the Add dialog doesn't need any treatment (given we keep Arrowhead).
(In reply to Heiko Tietze from comment #7) Thanks for elaborations. > The parent is clearly the Line properties dialog where you start the dialog > via Add. No particular need to defend "Arrow Style" per se...but some interest to consider a broader context and another "parent": the Line tab in the Line dialog, where... ... it seems that everything is called a "style"... "Arrow Styles", "Cap Styles", "Corner Styles", and "Style" (referring to Line Styles, which has its own tab). Presumably "Line, "Arrow", "Cap" and Corner" are a "collection of attributes" that make a ??? style (what would ??? be called? can't be "line style", that label is already used). Meanwhile, in everyday speech, one might speak about "styling" a line, where the word "styles" (for the different attributes of the ??? Style) signals the existence of variations in how to "style" each attribute of a line. Perhaps it does not follow the typical "logic" of style, but it seems to work better (imo) to have consistency in the generic label to refer to the attributes ("Arrow" "Corner "and "Cap", and "Line") rather than having the Line tab refer simply to: Line Corner Arrow Cap or to use "styles" with all the attributes ("Line", "Corner", and "Cap") except for "Arrow" or "Arrowhead". Imo, those versions would "break" the connection (consistency) between the attributes. Presumably, in this case, a user notices that all relevant attributes (that can be set) are called styles. (I accept that it may not be logical in terms of formal definitions -- but it seems good psychologically to keep consistency in the general label across the attributes) -- until someone reworks the entire dialog (i.e., all the tabs in the Line dialog to remove "styles", along with the resulting implications for updating the affected help pages.)
(In reply to sdc.blanco from comment #8) > Presumably "Line, "Arrow", "Cap" and Corner" are a "collection of > attributes" that make a ??? style (what would ??? be called? can't be "line > style", that label is already used). The "Line" is actually the "Pattern" with solid, dashed, dotted... But usually it's called a "solid line". Form and Type come in mind but ultimately the term style come to its limits here as it is on the one hand the best known for one particular attribute but on the other used to describe a collection. Regina, Adolfo: What do you think?
I think, that "Arrow Style" is wrong. "Style" is only correct to describe the settings for the whole line. The thing in question is called "marker" in ODF and in file markup. That term is used too in Inkscape and SVG. Corel Draw names it "Arrowhead". That is the title of our drop-down list. MS Office uses the label "Arrow type" for its selection drop-down list. The command is .uno:LineEndStyle API has the properties LineStart and LineEnd. I would prefer either "Arrowhead" or "Arrow type" in all places.
As a general comment... > I would prefer either "Arrowhead" or "Arrow type" in all places. This OP arose as a side-effect to bug 126658. No complaints were raised there about using "style" - but no objection to changing it (because my focus is only on consistency in the whole Line dialog and the help pages - no strong opinions about content of actual labels). If "arrow style" is going to be changed, then it seems better to do it at the same time as changing the other "styles" in the Line dialog -- --but if the preference is to change "arrow styles" now, then I will do that. I estimate about 35 strings (plus translation) would change in 11 help files if ”arrow styles” is modified. https://opengrok.libreoffice.org/search?project=help&full=%22arrow+style%22+OR+%22arrow+styles%22&defs=&refs=&path=&hist=&type=&xrd=&nn=1&si=full&si=full Because some of those strings have Line Style and Arrow Style in the same sentence, those sentences would need to be translated twice, if Line Styles and Arrow Styles are not changed at the same time. (In reply to Heiko Tietze from comment #5) > This particular case would be WF consequently. If "arrow styles" is dropped, then I agree that this ticket would become WF (or possibly modified if "arrow type" is chosen).
Seth Chaiklin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3d37b6a351aa8ba8f3edee22240f3e4f931903aa tdf#148737 improve tooltip for Arrow Styles icon It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Closing this ticket as FIXED, because OP was achieved. And a short status report. This ticket and bug 148736 grew out of an attempt to make UI consistency between the Arrow Styles tab in the Line dialog. And that attempt grew out of bug 126658, which tried to improve the labelling in the Arrow Styles tab. Along the way, dissatisfaction arose with the use of "Styles" throughout the "Line" dialog. That discussion was held in this ticket, perhaps with the conclusion that the Line dialog should be reworked to not use "style" (in relation to "Line", "Cap", "Corner" and "Arrow". comment 11 summarizes the situation -- pointing out that it would be better to revise all the "styles" in the Line dialog at one time -- to avoid retranslating sentences in help. That is where the story stops. There is now UI consistency (more or less) between the arrow styles tab and its popup dialogs, while the tooltip that was added for this ticket has used "arrowheads" as a first small step toward the "overhaul" of the Line dialog.