Bug 148920 - Styles filter on the paragraph style's Condition tab is disabled permanently
Summary: Styles filter on the paragraph style's Condition tab is disabled permanently
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:7.4.0 target:7.3.4
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-05-04 08:44 UTC by Mike Kaganski
Modified: 2022-05-06 17:39 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot with the disabled filter marked (17.05 KB, image/png)
2022-05-05 18:21 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-05-04 08:44:09 UTC
Since commit 1f066313218449cac494a887eb209311efbaa405
  Author Justin Luth <justin.luth@collabora.com>
  Date   Thu Dec 03 15:32:46 2020 +0300
    tdf#82802 sw page-style UI: remove pointless makeConditional CB

it's now impossible to enable the styles filter on the paragraph style's Condition tab.
Comment 1 Justin L 2022-05-05 17:42:24 UTC
Can you explain this a bit more, Mike?

I'm looking at "text body" paragraph style.

I am able to filter for hidden, hierarchical, html etc with the filter, so the filter itself seems functional.
Choosing "conditional" is empty, but that makes sense because there are no other conditional styles.

If I create a new conditional style, then when I use the "conditional styles" filter, I see the "text body" style listed, and vice versa when I modify the text body style.
Comment 2 Mike Kaganski 2022-05-05 18:21:50 UTC
Created attachment 179947 [details]
Screenshot with the disabled filter marked

(In reply to Justin L from comment #1)

Thank you for looking at this. I suppose that you meant the filter in the sidebar's style panel? Or maybe you actually are looking at the same filter that I show on the screenshot - which would mean there's some difference in different integrations (e.g., win vs gtk3 maybe?)
Comment 3 Justin L 2022-05-05 18:25:41 UTC
I was looking at the same filter as you. In linux gtk3 it is enabled.
Comment 4 Mike Kaganski 2022-05-05 18:26:49 UTC
Could you also check gen please?
Comment 5 Justin L 2022-05-05 18:29:13 UTC
Yup - disabled also in SAL_USE_VCLPLUGIN=gen ./instdir/program/soffice
Comment 6 Justin L 2022-05-05 19:18:16 UTC
fixed with http://gerrit.libreoffice.org/c/core/+/133910
Comment 7 Commit Notification 2022-05-06 07:37:56 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f82644fed3e9266ab21114a2266277059cd5ccb9

tdf#148920 sw page-style UI: make conditional filter usable

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-05-06 11:01:18 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/699cd04295bf25c6dd6c2be8bef9f065a772548f

tdf#148920 sw page-style UI: make conditional filter usable

It will be available in 7.3.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-05-06 17:39:19 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/701591fac7eea1ac797bbc328cc934434ffb714e

tdf#148920, tdf#91035: sw: Add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.