Bug 148947 - RTF document styles lost in V7.3.2
Summary: RTF document styles lost in V7.3.2
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.5.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: RTF-Styles
  Show dependency treegraph
 
Reported: 2022-05-05 09:31 UTC by Andres Rohr
Modified: 2022-10-11 15:59 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
RTF document of the bug description (1.26 MB, application/rtf)
2022-05-05 09:33 UTC, Andres Rohr
Details
Info that styles cannot be saved. (31.12 KB, image/jpeg)
2022-05-07 11:00 UTC, Martin Srdoš
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Rohr 2022-05-05 09:31:31 UTC
Description:
All styles lost. Bug introduced at saving RTF styles between V7.2.2 and V7.3.2.

Steps to Reproduce:
1. Start: On V7.2.2 x64 an RTF document written and edited
2. Install V7.3.2 x64
3. Open RTF => still looks good
4. Change 1 character and Save
5. Close document
6. Reopen document


Actual Results:
No styles there anymore, different font.

Expected Results:
Same visual as before the change


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.2.2.2 (x64) / LibreOffice Community
Build ID: 02b2acce88a210515b4a5bb2e46cbfb63fe97d56
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-CH (de_CH); UI: de-DE
Calc: threaded
Comment 1 Andres Rohr 2022-05-05 09:33:14 UTC
Created attachment 179941 [details]
RTF document of the bug description
Comment 2 Harald Koester 2022-05-06 10:02:48 UTC
Bug reproduced with version 7.3.2.2:
(1) Attached document opened with 7.3.2.2.
(2) Document saved under a modified name.
(3) Document with modified name reopened: Heading styles are lost!

With the same procedure with version 7.2.2 heading styles are not lost.

But:
If you create a simple rtf document with some headings and some text with version 7.2.2 the bug does not appear:
(1) Create new document and insert some headings and some text with version 7.2.2.
(2) Safe document as rtf.
(3) Reopen document with 7.3.2.2. Heading styles still exist.
(4) Save document under a modified name.
(5) Reopen document with modified name. Headings styles still exist!
 
Regression test:
7.2.4.1: OK
7.2.5.2: Not OK

Prioritization:
Loss of data (in this case paragraph styles), bug does not effect many users --> Medium critical
Comment 3 Xisco Faulí 2022-05-06 10:21:18 UTC
Hi Harald,

> Regression test:
> 7.2.4.1: OK
> 7.2.5.2: Not OK

Are both versions in German or is 7.2.4.1 in gernal and 7.2.5.2 in english? I suspect the problem is the style 'Überschrift 1' is converted to 'Heading 1' depending on the locale and then it fails.

I can also reproduce this issue in

Version: 6.4.0.0.alpha1+
Build ID: 9bc848cf0d301aa57eabcffa101a1cf87bad6470
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; 
Locale: es-ES (es_ES.UTF-8); UI-Language: en-US
Calc: threaded

and no, there is not dataloss in this issue
Comment 4 Martin Srdoš 2022-05-07 11:00:03 UTC Comment hidden (obsolete)
Comment 5 Martin Srdoš 2022-05-30 15:07:48 UTC
Bibisect result:
 d0a63755340fa2b474636750cd03e6eaf0f0039d is the first bad commit
commit d0a63755340fa2b474636750cd03e6eaf0f0039d
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Thu Oct 4 04:50:51 2018 -0700

    source 7ceebc68604e9eebc05155b2233bbadf3f4f056a

Adding Miklos Vajna to CC list.

But it means, that first bad commit was in version:
Version: 6.1.3.0.0+
Build ID: 7ceebc68604e9eebc05155b2233bbadf3f4f056a
CPU threads: 8; OS: Windows 10.0; UI render: GL; 
Locale: cs-CZ (cs_CZ); Calc: CL

And not between 7.2 and 7.3. So I hope, that the bibisecting went good...
Comment 6 Martin Srdoš 2022-05-30 15:13:54 UTC
For information: I bibisected it in windows, not in linux. In hardware is only windows.
Comment 7 raal 2022-10-11 15:59:00 UTC
Reproducible Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 07aa8138db9bbaf222f2b7cea12a9f7d0a8192d7
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: en-US
Calc: CL threaded