Bug 148981 - UI Issue: In View->Formatting Marks, the paragraph marker '¶' is inconspicuous and needs to be in rendered in contrasting colors [Problem occurs with colibre theme, sifr theme]
Summary: UI Issue: In View->Formatting Marks, the paragraph marker '¶' is inconspicuou...
Status: RESOLVED WONTFIX
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.2.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-08 08:30 UTC by Jambunathan K
Modified: 2022-05-09 16:36 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Sample ODT file with instructions. Content doesn't matter; It is a UI issue (16.96 KB, application/vnd.oasis.opendocument.text)
2022-05-08 08:30 UTC, Jambunathan K
Details
PI is inconspicuous; it is not in contrasting colors (182.92 KB, image/png)
2022-05-08 08:31 UTC, Jambunathan K
Details
PI indicator doesn't toggle according to state (179.35 KB, image/png)
2022-05-08 08:36 UTC, Jambunathan K
Details
Checkmarks are rendered in contrasting colors (Good!) (195.93 KB, image/png)
2022-05-08 08:39 UTC, Jambunathan K
Details
Presence or absence of checkmarks matches with state of field shadings (good!) (193.78 KB, image/png)
2022-05-08 08:44 UTC, Jambunathan K
Details
Icon themes on my Debian Unstable (70.07 KB, image/png)
2022-05-09 14:53 UTC, Jambunathan K
Details
Using sifr theme (145.91 KB, image/png)
2022-05-09 15:54 UTC, Jambunathan K
Details
Sifr theme: Pilcrow does not appear/disappear according to formatting marks settings in edit window (161.07 KB, image/png)
2022-05-09 15:56 UTC, Jambunathan K
Details
Sifr theme: Pilcrow in not in contrasting colors; (160.29 KB, image/png)
2022-05-09 15:57 UTC, Jambunathan K
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jambunathan K 2022-05-08 08:30:14 UTC
Created attachment 179991 [details]
Sample ODT file with instructions.  Content doesn't matter;  It is a UI issue

#+TITLE: In View->Formatting Marks, the paragraph marker 'π' is inconspicuous and needs to be in rendered in contrasting colors

1. Ensure that  ~LibreOffice~ is in ~Safemode~
2. Do` ~View~ ---> ~Formatting Marks~, and leave your mouse cursor on
   that menu entry.

3. Can you see the ~π~?

   I can't.

   ~π~ should be rendered in contrasting colors just like how the
   /menu text/ ~Formatting Marks~ is rendered.
   
4. Toggle the entry and notice
   1. what happens to the ~π~

   2. see if /menu text/ is in contrasing colours.

   Not only does the ~π~ always visible irrespective of the state of
   ~Formatting Marks~, it is also NOT in contrasting colors.

----------------

1. You can move the cursor entry to other sibling entries of
   ~Formatting Marks~, say the one for ~Field Shadings~.

   You can see the ~✓~ is rendered in contrasting characters.

2. Toggle the entry ~Field Shadings~ settings.  Notice
   1. what happens to the ~✓~

   2. see if /menu text/ is in contrasing colours.

~π~ behaviour should match ~✓~ behaviour

This is a UI issue is /similar/ to
[[https://bugs.documentfoundation.org/show_bug.cgi?id=148740][UI
Issue: In View->Styles, the `+` gets hidden when the cursor is on a
parent style]].  And my guess is it is /Linux/ only.
Comment 1 Jambunathan K 2022-05-08 08:31:02 UTC
Created attachment 179992 [details]
PI is inconspicuous; it is not in contrasting colors
Comment 2 Jambunathan K 2022-05-08 08:36:06 UTC
Created attachment 179993 [details]
PI indicator doesn't toggle according to state
Comment 3 Jambunathan K 2022-05-08 08:39:58 UTC
Created attachment 179994 [details]
Checkmarks are rendered in contrasting colors (Good!)
Comment 4 Jambunathan K 2022-05-08 08:44:21 UTC
Created attachment 179995 [details]
Presence or absence of checkmarks matches with state of field shadings (good!)
Comment 5 Jambunathan K 2022-05-08 08:49:21 UTC
There are two bugs

1.  'pi' is not rendered in contrasting colors
2. 'pi' indicator doesn't disappear when formatting marks is off edit window.

'pi'-'s behaviour should be same as 'checkmark'-'s behaviour.

From a user's point of view, (1) is similar to https://bugs.documentfoundation.org/show_bug.cgi?id=148740. 

Like that bug, this bug also may be Linux only.

(I don't have access to Windows machines.  So, I cannot confirm or deny the behaviour on Windows)

It might be a good idea ... to review if "highlight in contrasting colors" bug is in other places.  


------------

~$ dpkg -l | grep libre | grep writer
ii  libreoffice-writer                                 1:7.3.3~rc2-1                      amd64        office productivity suite -- word processor
~$ 



Version: 7.3.3.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 4; OS: Linux 5.17; UI render: default; VCL: x11
Locale: en-IN (en_IN); UI: en-US
Debian package version: 1:7.3.3~rc2-1
Calc: threaded


------
Comment 6 V Stuart Foote 2022-05-09 12:44:03 UTC
Can not confirm on Windows builds. The icon theme (Colibre) shows its Pilcrow (U+00B6) with "selection" *highlight shading* correctly rendering. Note: the icons, if configured to show in UI settings, on each menu item do not toggle--rather just a field shading is appled as provided by os/DE.

Also, unclear why with a Linux build you would be seeing Colibre icon theme with the X11 vcl. You should be seeing Breeze, or Elementary. But I would suggest running with Sifr for comparison.
Comment 7 V Stuart Foote 2022-05-09 12:51:28 UTC
Use 'Menu icons' on the Tools -> Options -> View panel to Hide or Show the icons on Menus, while the Automatic setting should follow os/DE.
Comment 8 Jambunathan K 2022-05-09 14:51:37 UTC
(In reply to V Stuart Foote from comment #6)
> Can not confirm on Windows builds. The icon theme (Colibre) shows its
> Pilcrow (U+00B6) with "selection" *highlight shading* correctly rendering.
> Note: the icons, if configured to show in UI settings, on each menu item do
> not toggle--rather just a field shading is appled as provided by os/DE.
> 
> Also, unclear why with a Linux build you would be seeing Colibre icon theme
> with the X11 vcl. You should be seeing Breeze, or Elementary. But I would
> suggest running with Sifr for comparison.

I never bothered about Icon theme ...  

I have only one icon theme `colibre`.

I am not  Debian power user, and go with what any ordinary joe will do when it comes to installing packages i.e., just do 

  sudo apt install libreoffice

and just go along with whatever the debian installer does.

FWIW, I have been 'sudo apt-update` and `sudo apt upgrade` from since the time of jessie, let us say for atleast > 5 years.


FYI, this is what I see right now.


$ dpkg -l | grep libreoffice | grep style

ii  libreoffice-style-colibre 1:7.3.3~rc1-2 all office productivity suite -- colibre symbol style

$ apt-cache search libreoffice | grep style

libreoffice-style-breeze - office productivity suite -- Breeze symbol style
libreoffice-style-colibre - office productivity suite -- colibre symbol style
libreoffice-style-elementary - office productivity suite -- Elementary symbol style
libreoffice-style-karasa-jaga - office productivity suite -- Karasa Jaga symbol style
libreoffice-style-sifr - office productivity suite -- Sifr symbol style
libreoffice-style-sukapura - office productivity suite -- Sukapura symbol style
libreoffice-style-tango - office productivity suite -- Tango symbol style


See also the screenshot


Just in case if this helps ... I run GNOME Flashback Desktop and I DO NOT use Wayland.


~/$ env | grep XDG

XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session0
XDG_MENU_PREFIX=gnome-flashback-
XDG_SESSION_DESKTOP=gnome-flashback-metacity
XDG_SESSION_TYPE=x11
XDG_GREETER_DATA_DIR=/var/lib/lightdm/data/kjambunathan
XDG_CURRENT_DESKTOP=GNOME-Flashback:GNOME
XDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0
XDG_SESSION_CLASS=user
XDG_RUNTIME_DIR=/run/user/1000

~/$ env | grep SESSION

SESSION_MANAGER=local/debian:@/tmp/.ICE-unix/1866,unix/debian:/tmp/.ICE-unix/1866
XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session0
GNOME_DESKTOP_SESSION_ID=this-is-deprecated
DESKTOP_SESSION=gnome-flashback-metacity
XDG_SESSION_DESKTOP=gnome-flashback-metacity
XDG_SESSION_TYPE=x11
XDG_SESSION_CLASS=user
GDMSESSION=gnome-flashback-metacity
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
Comment 9 Jambunathan K 2022-05-09 14:53:13 UTC
Created attachment 180017 [details]
Icon themes on my Debian Unstable
Comment 10 Jambunathan K 2022-05-09 15:05:53 UTC

(In reply to V Stuart Foote from comment #6)
> Can not confirm on Windows builds. The icon theme (Colibre) shows its
> Pilcrow (U+00B6) with "selection" *highlight shading* correctly rendering.
> Note: the icons, if configured to show in UI settings, on each menu item do
> not toggle--rather just a field shading is appled as provided by os/DE.
> 
> Also, unclear why with a Linux build you would be seeing Colibre icon theme
> with the X11 vcl. You should be seeing Breeze, or Elementary. But I would
> suggest running with Sifr for comparison.


Unless `colibre` theme is deprecated it is possible for Debian users to end up with colibre theme, and what the  UI does is very misleading.


Are you  suggesting that the `colibre` theme is deprecated  and that the Debian team should one of the other themes

libreoffice-style-breeze - office productivity suite -- Breeze symbol style
libreoffice-style-colibre - office productivity suite -- colibre symbol style
libreoffice-style-elementary - office productivity suite -- Elementary symbol style
libreoffice-style-karasa-jaga - office productivity suite -- Karasa Jaga symbol style
libreoffice-style-sifr - office productivity suite -- Sifr symbol style
libreoffice-style-sukapura - office productivity suite -- Sukapura symbol style
libreoffice-style-tango - office productivity suite -- Tango symbol style


in preference to the colibre theme.

I can file a Debian bug report depending on what you say.

Here is a the Debian Package link, and the Debian LibreOffice team can be seen on the right side of the page.

https://packages.debian.org/bullseye/libreoffice-style-colibre
Comment 11 V Stuart Foote 2022-05-09 15:32:56 UTC
Wow that Gnome-Flashback libreoffice package build by Debian is odd. Should probably not receive the Windows centric icon theme Colibre as the default and only icon theme.

Is there a package name issue? Note that colibre is all lower case and takes, but the other themes packaging start upper case and do not?

Take it up with the distro packagers, who should be telling you to install additional themes. Handling of the shadings for an icon theme when present on menus is going to be handled by the os/DE 

To me this seems Not Our Bug... but I'll leave it for other reviewers.
Comment 12 Jambunathan K 2022-05-09 15:53:49 UTC

Tried it with sifr theme.  Problem persists. See screenshots.


 ~$ dpkg -l | grep libreoffice-style
ii  libreoffice-style-breeze                           1:7.3.3~rc2-1                      all          office productivity suite -- Breeze symbol style
ii  libreoffice-style-colibre                          1:7.3.3~rc1-2                      all          office productivity suite -- colibre symbol style
ii  libreoffice-style-sifr                             1:7.3.3~rc2-1                      all          office productivity suite -- Sifr symbol style
~$
Comment 13 Jambunathan K 2022-05-09 15:54:20 UTC
Created attachment 180018 [details]
Using sifr theme
Comment 14 Jambunathan K 2022-05-09 15:56:28 UTC
Created attachment 180019 [details]
Sifr theme: Pilcrow does not appear/disappear according to  formatting marks settings in edit window
Comment 15 Jambunathan K 2022-05-09 15:57:20 UTC
Created attachment 180020 [details]
Sifr theme: Pilcrow in not in contrasting colors;
Comment 16 V Stuart Foote 2022-05-09 16:36:27 UTC
See the effect but do not believe it is significant.

We do not provide dynamic re-rendering of the menu icons--nor would we. Also the os/DE theme provides the color for the active/enabled vs. inactive/disabled menu item.

The menu icons are optional, set Automatic by default--to follow os/DE setting for the desktop, but you can choose to display Menu Icons (Tools -> Options -> View), set it to 'Hide'. 

Then without the menu icons--you get a functional checkbox feature on or off maybe not as informative (the icons do help) but you will have a indication on the menu of the status.

Same handling for the 'Show whitespace' which collapses header/footer when not activated.

But low discernibility when Menu Icons are enabled for particular os/DE is pretty benign as the UI responds to the action directly--you can see it applied or not.

There may be other menu icons that are less clear--but these two are not an issue and it would not be worth the dev effort to implement logic needed to instrument fg/bg contrast testing for menu icons to tweak them.