Bug 149036 - Missing icon for "Label Field" using Breeze icon theme
Summary: Missing icon for "Label Field" using Breeze icon theme
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.3.2.2 release
Hardware: All All
: medium normal
Assignee: Rizal Muttaqin
URL:
Whiteboard: target:7.3.5 target:7.4.0
Keywords:
Depends on:
Blocks: Icon-Theme-Breeze
  Show dependency treegraph
 
Reported: 2022-05-11 15:21 UTC by Rafael Lima
Modified: 2022-05-26 11:37 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the problem (18.73 KB, image/png)
2022-05-11 15:21 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2022-05-11 15:21:32 UTC
Created attachment 180065 [details]
Screenshot showing the problem

Hi! I was using the Basic Dialog Editor and noticed that the icon for the "Label Field" command hasn't been adapted to dark theme.

I am using the "Breeze (dark)" icon theme.

All is good with Colibre dark and Sifr dark.

See attached image for more information.

System info:
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4351a6ca782e1d2081ba819338ebbf6a2d2ee2b2
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL
Comment 1 Rizal Muttaqin 2022-05-25 23:45:02 UTC
Hi Rafael, thanks for the report!!


Could you provide step by step to reproduce the issue?
Comment 2 Rafael Lima 2022-05-26 01:00:26 UTC
(In reply to Rizal Muttaqin from comment #1)
> Could you provide step by step to reproduce the issue?

You have to open the Dialog Editor.

For that, go to Tools - Macros - Organize Dialogs. This will open the "Basic Macro Organizer".

In the "Dialogs" tab, select the Standard library and click New and then give a name to the dialog (f.i. "MyDialog").

Now select the dialog you've just created and click Edit. This will open the Dialog Editor. The toolbar with the missing icon will be at the bottom of the screen.
Comment 3 Rizal Muttaqin 2022-05-26 05:58:51 UTC
Yes the bug is valid and the missing icons are:
breeze*/cmd/lc_insertfixedtext.png
breeze*/cmd/32/insertfixedtext.png

Version: 7.4.0.0.alpha1+ / LibreOffice Community
Build ID: 4bd8b4e469a4084eee0ec467721704ae51f82301
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: en-US
Calc: threaded
Comment 4 Commit Notification 2022-05-26 07:57:10 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/97980ac82ca02d2f9fd5d18bc7f4463f9f1d85e5

Revert "Breeze: tdf#149036 add Label Field icons"

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-05-26 11:33:13 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/f98a8950da526e8a9952e22dade08c108f48d961

Breeze: tdf#149036 add Label Field icons

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2022-05-26 11:35:26 UTC
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/20deeb799a5298188eb967e3ba677b830c5a5d3c

Breeze: tdf#149036 add Label Field icons

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.