Bug 149108 - Edit conditional formatting prompt/confirmation dialog's "No/Yes" actions don't work as intended
Summary: Edit conditional formatting prompt/confirmation dialog's "No/Yes" actions don...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.6.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Conditional-Formatting
  Show dependency treegraph
 
Reported: 2022-05-16 14:22 UTC by Jeff Fortin Tam
Modified: 2023-04-29 04:35 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Fortin Tam 2022-05-16 14:22:03 UTC
Description:
The dialog makes no sense, see below.

Steps to Reproduce:
1. Apply conditional formatting to a region / cells ranges in a table.
2. Later, right-click in one of the cells and choose "Conditional formatting".

Actual Results:
Result: a dialog pops up, with "No" and "Yes" action buttons:

> "The selected cell already contains conditional formatting. You can either edit the existing conditional format or you define a new overlapping conditional format. Do you want to edit the existing conditional format?"

...however, the result of the "No" and "Yes" buttons make no sense. See below.

Expected Results:
* Clicking "No" currently does nothing, it just cancels your action, as far as I can tell. If so, then it should be labelled "Cancel".
* The "Yes" button does not open the "Manage conditional formatting" dialog as I would have expected it to, it opens a new blank conditional format for that specific selected cell. It's the opposite from what I expected when reading the dialog, and it fact it *directly contradicts* the 2nd sentence of that dialog. That button should be labelled "Add overlapping conditional format" or "Add new format".
* There needs to be a new (third) button labelled "Manage existing format", because that's what I actually want to do, especially after reading the dialog's text contents.


Reproducible: Always


User Profile Reset: No



Additional Info:
I like turtles.
Comment 1 raal 2022-10-29 22:09:08 UTC
repro 7.4.2, but no repro with Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: f3a82a8ba51195cf31b0f78164735acc7ebbcd2f
CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

clicking YES open the dialog with conditional format.

Please could you test it with dev version?  You can download it here:
http://dev-builds.libreoffice.org/daily/master/
Thank you
Comment 2 QA Administrators 2023-04-29 03:29:40 UTC Comment hidden (obsolete)
Comment 3 ady 2023-04-29 04:35:02 UTC
In 7.4.6:
* No > open CF dialog for the selected cells.
* Yes > open CF dialog for the area that already has CF in order to edit it.

Additionally, when more than one CF is already affecting the selected cells, the CF manage dialog opens for "Yes".

Setting as WFM.