Bug 149221 - [LOCALHELP] Bad Help page for database connection wizard
Summary: [LOCALHELP] Bad Help page for database connection wizard
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:7.5.0
Keywords:
Depends on:
Blocks: HelpGaps-NewFeatures
  Show dependency treegraph
 
Reported: 2022-05-21 18:45 UTC by Olivier Hallot
Modified: 2023-03-03 14:17 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2022-05-21 18:45:06 UTC
Database Wizard dialog. On the first page of the Database Wizard (Step 1 – Select database) operation of the Help button seems okay. 

With the Create a new database option selected on the first page, the Help button on the second page (Step 2 – Save and proceed) takes you off to the Writer Mail Merge Wizard help page, which isn’t relevant. 

With the Connect to an existing database option selected on the first page, the Help button on the second page always takes you off to the Writer Mail Merge Wizard help page whatever is selected in the drop-down menu of database types. 

I would expect the Help buttons on the second and subsequent pages to operate in a context-sensitive way, linking to a relevant help page. (I haven’t checked operation on the third or subsequent pages).

Can be connected to bug#134169 .
Comment 1 Rafael Lima 2022-09-21 18:51:22 UTC
Confirmed with

Version: 7.4.1.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.4.1~rc2-0ubuntu0.22.04.1~lo1
Calc: threaded

This seems to be a generic reference used by all "wizards" -> vcl/ui/wizard/Wizard

Actually, using this as HID for Mail Merge is also a mistake.

This is possibly the same explanation for bug 149224.
Comment 2 Rafael Lima 2022-09-21 19:17:06 UTC
FTR if you open Base then the Database Wizard will show with the "Select database" page selected. Pressing F1 now will work because the widget that is selected is "Create a new database", which is in the "generalpagewizard.ui".

Now if you click "Save and Proceed" and then click back "Select database" and press F1, you'll be redirected to the Mail Merge help page. Notice now that the "Create a new database" is no longer selected.

The problem here is that when you click "Save and Proceed" you fall back to the general wizard widget in LO.
Comment 4 Rafael Lima 2022-11-09 14:56:19 UTC
I'm changing it back to ASSIGNED because there's still some work to do.
Comment 5 Commit Notification 2022-11-11 10:30:21 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/f4fe6532ba4c65ee5baecfb4dc5167fd9111b97a

tdf#149221 More fixes to the Database Wizard dialog
Comment 6 Commit Notification 2022-11-18 14:00:54 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/b60b4ebbd1289522a96a0ad6e344a9f6a77d78c3

Related tdf#149221 Create an entry for the Help button in Frequently-Used Buttons page
Comment 7 Martin Srebotnjak 2022-11-23 19:56:53 UTC
Can this be marked as RESOLVED FIXED?
Comment 8 Rafael Lima 2022-11-23 20:42:59 UTC
(In reply to Martin Srebotnjak from comment #7)
> Can this be marked as RESOLVED FIXED?

Not yet... there's one last patch still pending review.

https://gerrit.libreoffice.org/c/core/+/140332

After this one this bug will be fixed.
Comment 9 Commit Notification 2022-12-01 13:28:53 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4a3964c904388c433066f7d1ab6f457374618182

tdf#149221 Handle HID on Database Wizard dialog

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.