Bug 149318 - (F1) Help for Format > Table (in Draw) has no help page linked to it, as well as "Minimal Row Height" and "Minimal Column Width" in its submenu
Summary: (F1) Help for Format > Table (in Draw) has no help page linked to it, as well...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
7.4.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:7.5.0 target:24.2.0
Keywords:
Depends on:
Blocks: Help-Link
  Show dependency treegraph
 
Reported: 2022-05-26 12:14 UTC by sdc.blanco
Modified: 2023-07-27 11:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2022-05-26 12:14:30 UTC
In Draw:

1. Format > Table , press F1
   
   Result: 404 Error Help ID: slot:0

2. Format > Table > Minimal Row Height, press F1

   Result: 404 Error Help ID: .uno:SetMinimalRowHeight

3. Format > Table > Minimal Column Width, press F1

   Result: 404 Error Help ID: .uno:SetMinimalColumnWidth
Comment 1 Commit Notification 2022-06-20 13:42:19 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/5688744142df9c9059b84e4ce8a092d60dcae9f9

tdf#149318 (part) refactor row/cell table optimization
Comment 2 sdc.blanco 2022-06-20 23:43:23 UTC
I am making pages for Minimal Row Height and Minimal Column Width
https://gerrit.libreoffice.org/c/help/+/135002
Comment 3 sdc.blanco 2022-08-13 23:23:32 UTC
(In reply to sdc.blanco from comment #0)
> In Draw:
> 
> 1. Format > Table , press F1
>    
>    Result: 404 Error Help ID: slot:0
Repro:

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 450471ebbdbff40998509731028b28e0ada53f58
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: da-DK (da_DK); UI: en-US
Calc: CL

Reopening ticket.

Also verifying that #2 and #3 in OP are resolved.
Comment 4 Rafael Lima 2023-07-24 18:08:20 UTC
This actually happens with any menu that has sub-items.

For instance, in Draw go to Tools - Language and press F1 (while keeping the mouse over "Language").

This will also returns "slot:0", meaning that this is a more general problem with pressing F1 in menus.
Comment 5 Rafael Lima 2023-07-24 21:34:22 UTC
The reason for this problem is that when you hover over Format - Table, then the submenu opens. Then if you keep the mouse over the "Table" entry while the submenu is opened and then you press F1, LO tries to open the selected entry in the submenu. Since no entry is selected, then you get the "slot:0".

This patch fixes this issue:
https://gerrit.libreoffice.org/c/core/+/154862

This allows to redirect F1 when hovering any menu entries that have submenus.
Comment 6 Commit Notification 2023-07-26 11:25:54 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6fa4e5965b2a79ae6735f4191a2261713a42356e

tdf#149318 Set HID for menus that have sub menus

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-07-26 22:28:39 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/b2d15fb7c2a59e7ca7f2e53001df4f9defe4e7dd

tdf#149318 Fix HIDs in Format menu (Draw)