Bug 149601 - Multiple grammar check passes needed for "Quotation marks" grammar checker
Summary: Multiple grammar check passes needed for "Quotation marks" grammar checker
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: https://ask.libreoffice.org/t/having-...
Whiteboard:
Keywords:
Depends on:
Blocks: Spell-Checking
  Show dependency treegraph
 
Reported: 2022-06-18 06:57 UTC by Mike Kaganski
Modified: 2022-08-02 06:13 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
An en-US text with problems for "Quotation marks" grammar checker (15.27 KB, application/vnd.oasis.opendocument.text)
2022-06-18 06:57 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2022-06-18 06:57:11 UTC
Created attachment 180817 [details]
An en-US text with problems for "Quotation marks" grammar checker

Preparation:
1. Make sure that the default en-US grammar checker is installed and working. (On windows, that means choosing English dictionary in Optional Components under Custom setup.)
2. Make sure that in Options->Language Settings->Writing Aids, Available Language modules has Lightproof grammar checker (English) selected, and under Edit button there, it is also selected for English (USA) language.
3. Make sure that in Options->Language Settings->English Sentence Checking, Quotation marks is checked under Punctuation. (Every other option may be unchecked on that page.)
4. Make sure that Tools->Automatic Spell Checking is enabled.

Reproduction:
5. Open the attached document, and wait some seconds to allow the automatic check to underline the problems with blue (grammar).
6. Start spellcheck (F7).

=> see how correcting every found problem (applying the suggestions) to the "The spellcheck is complete" dialog results in more found problems, requiring to repeat the check again several times to finally get rid of all the problems.

Expected would be everything found in the single pass, so the first "The spellcheck is complete" dialog actually gives a document free of the found grammar problems.

Tested with Version: 7.3.4.2 (x64) / LibreOffice Community
Build ID: 728fec16bd5f605073805c3c9e7c4212a0120dc5
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

Ref (with a screencast): https://ask.libreoffice.org/t/having-to-run-spellcheck-multiple-times-sometimes-20-times/78697
Comment 1 Dieter 2022-07-25 13:52:55 UTC
> Preparation:
> 1. Make sure that the default en-US grammar checker is installed and
> working. (On windows, that means choosing English dictionary in Optional
> Components under Custom setup.)
Done

> 2. Make sure that in Options->Language Settings->Writing Aids, Available
> Language modules has Lightproof grammar checker (English) selected,
Done

> and under Edit button there, it is also selected for English (USA) language.
Setting doesnt persist. Default language is German (Germany). I change it to English (USA) and press close button. If I press edit button again, setting is still German.

Version: 7.3.5.2 (x64) / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL
Comment 2 Mike Kaganski 2022-07-25 13:56:34 UTC
(In reply to Dieter from comment #1)
> > and under Edit button there, it is also selected for English (USA) language.
> Setting doesnt persist. Default language is German (Germany). I change it to
> English (USA) and press close button. If I press edit button again, setting
> is still German.

I'm sorry; did I ask to make something the default? I only wrote to check that *for English (USA) language*, the mentioned entry is *checked*.
Comment 3 Dieter 2022-08-02 06:13:42 UTC
(In reply to Mike Kaganski from comment #2)
> I'm sorry; did I ask to make something the default? I only wrote to check
> that *for English (USA) language*, the mentioned entry is *checked*.

I'm sorry, but I've misunderstood that dialog.

I confirm the described problem with

Version: 7.3.5.2 (x64) / LibreOffice Community
Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL