Bug 149609 - LibreOffice 7.3.3.2 Calc Button
Summary: LibreOffice 7.3.3.2 Calc Button
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.3.3.2 release
Hardware: x86-64 (AMD64) All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2 tar...
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2022-06-18 22:55 UTC by Alfredo Delgado
Modified: 2023-05-16 10:48 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Simple button test (14.46 KB, application/vnd.oasis.opendocument.spreadsheet)
2022-06-20 18:51 UTC, Alfredo Delgado
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alfredo Delgado 2022-06-18 22:55:22 UTC
Description:
In version LibreOffice (Calc) 7.1.7.2 the activation of the button to activate a macro works well, in version 7.3.3.2 it doesn't work the same way, I have to leave the cell where I enter the information so that I can only activate the button of the function, it is not a big problem, but could improve.

Actual Results:
Entering data into a cell, it should create a .jpg file so far so good, at the moment I need to activate a button to execute a macro (call a created image) it does not activate, I need to press the button twice or I have to exit of that cell and the button that calls the macro is just activated, this does not happen in previous versions, problem in Windows and Linux and the same thing happens.

Expected Results:
It works, but it's a little inconvenience, especially if you're used to it working right the first time and not needing two steps for the macro call to just work


Reproducible: Always


User Profile Reset: No



Additional Info:
I have carried out the tests on several machines and with Linux and Windows and it is the same problem.
Comment 1 m_a_riosv 2022-06-19 10:27:41 UTC
Better attach a sample file showing the issue, so someone can test to see what is happening.
Comment 2 Alfredo Delgado 2022-06-20 18:51:37 UTC
Created attachment 180854 [details]
Simple button test

Every time you choose a player in this test and then select one of the points buttons, in version 7.3.3 or 7.3.4 you have to select it twice for it to work, in previous versions that doesn't happen, it works smoothly, it's not a serious problem, but if a small annoyance.
Comment 3 QA Administrators 2022-06-21 03:30:39 UTC Comment hidden (noise)
Comment 4 raal 2022-06-22 16:16:28 UTC
Confirm with Version: 7.4.0.0.beta1+ / LibreOffice Community
Build ID: 6ab56a4fc946f6294513f23a3ea47aa0aa154b7d
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded Jumbo

works in Version: 7.2.7.2 / LibreOffice Community
Build ID: 20(Build:2)
CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ
Ubuntu package version: 1:7.2.7-0ubuntu0.21.10.1
Calc: threaded
Comment 5 raal 2022-06-22 16:23:51 UTC
This seems to have begun at the below commit.
Adding Cc: to Caolán McNamara; Could you possibly take a look at this one?
Thanks
 34740d7334bb0f64d0c530139bff7e2b45508d29 is the first bad commit
commit 34740d7334bb0f64d0c530139bff7e2b45508d29
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Thu Dec 2 22:59:41 2021 +0100

    source 24db04bbe09f19a49733699e42d0e095eb417fed

https://git.libreoffice.org/core/+/24db04bbe09f19a49733699e42d0e095eb417fed
   Related: tdf#145901 use x11 popover replacement for all non-menubutton cases
Comment 6 Caolán McNamara 2022-06-23 15:09:15 UTC
calc is fairly unusual with use of explicit CaptureMouse calls, I think its worth trying to run these menus with the mouse released at launch time.
Comment 7 Alfredo Delgado 2022-06-23 15:19:52 UTC
I'm just trying to help improve, the functionality of this option is not the same as previous versions, it's not a big bug, it's just a little hassle to enter or activate through the buttons (the idea is fast and not having to give two steps when before it was one step) Thank you and congratulations for the great product you have.
Comment 8 Commit Notification 2022-06-24 07:40:55 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/500a64964ad0f22bb11ff494430c70a069659ec6

tdf#149609 release mouse before showing popups from calc grid window

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2022-06-24 07:48:27 UTC
done in trunk and 7-4, will do for 7-3 if nothing surprising is found in the next few days
Comment 10 Commit Notification 2022-06-24 14:01:32 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/a60aaaf4bfcc2700af3ced4fd2de0ce3ecb8dfc6

tdf#149609 release mouse before showing popups from calc grid window

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Alfredo Delgado 2022-06-27 14:52:54 UTC
Including the new version 7.4.0 when one chooses a data validation option, after choosing a data and wanting to change to another sheet, this does not respond to the first time, the cursor changes position near the tab of the sheet that one chooses, this does not happen in versions 7.1 if it is versions 7.3 and 7.4,  Best regards
Comment 12 Commit Notification 2022-08-18 17:19:37 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/64fbd90158f5248636490237e23325c90683d9be

tdf#149609 release mouse before showing popups from calc grid window

It will be available in 7.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Caolán McNamara 2023-05-16 10:48:36 UTC
I *think* we solved the original problem. But I'm not sure about comment #11 if that relates to this bug or if it is another unrelated issue. It might be that it should be another separate bug report.