Bug 149610 - Whether and how to present iconography should adhere to what the host-OS or desktop-environment mandate (e.g. KDE Plasma Application Style settings)
Summary: Whether and how to present iconography should adhere to what the host-OS or d...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.3.4.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks: Toolbars Desktop-Integration
  Show dependency treegraph
 
Reported: 2022-06-18 23:27 UTC by Beedell, Roke Julian Lockhart
Modified: 2024-04-30 05:36 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Icons KCM configuration. (140.05 KB, image/png)
2023-04-29 23:51 UTC, Beedell, Roke Julian Lockhart
Details
Writer toolbar(s). (47.83 KB, image/png)
2023-04-29 23:52 UTC, Beedell, Roke Julian Lockhart
Details
Response to #c5 (91.39 KB, image/png)
2024-04-28 18:34 UTC, Beedell, Roke Julian Lockhart
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Beedell, Roke Julian Lockhart 2022-06-18 23:27:32 UTC
Description:
Whether and how to present iconography should adhere to what the host-OS or desktop environment (especially the stylistic KConfig Module of KDE Plasma and/or GNOME's relevant keys, which "https://askubuntu.com/a/67260/1002900" mentions) mandate.

Steps to Reproduce:
1. Invoke “kcmshell5 kcm_style”.
2. Customize how and/or whether iconography text is presented atop buttons and entries within contextual menus, as "http://i.imgur.com/lpMkSSA.png" depicts.

Actual Results:
LibreOffice does not adhere to this preference.

Expected Results:
LibreOffice should adhere to this preference.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Qt software presents text and/or iconography how I have configured it to be. This is useful for accessibility, especially screen-readers, because provision of text allows those buttons to be easily read. Additionally, provision of iconography and/or text is able to increase or decrease cognitive load: for me, replacement of all iconography with text allows me to operate digital interfaces significantly more quickly than I am able to if they are represented iconographically.
Comment 1 Stéphane Guillou (stragu) 2023-04-28 22:28:58 UTC
Thank you for your report.
Could you please test again with version 7.5 and report back? There has a been a number of improvements related to desktop integration, in particular related to dark mode, so things might have improved.
Please also share the full information copied from Help > About LibreOffice.
Comment 2 Beedell, Roke Julian Lockhart 2023-04-29 23:50:00 UTC
(In reply to Stéphane Guillou (stragu) from comment #1)
> Please also share the full information copied from Help > About LibreOffice.

Version: 7.5.3.1 (X86_64) / LibreOffice Community
Build ID: b7648c7b88c50f810321d044831850fd6da77d2a
CPU threads: 12; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

(In reply to Stéphane Guillou (stragu) from comment #1)
> Thank you for your report.
> Could you please test again with version 7.5 and report back? There has been a number of improvements related to desktop integration, in particular related to dark mode, so things might have improved.

Everything now adheres to the preference except the toolbar. If I disable all iconography in toolbars from KDE Plasma's Application Style KCM > Configure Icons and Toolbars > Text only, icons remain.
Comment 3 Beedell, Roke Julian Lockhart 2023-04-29 23:51:43 UTC
Created attachment 187009 [details]
Icons KCM configuration.
Comment 4 Beedell, Roke Julian Lockhart 2023-04-29 23:52:28 UTC
Created attachment 187010 [details]
Writer toolbar(s).
Comment 5 Stéphane Guillou (stragu) 2024-04-25 02:19:52 UTC
(In reply to `{third: "Beedell", first: "Roke"}`{.JSON5} from comment #3)
> Created attachment 187009 [details]
> Icons KCM configuration.
As you are using the gtk3 VCL plugin for LO (as seen in your version info), have you tried changing the settings with "Configure GNOME/GTK application style" on the right-hand side of the dialog?

And the other way around: are the settings as depicted followed if you start LO with:

SAL_USE_VCLPLUGIN=kf5 libreoffice

@Michael, I thought this might be right up your alley.
Comment 6 Michael Weghorn 2024-04-25 06:13:36 UTC
(In reply to `{third: "Beedell", first: "Roke"}`{.JSON5} from comment #0)
> Qt software presents text and/or iconography how I have configured it to be.
> This is useful for accessibility, especially screen-readers, because
> provision of text allows those buttons to be easily read.

Screen reader announcement should work independent of whether or not the text is shown as long as the accessible name for the items is properly set (which it should be regardless of whether text is shown; if not, that's a separate bug).

(In reply to `{third: "Beedell", first: "Roke"}`{.JSON5} from comment #2)
> Everything now adheres to the preference except the toolbar. If I disable
> all iconography in toolbars from KDE Plasma's Application Style KCM >
> Configure Icons and Toolbars > Text only, icons remain.

Since this is about the gtk3 VCL plugin: As far as I know, the toolbar isn't "welded" yet, i.e. it doesn't use native GTK widgets, while most of the remaining UI does by now. (So it might be that this is handled "automatically" by GTK without LO having extra handling, but that would need verification/checking.)
Comment 7 Beedell, Roke Julian Lockhart 2024-04-28 18:34:16 UTC
Created attachment 193882 [details]
Response to #c5

(In reply to Stéphane Guillou (stragu) from comment #5)
> (In reply to `{third: "Beedell", first: "Roke"}`{.JSON5} from comment #3)
> > Created attachment 187009 [details]
> > Icons KCM configuration.
> 
> As you are using the gtk3 VCL plugin for LO (as seen in your version info),
> have you tried changing the settings with "Configure GNOME/GTK application
> style" on the right-hand side of the dialog?

I've attached a screenshot which should answer that, although I'm uncertain what you're asking.

> And the other way around: are the settings as depicted followed if you start
> LO with:
> 
> SAL_USE_VCLPLUGIN=kf5 libreoffice

`SAL_USE_VCLPLUGIN=kf5 libreoffice` doesn't change anything, although I expect that I'm using KF6 by now, considering that I'm using https://download.fedoraproject.org/pub/fedora/linux/releases/40/Spins/x86_64/iso/Fedora-KDE-Live-x86_64-40-1.14.iso with cpe:/a:kde:plasma:6.0.4. However, nor does `SAL_USE_VCLPLUGIN=kf6 libreoffice`.

I'm using https://kojipkgs.fedoraproject.org//packages/libreoffice/24.2.2.1/3.fc40/x86_64/libreoffice-24.2.2.1-3.fc40.x86_64.rpm:

> Version: 24.2.2.1 (X86_64)
> Build ID: 420(Build:1)
> CPU threads: 12; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
> Locale: en-GB (en_GB.UTF-8); UI: en-US
> Calc: threaded
Comment 8 Beedell, Roke Julian Lockhart 2024-04-28 18:35:10 UTC
(In reply to Michael Weghorn from comment #6)
> Since this is about the gtk3 VCL plugin: As far as I know, the toolbar isn't
> "welded" yet, i.e. it doesn't use native GTK widgets, while most of the
> remaining UI does by now. (So it might be that this is handled
> "automatically" by GTK without LO having extra handling, but that would need
> verification/checking.)

That would indeed appear to explain this. Thanks for the insight.
Comment 9 Stéphane Guillou (stragu) 2024-04-29 02:08:31 UTC
(In reply to `{third: "Beedell", first: "Roke"}`{.JSON5} from comment #7)
> Created attachment 193882 [details]
> I've attached a screenshot which should answer that, although I'm uncertain
> what you're asking.
Right, sorry, I thought that right-hand side button would allow you to change GTK apps' widgets separately. I asked because your comment 2 shows you _were_ using the gtk3 VCL plugin.

> `SAL_USE_VCLPLUGIN=kf5 libreoffice` doesn't change anything, although I
> expect that I'm using KF6 by now, considering that I'm using
> https://download.fedoraproject.org/pub/fedora/linux/releases/40/Spins/x86_64/
> iso/Fedora-KDE-Live-x86_64-40-1.14.iso with cpe:/a:kde:plasma:6.0.4.
> However, nor does `SAL_USE_VCLPLUGIN=kf6 libreoffice`.
> 
> I'm using
> https://kojipkgs.fedoraproject.org//packages/libreoffice/24.2.2.1/3.fc40/
> x86_64/libreoffice-24.2.2.1-3.fc40.x86_64.rpm:
> 
> > Version: 24.2.2.1 (X86_64)
> > Build ID: 420(Build:1)
> > CPU threads: 12; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
So even when using kf6, the toolbars don't follow your Application Style settings?
Michael, this is more surprising then, right?
Comment 10 Michael Weghorn 2024-04-29 05:18:18 UTC
(In reply to Stéphane Guillou (stragu) from comment #9)
> So even when using kf6, the toolbars don't follow your Application Style
> settings?
> Michael, this is more surprising then, right?

The Qt-based VCL plugins (qt5/qt6/kf5/kf6) don't generally use native Qt widgets (see also tdf#130857), so unless LO has support for evaluating that style setting and implements handling for it in the VCL widgets (which I haven't checked) , this doesn't "just work" automatically.
(And in case of implementing welding for the Qt VCL plugins, the toolbar might have to be welded in addition for this to work, similar to the gtk4 case.)
Menus are different, because they are generally native Qt widgets.
Comment 11 Stéphane Guillou (stragu) 2024-04-29 05:50:34 UTC
(In reply to Michael Weghorn from comment #10)
> The Qt-based VCL plugins (qt5/qt6/kf5/kf6) don't generally use native Qt
> widgets (see also tdf#130857), so unless LO has support for evaluating that
> style setting and implements handling for it in the VCL widgets (which I
> haven't checked) , this doesn't "just work" automatically.
> (And in case of implementing welding for the Qt VCL plugins, the toolbar
> might have to be welded in addition for this to work, similar to the gtk4
> case.)
Thanks for clarifying, Michael. I'll let you decide if this needs to be blocked by bug 130857, or be marked as a duplicate of it.

In any case, I can confirm the issue as described on KDE Neon Testing + Plasma 6.0.4 + Qt 6.7.0 and:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+wayland)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

(Roke, please don't set your own reports to "new", they usually need to be confirmed by someone else.)
Comment 12 Michael Weghorn 2024-04-30 04:47:26 UTC
(In reply to Stéphane Guillou (stragu) from comment #11)
> Thanks for clarifying, Michael. I'll let you decide if this needs to be
> blocked by bug 130857, or be marked as a duplicate of it.

I think it makes sense to keep these reports separate. (There are 2 potential ways to address this: implement handling in VCL widgets or welding toolbar + implementing weld for qt6).
Comment 13 Stéphane Guillou (stragu) 2024-04-30 05:36:11 UTC
(In reply to Michael Weghorn from comment #12)
> I think it makes sense to keep these reports separate. (There are 2
> potential ways to address this: implement handling in VCL widgets or welding
> toolbar + implementing weld for qt6).
Thanks, sounds good. Putting bug 130857 in See Also then.