Bug 149617 - "Bitmap" string still used in area fill dropdowns, instead of the more accurate "Image" like in the dialog (see comment 10)
Summary: "Bitmap" string still used in area fill dropdowns, instead of the more accura...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.3.4.2 release
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval
Depends on:
Blocks: Area-Fill-Tab Sidebar-Properties
  Show dependency treegraph
 
Reported: 2022-06-19 11:16 UTC by phv
Modified: 2024-08-25 15:19 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments
Area dropdown list using French UI (27.76 KB, image/png)
2022-06-19 11:16 UTC, phv
Details
Use Backgroung option missing translation (11.09 KB, image/png)
2022-06-19 11:20 UTC, phv
Details

Note You need to log in before you can comment on or make changes to this bug.
Description phv 2022-06-19 11:16:35 UTC
Created attachment 180826 [details]
Area dropdown list using French UI

This issue concerns the French interface and has been reproduced in LibreOffice 7.3.4.2. For the purpose of consistency between the different interfaces and for the same element, the entry corresponding to "Bitmap" in Area ("Remplissage") should be translated "Image". This dropdown list is used in the "Drawing Object Properties" toolbar.

Also, "Hachure" entry should be written "Hachures", still for consistency with the Drawing Style menu.

Finally, in LibreOfficeDev 7.5, the "Use Background" option for area filling is missing from the "Drawing Object Properties" toolbar and the entry is not translated in the Drawing Style menu.

So several trivial issues but not worth opening several reports. Thank you.
Comment 1 phv 2022-06-19 11:20:55 UTC
Created attachment 180827 [details]
Use Backgroung option missing translation
Comment 2 phv 2022-06-19 11:39:07 UTC
See also Bug #95394 now fixed: Bitmap was changed to Image in some parts of the UI. It could be useful to check if this change has been applied everywhere.
Comment 3 Julien Nabet 2022-06-19 19:05:37 UTC
For "Bitmap", I don't know, "Image" is too general.

About "Hachure", I agree with you (https://translations.documentfoundation.org/languages/fr/libo_ui-master/search/?offset=1&q=note%3A5y6vj&sort_by=-priority%2Cposition&checksum=).

About "Use Background", it's been added 1 week ago so it's too recent to expect seeing it already translated.

Sophie/Jean-Baptiste: thought you might be interested in this one since it concerns French translation.
Comment 4 sophie 2022-06-23 12:11:18 UTC
(In reply to Julien Nabet from comment #3)
> For "Bitmap", I don't know, "Image" is too general.
And it should be first changed in the source code
> 
> About "Hachure", I agree with you
> (https://translations.documentfoundation.org/languages/fr/libo_ui-master/
> search/?offset=1&q=note%3A5y6vj&sort_by=-priority%2Cposition&checksum=).
Agreed
> 
> About "Use Background", it's been added 1 week ago so it's too recent to
> expect seeing it already translated.
yes, we need a bit of time to do the work ;)
> 
> Sophie/Jean-Baptiste: thought you might be interested in this one since it
> concerns French translation.
Thanks for the head-up Julien and thanks for the report phv!
Comment 5 Julien Nabet 2022-06-23 15:34:49 UTC
(In reply to sophie from comment #4)
> (In reply to Julien Nabet from comment #3)
> > For "Bitmap", I don't know, "Image" is too general.
> And it should be first changed in the source code
Heiko/Xisco: any thoughts here?

> > 
> > About "Hachure", I agree with you
> > (https://translations.documentfoundation.org/languages/fr/libo_ui-master/
> > search/?offset=1&q=note%3A5y6vj&sort_by=-priority%2Cposition&checksum=).
> Agreed
=> ok done on Weblate
Comment 6 Heiko Tietze 2022-06-24 08:02:40 UTC
(In reply to Julien Nabet from comment #3)
> For "Bitmap", I don't know, "Image" is too general.

An image could also be a vector graphic while bitmap refers to all kind of raster graphics whether bmp or png. So I'd also rather keep it.
Comment 7 Jean-Baptiste Faure 2022-06-27 15:29:11 UTC
Well, indeed there is inconsistency between the dropdown menu which says "Bitmap" and the tab in the dialog (from the contextual menu) which says "Image". The problem is not in the French translation, it is in the English. I think "Image" should be changed (back?) to "Bitmap" with the meaning "raster image" as said by Heiko.

Best regards.
JBF
Comment 8 Julien Nabet 2022-06-29 19:58:51 UTC
If we pick "Image", we should revert patches for tdf#95394 I suppose.

About "Bitmap", do we consider it became a kind of generic term equivalent to "raster image"? Just my personal opinion but "Bitmap" is one of a format of "raster image", so would prefer "raster image". At least people won't believe they can't use png files.
Of course 2 pbs here:
- it's a bit long
- not sure any casual user knows the signification of "raster"

So I took a look what Microsoft used in Powerpoint and read this link:
https://support.microsoft.com/en-us/office/change-the-background-of-your-slides-in-powerpoint-for-the-web-6927cd06-5a5b-483e-9d98-6e270df45700
It seems they chose "Picture", IHMO a good choice since:
- it's not too long
- everybody understands
- rather implies raster

In brief:
- Image: too generic
- Bitmap: too much related to the format
- Raster image: too long and not understandable for everyone
- Picture: don't see cons here only advantages :-)
Comment 9 Regina Henschel 2022-06-29 20:51:40 UTC
"Image" is not too general. A background fill can be a raster graphic or a vector graphic. To me, "picture" means the same as "photo", and that would be far too limited for background fill. I would use "image".
Comment 10 Julien Nabet 2022-06-29 21:17:53 UTC
(In reply to Regina Henschel from comment #9)
> "Image" is not too general. A background fill can be a raster graphic or a
> vector graphic. To me, "picture" means the same as "photo", and that would
> be far too limited for background fill. I would use "image".
You're right I interpret too "picture" as "photo" so "raster image".
I thought we could only use "raster image" but since we can also use "vectorial image", let's stick to "Image" which corresponds to both types.

Re reading the Powerpoint link, they support only raster images, at least on some "web support" case:
"PowerPoint for the web supports the following picture formats: .jpg, .jpeg, .png, .gif, .bmp, .wmf, .emf, .tif, and .tiff."

So indeed we should stick to "Image".


The string is in svx/source/tbxctrls/itemwin.cxx:
544 #define RID_SVXSTR_BITMAP  NC_("RID_SVXSTR_BITMAP", "Bitmap")

See https://opengrok.libreoffice.org/xref/core/include/svx/strings.hrc?r=ecfb1335#544

I suppose we may just change this but to avoid confusion, it may be relevant to change RID_SVXSTR_BITMAP into RID_SVXSTR_IMAGE

git grep -n RID_SVXSTR_BITMAP
include/svx/strings.hrc:544:#define RID_SVXSTR_BITMAP                                   NC_("RID_SVXSTR_BITMAP", "Bitmap")
svx/source/tbxctrls/itemwin.cxx:181:    rListBox.append_text(SvxResId(RID_SVXSTR_BITMAP));
svx/source/xoutdev/xattr.cxx:1785:            pId = RID_SVXSTR_BITMAP;

last one contains:
   1784         case drawing::FillStyle_BITMAP:
   1785             pId = RID_SVXSTR_BITMAP;

and this "FillStyle_BITMAP" is quite used and related to vars like "XML_BITMAP" or "CTF_FILLBITMAPNAME" so again "BITMAP" pattern in string name...

Do those vars correspond to any type of image too?
Comment 11 Stéphane Guillou (stragu) 2023-10-06 09:39:30 UTC
(In reply to Regina Henschel from comment #9)
> "Image" is not too general. A background fill can be a raster graphic or a
> vector graphic. To me, "picture" means the same as "photo", and that would
> be far too limited for background fill. I would use "image".

Thanks Regina. Indeed, I just tested using and SVG as a background image and it works - I just assumed it didn't because of the current or previous wording "bitmap"!

Affected:
- Sidebar: "Properties > Area > Fill" or "Properties > Page/Slide > Background"
- Draw tab of the Tabbed UI.

(In reply to Julien Nabet from comment #10)
> See
> https://opengrok.libreoffice.org/xref/core/include/svx/strings.
> hrc?r=ecfb1335#544
> 
> I suppose we may just change this but to avoid confusion, it may be relevant
> to change RID_SVXSTR_BITMAP into RID_SVXSTR_IMAGE

That would be the better way to do it. I was going to simply change the string but changing the variable name as well makes sense.

(In reply to Julien Nabet from comment #10)
> [...] and this "FillStyle_BITMAP" is quite used and related to vars like
> "XML_BITMAP" or "CTF_FILLBITMAPNAME" so again "BITMAP" pattern in string
> name...

Hossein, could you maybe have a look at the potential implications for dependents of the string and see if it qualifies for an easyHack?

(Given that the two other translation issues reported by phv are now solved, I've re-focused the summary)
Comment 12 BogdanB 2024-08-24 16:35:38 UTC
Bitmap, Use Slide Background: in the Image Toolbar.
Bitmap, [Use Slide Background not available]: in the Sidebar

Version: 24.8.0.3 (X86_64) / LibreOffice Community
Build ID: 0bdf1299c94fe897b119f97f3c613e9dca6be583
CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 13 BogdanB 2024-08-25 15:19:37 UTC
> [Use Slide Background not available]
About this we have now
https://bugs.documentfoundation.org/show_bug.cgi?id=162625